* [bug#52335] [PATCH 2/2] gnu: add package notcurses.scm [not found] <87k0fnwu47.fsf@nonconstructivism.com> @ 2021-12-29 17:48 ` Leo Famulari 2021-12-29 18:20 ` bug#52335: " Leo Famulari 0 siblings, 1 reply; 2+ messages in thread From: Leo Famulari @ 2021-12-29 17:48 UTC (permalink / raw) To: Blake Shaw; +Cc: 52335 On Wed, Dec 29, 2021 at 06:03:36PM +0700, Blake Shaw wrote: > Hi Leo, > > Sorry, I had missed your response and just found it when visiting Mumi. > > This is great feedback, and very informative for a new contributor. I > agree to all points, I had originally tried to keep the file size down > quite a bit, because with pandoc, c++, et al it nearly triples the > install size, and I couldn't quite figure out how to make those optional > as inputs. But if its best to provide a fully-featured over package over > a slimmed-down version, lets definitely go with that. Okay, thanks for letting me know. I found the use of DFSG_BUILD to be confusing, so I asked upstream: https://github.com/dankamongmen/notcurses/issues/2508 We can push the patch pending clarification of that. ^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#52335: [PATCH 2/2] gnu: add package notcurses.scm 2021-12-29 17:48 ` [bug#52335] [PATCH 2/2] gnu: add package notcurses.scm Leo Famulari @ 2021-12-29 18:20 ` Leo Famulari 0 siblings, 0 replies; 2+ messages in thread From: Leo Famulari @ 2021-12-29 18:20 UTC (permalink / raw) To: Blake Shaw; +Cc: 52335-done On Wed, Dec 29, 2021 at 12:48:38PM -0500, Leo Famulari wrote: > I found the use of DFSG_BUILD to be confusing, so I asked upstream: > > https://github.com/dankamongmen/notcurses/issues/2508 They helpfully clarified that we want this option to be ON. So, I've done that, partially migrated the package to the "new style" [0], and pushed as 7022eb6ea0f3be2f0eb58617c607ce34dfbff90a. Thanks a lot for the contribution! [0] I only changed the inputs to the new style. Changing the package's arguments field is future work. https://guix.gnu.org/en/blog/2021/the-big-change/ ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-29 18:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <87k0fnwu47.fsf@nonconstructivism.com>
2021-12-29 17:48 ` [bug#52335] [PATCH 2/2] gnu: add package notcurses.scm Leo Famulari
2021-12-29 18:20 ` bug#52335: " Leo Famulari
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/guix.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.