From: Leo Famulari <leo@famulari.name>
To: Vinicius Monego <monego@posteo.net>
Cc: 52247@debbugs.gnu.org
Subject: [bug#52247] [PATCH] gnu: shotcut: Find ffmpeg and mlt at runtime.
Date: Thu, 2 Dec 2021 14:16:38 -0500 [thread overview]
Message-ID: <Yakblu7552DJteo2@jasmine.lan> (raw)
In-Reply-To: <20211202161817.554276-1-monego@posteo.net>
On Thu, Dec 02, 2021 at 04:18:17PM +0000, Vinicius Monego wrote:
> * gnu/packages/video.scm (shotcut)[arguments]<:#phases>: Symlink ffmpeg and
> mlt binaries to the Shotcut bin folder and remove unused PATH and MLT_PREFIX
> environment variables in the 'wrap-executable phase.
I read your message about this in #50433:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=50433#17
The first link, which points to code that copies "files from other
projects to its bin directory", is in a function named deploy_mac, so I
don't think it's relevant for us.
Overall, I think it's unusual that we would copy or symlink one program
into another like this. I read build-shotcut.sh and it seems they
actually intend to compile ffmpeg themselves...
https://github.com/mltframework/shotcut/blob/af9f47882d64eb15105559e0729bc7b1e337a9bf/scripts/build-shotcut.sh#L1352
... and then use a wrapper script to point to it:
https://github.com/mltframework/shotcut/blob/af9f47882d64eb15105559e0729bc7b1e337a9bf/scripts/build-shotcut.sh#L1369
That's weird for something as common as ffmpeg, although I actually have
some private packages based on custom ffmpeg, so I am sympathetic.
I think we should ask upstream for advice. They do support distro
packagers, apparently:
https://github.com/mltframework/shotcut/issues/769#issuecomment-528686712
Can you do that? I can do it if you'd rather not. And I'm sorry if you
already knew all this and I'm just wasting your time.
next prev parent reply other threads:[~2021-12-02 19:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 16:18 [bug#52247] [PATCH] gnu: shotcut: Find ffmpeg and mlt at runtime Vinicius Monego
2021-12-02 19:16 ` Leo Famulari [this message]
2021-12-18 17:02 ` Vinicius Monego
2021-12-18 18:12 ` [bug#52247] [PATCH v2 1/2] " Vinicius Monego
2021-12-18 18:12 ` [bug#52247] [PATCH v2 2/2] gnu: shotcut: Adjust environment variables in 'wrap-program Vinicius Monego
2021-12-26 23:38 ` bug#52247: [PATCH v2 1/2] gnu: shotcut: Find ffmpeg and mlt at runtime Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yakblu7552DJteo2@jasmine.lan \
--to=leo@famulari.name \
--cc=52247@debbugs.gnu.org \
--cc=monego@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.