From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6Wc3CE8eqWHq/gAAgWs5BA (envelope-from ) for ; Thu, 02 Dec 2021 20:28:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 4AgeA08eqWHWGAAA1q6Kng (envelope-from ) for ; Thu, 02 Dec 2021 19:28:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AE09D15D7F for ; Thu, 2 Dec 2021 20:28:13 +0100 (CET) Received: from localhost ([::1]:34464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1msrkZ-0004or-QK for larch@yhetil.org; Thu, 02 Dec 2021 14:28:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msrZm-00013g-DZ for guix-patches@gnu.org; Thu, 02 Dec 2021 14:17:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37760) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1msrZm-0004W1-43 for guix-patches@gnu.org; Thu, 02 Dec 2021 14:17:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1msrZl-0007IT-Vk for guix-patches@gnu.org; Thu, 02 Dec 2021 14:17:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52247] [PATCH] gnu: shotcut: Find ffmpeg and mlt at runtime. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 02 Dec 2021 19:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52247 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vinicius Monego Cc: 52247@debbugs.gnu.org Received: via spool by 52247-submit@debbugs.gnu.org id=B52247.163847261128026 (code B ref 52247); Thu, 02 Dec 2021 19:17:01 +0000 Received: (at 52247) by debbugs.gnu.org; 2 Dec 2021 19:16:51 +0000 Received: from localhost ([127.0.0.1]:49306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1msrZb-0007Hy-Hs for submit@debbugs.gnu.org; Thu, 02 Dec 2021 14:16:51 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:39187) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1msrZX-0007Hi-7S for 52247@debbugs.gnu.org; Thu, 02 Dec 2021 14:16:49 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id C26F93200F76; Thu, 2 Dec 2021 14:16:40 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 02 Dec 2021 14:16:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=tfnVnVmQV3uDS/vQRqq58PU3 eg3ZPaFyn6zESD1OJ3U=; b=GgMguPy89yH6C4iKmJhJMCfZBOZP979CPlhdFYZ/ CTUOF6LVSUuVr77AzCfPpQiWSIn4+/DiPaNybj7D38TonSlScdDObHD48rO76D66 HN2ayu482RBVUPAvWLgQ8+y7yXdCgPnbXvLCfmN85TYgIgbZfj0PPesHdi0tsl/o 7M8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=tfnVnV mQV3uDS/vQRqq58PU3eg3ZPaFyn6zESD1OJ3U=; b=eepBhyM1a/qrJ5VAweRxAe KKphBmFV3QekLARWWvY/b8hGWZaSfKuJRdbgeBehCodNCQRfwSYaBhYL4tFPmpj9 Vs9zxnIHJFWHJ9bAixGFh/zTVC4DNvxpQ7Cq5x4UIAC860uAcKV+ukul0Ju78gup dgh6gYncvVuQWkZBi1+Op6XDa/eclEIlCfKNZgooBg2PoOC0fy57u6gPDelzFeh3 oxD5sE8t2s7welpO3U6merKg3ge7K7EN3P/mQy1ksQvtGkVt9HYiIjIv5Q/mF/Mw asQVGX5U8Zbd7yIu+wr14Xf+L7UaPhnG16Z1OhS4MAIE2Ghm9yrGgpGsGha5BnfA == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrieehgdduvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpeeigfdvhfefvdeitdduudegffevvdfgfeetuedugfdvuddugefftedugedtuddt vdenucffohhmrghinhepghhnuhdrohhrghdpghhithhhuhgsrdgtohhmpdgsuhhilhguqd hshhhothgtuhhtrdhshhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgr ihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 2 Dec 2021 14:16:39 -0500 (EST) Date: Thu, 2 Dec 2021 14:16:38 -0500 From: Leo Famulari Message-ID: References: <20211202161817.554276-1-monego@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211202161817.554276-1-monego@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638473293; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=tfnVnVmQV3uDS/vQRqq58PU3eg3ZPaFyn6zESD1OJ3U=; b=I9m00WS9eConUCfSFnHAP6wEHuqPG0SArmNlKxnkXXqUC0FGM1o1GbrK7qfzyxo29UfD8Y YehN65yf/Sb+08JPr9rEWqB6sLOZWREXdCd1f9pbcCLCL1YiiMnScGFVeSvlYIJgQPddbh Ytj5wJ3z1oiGtiDZkEnWlQa3D+Y4B1GP8wfz1RNCisDPta/u/bUeLcHg55KQKFw+nN2Fni bdG7BwSLC6NnqTH+WnMQrBWQfniv7q12yFMBnyG0OkPoxJPfkFcbw8Aa/8oa5K4nqPpDvJ LKO7IO5SGuIQrTBEfYjw6m11bftUlO9wbYaw4YEhRQLTVAvQRmrS+t3gDLzHeQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638473293; a=rsa-sha256; cv=none; b=cE7urN8umJBrtCxj2Vws/pvUgfOTHkdfTa8QuEmdzuN6H3qiYuXc6MD031TCDpZ/b5OGpG j2j4FoMyvApt8AsI24OOOJuhDfKe0XQ5V5Y6ytCTU+hilI7wBHDgF4AtaCx6ZSbaklSL8c Zec6joYWRo1OVmGNRbDU2QFfwZUMavi50h31PNJPd9agnn0fn2i33KEPEWV10zDPRl+wTA +JiJ4f4sdNM8qch8XJiEkWHJ9WVt7keXzf7WKMf43X+0Bz7pqmtNvPNmVMbDlqahCxGwa6 ePq0gV11zyBPETSCs2mXEoYM2WdVV9rwsDmVgHDn61W+2PWfzWB8f+EVIvX8qg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=GgMguPy8; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=eepBhyM1; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.02 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=GgMguPy8; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=eepBhyM1; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: AE09D15D7F X-Spam-Score: -2.02 X-Migadu-Scanner: scn0.migadu.com X-TUID: SXTx+hH/tNll On Thu, Dec 02, 2021 at 04:18:17PM +0000, Vinicius Monego wrote: > * gnu/packages/video.scm (shotcut)[arguments]<:#phases>: Symlink ffmpeg and > mlt binaries to the Shotcut bin folder and remove unused PATH and MLT_PREFIX > environment variables in the 'wrap-executable phase. I read your message about this in #50433: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=50433#17 The first link, which points to code that copies "files from other projects to its bin directory", is in a function named deploy_mac, so I don't think it's relevant for us. Overall, I think it's unusual that we would copy or symlink one program into another like this. I read build-shotcut.sh and it seems they actually intend to compile ffmpeg themselves... https://github.com/mltframework/shotcut/blob/af9f47882d64eb15105559e0729bc7b1e337a9bf/scripts/build-shotcut.sh#L1352 ... and then use a wrapper script to point to it: https://github.com/mltframework/shotcut/blob/af9f47882d64eb15105559e0729bc7b1e337a9bf/scripts/build-shotcut.sh#L1369 That's weird for something as common as ffmpeg, although I actually have some private packages based on custom ffmpeg, so I am sympathetic. I think we should ask upstream for advice. They do support distro packagers, apparently: https://github.com/mltframework/shotcut/issues/769#issuecomment-528686712 Can you do that? I can do it if you'd rather not. And I'm sorry if you already knew all this and I'm just wasting your time.