From: Ivan Gankevich <i.gankevich@spbu.ru>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 49685@debbugs.gnu.org
Subject: [bug#49685] [PATCH] gnu: Add task-spooler.
Date: Fri, 23 Jul 2021 21:22:52 +0300 [thread overview]
Message-ID: <YPsI/G+zDMlTVoZI@surge> (raw)
In-Reply-To: <e653b01880415556c8f30e0508be89618cecaddd.camel@telenet.be>
>> + (arguments
>> + `(#:make-flags
>> + (let ((c-flags "-g -O2"))
>> + (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
>> + "CC=gcc"
>
>This shoul be ,(string-append "CC=" (cc-for-target)), such that the cross-compiler
>is used when cross-compililng.
Fixed!
>> + (string-append "CFLAGS=" c-flags)
>> + (string-append "LDFLAGS=" c-flags)))
>
>Why are you adding "-g -O2" to LDFLAGS? I understand adding it to CFLAGS,
>but I don't see why it would be added to CFLAGS.
You’re right. Removed LDFLAGS.
>> + ;; Patch gzip/sendmail/shell paths.
>> + (substitute* "execute.c"
>> + (("execlp\\(\"gzip\"") (format #f "execlp(\"~a\"" (which "gzip"))))
>
>This needs to be (search-input-file "bin/gzip") instead of (which "gzip")
>for cross-compilation purposes ('which' searches for a native "gzip" in $PATH)
>'search-input-file' is not yet defined on 'master' (it's only on 'core-updates'
>currently), so you could do something like
>
> (string-append (assoc-ref inputs "gzip") "/bin/gzip")
Changed “which” to “string-append” here and everywhere else.
>If you fix 'sendemail' to install things in "sbin" instead of
>"usr/sbin", then you can do (search-input-file inputs "bin/sendmail").
I’ve sent a separate patch that fixes /sbin and /bin directories for “sendmail”.
Thank you for the review, Maxime!
next prev parent reply other threads:[~2021-07-23 18:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 18:35 [bug#49685] [PATCH] gnu: Add task-spooler Ivan Gankevich
2021-07-21 19:00 ` Maxime Devos
2021-07-23 18:22 ` Ivan Gankevich [this message]
2021-07-23 18:15 ` [bug#49685] [PATCH] gnu: sendmail: Install executables to $prefix/sbin and $prefix/bin directories Ivan Gankevich
2021-08-10 15:20 ` bug#49685: [PATCH] gnu: Add task-spooler Ludovic Courtès
2021-07-23 18:19 ` [bug#49685] " Ivan Gankevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPsI/G+zDMlTVoZI@surge \
--to=i.gankevich@spbu.ru \
--cc=49685@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.