From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id yKTyEwsJ+2CpTwAAgWs5BA (envelope-from ) for ; Fri, 23 Jul 2021 20:23:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id oJezDwsJ+2C1RwAAB5/wlQ (envelope-from ) for ; Fri, 23 Jul 2021 18:23:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DECDF105A8 for ; Fri, 23 Jul 2021 20:23:06 +0200 (CEST) Received: from localhost ([::1]:46134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6zpC-00012N-0D for larch@yhetil.org; Fri, 23 Jul 2021 14:23:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53292) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6zp8-000120-1p for guix-patches@gnu.org; Fri, 23 Jul 2021 14:23:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33040) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6zp7-0004HZ-Qv for guix-patches@gnu.org; Fri, 23 Jul 2021 14:23:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m6zp7-0002IA-MF for guix-patches@gnu.org; Fri, 23 Jul 2021 14:23:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49685] [PATCH] gnu: Add task-spooler. Resent-From: Ivan Gankevich Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 23 Jul 2021 18:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49685 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 49685@debbugs.gnu.org Received: via spool by 49685-submit@debbugs.gnu.org id=B49685.16270645808796 (code B ref 49685); Fri, 23 Jul 2021 18:23:01 +0000 Received: (at 49685) by debbugs.gnu.org; 23 Jul 2021 18:23:00 +0000 Received: from localhost ([127.0.0.1]:44586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6zp6-0002Hn-AA for submit@debbugs.gnu.org; Fri, 23 Jul 2021 14:23:00 -0400 Received: from mail.spbu.ru ([195.70.197.23]:52269 helo=cgp2.pu.ru) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6zp4-0002HU-7w for 49685@debbugs.gnu.org; Fri, 23 Jul 2021 14:22:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=spbu.ru; s=20180812; bh=wHCSqPLuiNo68Anj2itPdA8R0Or5fd36ikAT8K4PxU4=; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; b=Pe3WQP9s7NxUzk0 EA0/JdhhOd98181hf94VH83sdjTQzVz5P+SOGd70Iqz1dBDctpcu/vubISs5x5nze/57Mgz/aoYny MpqDwlDxJVwWSxgfpi0nRvqW/7pJKRSYrwssHeoorVPs5JdI2LTk4Ji6IKKe8Y+DwJUdOyVVAsExF gftqwZ99VPTN65xHaSYic6hsQIXAm+9FYlxhb1M3pwA+Y8NVpUsjj7v1PRMBeM9bvyT/duPRZ5rki JhiKMMEXcFmjUmN4W4ulbEH+Sfq2umpmLMXD47cM4p2bIjC1mWKzkszIxATT12XfQN3LEMCVO6j+8 GjllAZm69R4IPHQQ+ZQ== Received: from [172.27.221.159] (account st018947@spbu.ru HELO localhost) by spbu.ru (CommuniGate Pro SMTP 6.2.15) with ESMTPSA id 173762824; Fri, 23 Jul 2021 21:22:52 +0300 Date: Fri, 23 Jul 2021 21:22:52 +0300 From: Ivan Gankevich Message-ID: References: <20210721183504.9388-1-i.gankevich@spbu.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1627064587; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=QRusoJXPWNHzGlJcz5jfD0yGSX7LbUadS90GSk9jcJg=; b=eC1NAFtECyf3J23KMN9qgwmZyby7P/fwtnBO1CaM9YEghLp0hw5E/mHe9T9RhXoUlP4rzj yeUEldj+nQu/KxAz0g65y5RDyynasi+yi3UpysEcp2Z4FAKaaFusLtjzJq6SCUz9y8XMni t0YsbQ81xfBP5lxEbSnEPUGgQzNcnllUTL+jnh0mafGzwagKOQT5XY8WLiSrs8dgKVY5PC 2AbYmlLIALPBavt/EkjhiySTn4z0Idb/30UEup2tw6M9valo1+VX3ex1IovyoZ2fYeODdh 8oaJ7YxcNBImanq/RqaCwgqeIeO00fuzIMmJ4X97BZRzDb5xqyAl6gKoOOom6A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1627064587; a=rsa-sha256; cv=none; b=iAvEKU7XwBaVXLn0JmPcaSlhCVcfUjmbxinHqfmvdxkCkc8p/LtZ5SioktQ4pZqpxPiyfw NEWRQyiY9bkCHsqErabLz/6s6pyT0UBfui36qdeoZMfqDAmBbvH4pQh7NS9FeVJ+E/wOxH 625KMYNjqiFj83c42tvNndvzvWLWMFan3EkYOX8wQtE66H3vn44sPq/43g4xz0UGd1++Jo dt1rac+83yfVv8N325X+52JPUJblzMjvHZy+6bFP/N9Or/Xj4OxHLSzchmHua5nPDOx1rA CbcRt/LpkiCVvJpS81z/MVaiCaNPkUxhpIl8PRVv/ziSgqnDaEyzyYrSAo7+/Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=spbu.ru header.s=20180812 header.b=Pe3WQP9s; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.58 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=spbu.ru header.s=20180812 header.b=Pe3WQP9s; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: DECDF105A8 X-Spam-Score: 0.58 X-Migadu-Scanner: scn0.migadu.com X-TUID: I4I+joITdKpS >> + (arguments >> + `(#:make-flags >> + (let ((c-flags "-g -O2")) >> + (list (string-append "PREFIX=" (assoc-ref %outputs "out")) >> + "CC=gcc" > >This shoul be ,(string-append "CC=" (cc-for-target)), such that the cross-compiler >is used when cross-compililng. Fixed! >> + (string-append "CFLAGS=" c-flags) >> + (string-append "LDFLAGS=" c-flags))) > >Why are you adding "-g -O2" to LDFLAGS? I understand adding it to CFLAGS, >but I don't see why it would be added to CFLAGS. You’re right. Removed LDFLAGS. >> + ;; Patch gzip/sendmail/shell paths. >> + (substitute* "execute.c" >> + (("execlp\\(\"gzip\"") (format #f "execlp(\"~a\"" (which "gzip")))) > >This needs to be (search-input-file "bin/gzip") instead of (which "gzip") >for cross-compilation purposes ('which' searches for a native "gzip" in $PATH) >'search-input-file' is not yet defined on 'master' (it's only on 'core-updates' >currently), so you could do something like > > (string-append (assoc-ref inputs "gzip") "/bin/gzip") Changed “which” to “string-append” here and everywhere else. >If you fix 'sendemail' to install things in "sbin" instead of >"usr/sbin", then you can do (search-input-file inputs "bin/sendmail"). I’ve sent a separate patch that fixes /sbin and /bin directories for “sendmail”. Thank you for the review, Maxime!