all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 49659@debbugs.gnu.org, Maxime Devos <maximedevos@telenet.be>
Subject: [bug#49659] [PATCH core-updates] gnu: guile: Fix failing tests on i686-linux.
Date: Tue, 20 Jul 2021 21:22:33 +0300	[thread overview]
Message-ID: <YPcUaWxhYMebiTIa@3900XT> (raw)
In-Reply-To: <871r7tks2i.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1445 bytes --]

On Tue, Jul 20, 2021 at 03:55:49PM +0200, Ludovic Courtès wrote:
> Hi!
> 
> Maxime Devos <maximedevos@telenet.be> skribis:
> 
> > i586-gnu might have the same issue.
> 
> Please add a “Fixes …” line.
> 
> > * gnu/packages/guile.scm
> >   (guile-3.0)[arguments]<#:configure-flags>: Add
> >   "-fexcess-precision=standard" to CFLAGS.
> 
> Nitpick: the first two lines can be joined.  :-)
> 
> >       (substitute-keyword-arguments (package-arguments guile-2.2)
> >         ((#:configure-flags flags ''())
> > -        (let ((flags `(cons "--enable-mini-gmp" ,flags)))
> > +        ;; -fexcess-precision=standard is required when compiling for
> > +        ;; i686-linux, otherwise "numbers.test" will fail.
> > +        (let ((flags `(cons* "CFLAGS=-g -O2 -fexcess-precision=standard"
> > +                              "--enable-mini-gmp" ,flags)))
> 
> Yay!  Questions:
> 
>   1. Should we make it conditional on
>        (or (string-prefix? "i686-" %host-type)
>            (string-prefix? "i586-" %host-type))
>      ?  (I wonder why armhf-linux doesn’t have the same problem.)
> 
> Thoughts?
> 
> Ludo’.
> 

I'd also like to mention that this bug doesn't show up on 32-bit powerpc.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2021-07-20 18:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-20 11:27 [bug#49659] [PATCH core-updates] gnu: guile: Fix failing tests on i686-linux Maxime Devos
2021-07-20 13:55 ` Ludovic Courtès
2021-07-20 16:55   ` Maxime Devos
2021-07-20 20:51     ` Ludovic Courtès
2021-07-20 18:22   ` Efraim Flashner [this message]
2021-07-20 21:34 ` [bug#49659] [PATCH v2\ core-updates v2] " Maxime Devos
2021-07-21 13:49   ` bug#49659: [PATCH core-updates] " Ludovic Courtès
2021-07-21 14:50     ` [bug#49659] " Mathieu Othacehe
2021-07-23  9:07       ` Ludovic Courtès
2021-07-23  9:27         ` Maxime Devos
2021-07-25 23:52         ` Thiago Jung Bauermann via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPcUaWxhYMebiTIa@3900XT \
    --to=efraim@flashner.co.il \
    --cc=49659@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.