From: Maxime Devos <maximedevos@telenet.be>
To: 49659@debbugs.gnu.org
Cc: ludo@gnu.org, Maxime Devos <maximedevos@telenet.be>
Subject: [bug#49659] [PATCH v2\ core-updates v2] gnu: guile: Fix failing tests on i686-linux.
Date: Tue, 20 Jul 2021 23:34:17 +0200 [thread overview]
Message-ID: <20210720213417.5285-1-maximedevos@telenet.be> (raw)
In-Reply-To: <20210720112712.25905-1-maximedevos@telenet.be>
i586-gnu might have the same issue.
* gnu/packages/guile.scm (guile-3.0)[arguments]<#:configure-flags>:
Add "-fexcess-precision=standard" to CFLAGS when
(target-x86-32?) is true.
Fixes: <https://issues.guix.gnu.org/49368>.
---
gnu/packages/guile.scm | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm
index d78c57e88c..86621e4ca0 100644
--- a/gnu/packages/guile.scm
+++ b/gnu/packages/guile.scm
@@ -16,6 +16,7 @@
;;; Copyright © 2018 Eric Bavier <bavier@member.fsf.org>
;;; Copyright © 2019 Taylan Kammer <taylan.kammer@gmail.com>
;;; Copyright © 2020, 2021 Efraim Flashner <efraim@flashner.co.il>
+;;; Copyright © 2021 Maxime Devos <maximedevos@telenet.be>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -316,11 +317,19 @@ without requiring the source code to be rewritten.")
(arguments
(substitute-keyword-arguments (package-arguments guile-2.2)
((#:configure-flags flags ''())
- (let ((flags `(cons "--enable-mini-gmp" ,flags)))
- ;; XXX: JIT-enabled Guile crashes in obscure ways on GNU/Hurd.
- (if (hurd-target?)
- `(cons "--disable-jit" ,flags)
- flags)))
+ ;; XXX: JIT-enabled Guile crashes in obscure ways on GNU/Hurd.
+ `(cons* ,@(if (hurd-target?)
+ '("--disable-jit")
+ '())
+ ;; -fexcess-precision=standard is required when compiling for
+ ;; i686-linux, otherwise "numbers.test" will fail
+ ;; (see <https://issues.guix.gnu.org/49368> and
+ ;; <https://issues.guix.gnu.org/49659>).
+ ,@(if (target-x86-32?)
+ '("CFLAGS=-g -O2 -fexcess-precision=standard")
+ '())
+ "--enable-mini-gmp"
+ ,flags))
((#:phases phases)
`(modify-phases ,phases
(add-before 'check 'disable-stack-overflow-test
--
2.32.0
next prev parent reply other threads:[~2021-07-20 21:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 11:27 [bug#49659] [PATCH core-updates] gnu: guile: Fix failing tests on i686-linux Maxime Devos
2021-07-20 13:55 ` Ludovic Courtès
2021-07-20 16:55 ` Maxime Devos
2021-07-20 20:51 ` Ludovic Courtès
2021-07-20 18:22 ` Efraim Flashner
2021-07-20 21:34 ` Maxime Devos [this message]
2021-07-21 13:49 ` bug#49659: " Ludovic Courtès
2021-07-21 14:50 ` [bug#49659] " Mathieu Othacehe
2021-07-23 9:07 ` Ludovic Courtès
2021-07-23 9:27 ` Maxime Devos
2021-07-25 23:52 ` Thiago Jung Bauermann via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210720213417.5285-1-maximedevos@telenet.be \
--to=maximedevos@telenet.be \
--cc=49659@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.