* [bug#46445] [PATCH] tests: Make the STORE test more robust in a "pure" environment.
@ 2021-02-11 20:25 Leo Famulari
2021-02-25 20:13 ` Leo Famulari
2021-03-17 21:36 ` Ludovic Courtès
0 siblings, 2 replies; 4+ messages in thread
From: Leo Famulari @ 2021-02-11 20:25 UTC (permalink / raw)
To: 46445
Otherwise, the test crashes (not fails) when run in `guix environment --pure guix`.
I'm not sure this is the right approach, when I look at commit
3d43017026f9995ad128915db8ca5eafe061bf75, which added this variable.
* tests/store.scm (%shell): Fallback to "/bin/sh".
---
tests/store.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/store.scm b/tests/store.scm
index cda0e0302f..9c25adf5e9 100644
--- a/tests/store.scm
+++ b/tests/store.scm
@@ -50,7 +50,7 @@
(open-connection-for-tests))
(define %shell
- (or (getenv "SHELL") (getenv "CONFIG_SHELL")))
+ (or (getenv "SHELL") (getenv "CONFIG_SHELL") "/bin/sh"))
\f
(test-begin "store")
--
2.30.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#46445] [PATCH] tests: Make the STORE test more robust in a "pure" environment.
2021-02-11 20:25 [bug#46445] [PATCH] tests: Make the STORE test more robust in a "pure" environment Leo Famulari
@ 2021-02-25 20:13 ` Leo Famulari
2021-03-17 21:36 ` Ludovic Courtès
1 sibling, 0 replies; 4+ messages in thread
From: Leo Famulari @ 2021-02-25 20:13 UTC (permalink / raw)
To: 46445
Ping!
Is this change correct?
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#46445] [PATCH] tests: Make the STORE test more robust in a "pure" environment.
2021-02-11 20:25 [bug#46445] [PATCH] tests: Make the STORE test more robust in a "pure" environment Leo Famulari
2021-02-25 20:13 ` Leo Famulari
@ 2021-03-17 21:36 ` Ludovic Courtès
2021-03-18 19:16 ` bug#46445: " Leo Famulari
1 sibling, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2021-03-17 21:36 UTC (permalink / raw)
To: Leo Famulari; +Cc: 46445
Leo Famulari <leo@famulari.name> skribis:
> Otherwise, the test crashes (not fails) when run in `guix environment --pure guix`.
>
> I'm not sure this is the right approach, when I look at commit
> 3d43017026f9995ad128915db8ca5eafe061bf75, which added this variable.
>
> * tests/store.scm (%shell): Fallback to "/bin/sh".
LGTM, thanks!
Ludo'.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#46445: [PATCH] tests: Make the STORE test more robust in a "pure" environment.
2021-03-17 21:36 ` Ludovic Courtès
@ 2021-03-18 19:16 ` Leo Famulari
0 siblings, 0 replies; 4+ messages in thread
From: Leo Famulari @ 2021-03-18 19:16 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 46445-done
On Wed, Mar 17, 2021 at 10:36:16PM +0100, Ludovic Courtès wrote:
> LGTM, thanks!
Thanks for your review! Pushed as
0d8d499036f632e03f63bdaf36b02861ea52b3e6
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-18 19:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-11 20:25 [bug#46445] [PATCH] tests: Make the STORE test more robust in a "pure" environment Leo Famulari
2021-02-25 20:13 ` Leo Famulari
2021-03-17 21:36 ` Ludovic Courtès
2021-03-18 19:16 ` bug#46445: " Leo Famulari
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.