From: Efraim Flashner <efraim@flashner.co.il>
To: Carl Dong <contact@carldong.me>
Cc: 46741@debbugs.gnu.org
Subject: [bug#46741] [PATCH] gnu: Return appropriate defconfig for ppc64 (non-LE)
Date: Thu, 25 Feb 2021 12:22:34 +0200 [thread overview]
Message-ID: <YDd6ap224a+1Ey/r@3900XT> (raw)
In-Reply-To: <976A5887-0DF5-48A6-A071-D7B3A9A51186@carldong.me>
[-- Attachment #1: Type: text/plain, Size: 1890 bytes --]
I did some quick testing from the guile repl and it looks like it
doesn't take a regex. I have no preference between two entries for
'powerpc64-' and 'powerpc64le-' vs 'powerpc64'.
On Wed, Feb 24, 2021 at 03:30:00PM -0500, Carl Dong wrote:
> Hmmm does string-prefix? accept regex? And if so perhaps it should be "powerpc64(le)?-“?
>
> Carl Dong
> contact@carldong.me
> "I fight for the users"
>
> > On Feb 24, 2021, at 3:17 AM, Efraim Flashner <efraim@flashner.co.il> wrote:
> >
> > On Tue, Feb 23, 2021 at 10:03:12PM -0500, Carl Dong wrote:
> >> * gnu/packages/linux.scm (system->defconfig): Add "powerpc64-" prefix.
> >> ---
> >> gnu/packages/linux.scm | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> >> index c87c5ffb09..30cbebf849 100644
> >> --- a/gnu/packages/linux.scm
> >> +++ b/gnu/packages/linux.scm
> >> @@ -181,6 +181,7 @@
> >> defconfig. Return the appropriate make target if applicable, otherwise return
> >> \"defconfig\"."
> >> (cond ((string-prefix? "powerpc-" system) "pmac32_defconfig")
> >> + ((string-prefix? "powerpc64-" system) "ppc64_defconfig")
> >> ((string-prefix? "powerpc64le-" system) "ppc64_defconfig")
> >
> > would it make more sense to change it to "powerpc64" or "powerpc(64)?-"?
> >
> >> (else "defconfig")))
> >>
> >> --
> >> 2.30.1
> >>
> >>
> >>
> >>
> >
> > --
> > Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
> > GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
> > Confidentiality cannot be guaranteed on emails sent or received unencrypted
>
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-02-25 10:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 3:03 [bug#46741] [PATCH] gnu: Return appropriate defconfig for ppc64 (non-LE) Carl Dong
2021-02-24 8:17 ` Efraim Flashner
2021-02-24 20:30 ` Carl Dong
2021-02-25 6:09 ` Efraim Flashner
2021-02-25 10:22 ` Efraim Flashner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDd6ap224a+1Ey/r@3900XT \
--to=efraim@flashner.co.il \
--cc=46741@debbugs.gnu.org \
--cc=contact@carldong.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.