all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Carl Dong <contact@carldong.me>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 46741@debbugs.gnu.org
Subject: [bug#46741] [PATCH] gnu: Return appropriate defconfig for ppc64 (non-LE)
Date: Wed, 24 Feb 2021 15:30:00 -0500	[thread overview]
Message-ID: <976A5887-0DF5-48A6-A071-D7B3A9A51186@carldong.me> (raw)
In-Reply-To: <YDYLlo8Q4bISvwDF@3900XT>

[-- Attachment #1: Type: text/plain, Size: 1345 bytes --]

Hmmm does string-prefix? accept regex? And if so perhaps it should be "powerpc64(le)?-“?

Carl Dong
contact@carldong.me
"I fight for the users"

> On Feb 24, 2021, at 3:17 AM, Efraim Flashner <efraim@flashner.co.il> wrote:
> 
> On Tue, Feb 23, 2021 at 10:03:12PM -0500, Carl Dong wrote:
>> * gnu/packages/linux.scm (system->defconfig): Add "powerpc64-" prefix.
>> ---
>> gnu/packages/linux.scm | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
>> index c87c5ffb09..30cbebf849 100644
>> --- a/gnu/packages/linux.scm
>> +++ b/gnu/packages/linux.scm
>> @@ -181,6 +181,7 @@
>> defconfig.  Return the appropriate make target if applicable, otherwise return
>> \"defconfig\"."
>>   (cond ((string-prefix? "powerpc-" system) "pmac32_defconfig")
>> +        ((string-prefix? "powerpc64-" system) "ppc64_defconfig")
>>         ((string-prefix? "powerpc64le-" system) "ppc64_defconfig")
> 
> would it make more sense to change it to "powerpc64" or "powerpc(64)?-"?
> 
>>         (else "defconfig")))
>> 
>> --
>> 2.30.1
>> 
>> 
>> 
>> 
> 
> --
> Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
> GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
> Confidentiality cannot be guaranteed on emails sent or received unencrypted


[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-02-24 20:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-24  3:03 [bug#46741] [PATCH] gnu: Return appropriate defconfig for ppc64 (non-LE) Carl Dong
2021-02-24  8:17 ` Efraim Flashner
2021-02-24 20:30   ` Carl Dong [this message]
2021-02-25  6:09     ` Efraim Flashner
2021-02-25 10:22     ` Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=976A5887-0DF5-48A6-A071-D7B3A9A51186@carldong.me \
    --to=contact@carldong.me \
    --cc=46741@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.