From: Leo Famulari <leo@famulari.name>
To: Ekaitz Zarraga <ekaitz@elenq.tech>
Cc: "45573@debbugs.gnu.org" <45573-done@debbugs.gnu.org>
Subject: bug#45573: [PATCH] Correct freecad runtime errors
Date: Mon, 4 Jan 2021 15:12:29 -0500 [thread overview]
Message-ID: <X/N2rXWaseriuIAj@jasmine.lan> (raw)
In-Reply-To: <ck9fjdB08jA9i19MU8HKtQaBmVNpYUq-HrV2ehKL6xJ3O83BTmxdUvtZhutE4vYOoN--QGMjBi9SJF-7n0QXaOJ9IZ3yeT9ZysFgWTkmXEU=@elenq.tech>
On Mon, Jan 04, 2021 at 12:15:26PM +0000, Ekaitz Zarraga wrote:
> I think they are broken upstream.
>
> When they are run during the guix compilation they report a circular
> dependency issue when loading but once the lib is installed i'm able to
> import it without issues.
Thanks for the info. I added it to a comment. It helps reviewers (and
later readers of the package definition) to include bits of info to help
understand why the package definition does something non-standard.
> I tried that and I was unable to solve it that way.
> I'm not a CMake expert but I think the problem is that even if CMake finds
> Coin3D, it's not taking it in account during the compilation, so it needs
> that patch to use it.
Okay.
> The only part that is affected by qtwebkit is the first screen of the
> program that shows some examples, links and news. So it's safe to remove
> but I'm not sure if the substitutes were unavailable because of this or
> because the compilation was failing (it have been broken for a long time).
>
> I'm not sure about how to proceed here. I'm ok with a FreeCad that
> is open in a blank screen and shows a couple of warnings on load. I'll
> leave the decision of including this patch or not on you guys if you don't
> mind.
Now that I understand that the absence of QtWebKit breaks part of the
FreeCAD interface, I agree that it should be included.
I squashed the patches in a way that seemed appropriate, wrote the
commit messages, and pushed as ed2e0b1b50587a38ad26574585f73979874e56f0
prev parent reply other threads:[~2021-01-04 20:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-31 18:47 [bug#45573] [PATCH] Correct freecad runtime errors Ekaitz Zarraga
2020-12-31 22:36 ` Leo Famulari
2020-12-31 23:23 ` Ekaitz Zarraga
2021-01-01 14:37 ` Ekaitz Zarraga
2021-01-04 0:13 ` Leo Famulari
2021-01-04 12:01 ` Ekaitz Zarraga
2021-01-04 0:18 ` Leo Famulari
2021-01-04 12:15 ` Ekaitz Zarraga
2021-01-04 20:12 ` Leo Famulari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/N2rXWaseriuIAj@jasmine.lan \
--to=leo@famulari.name \
--cc=45573-done@debbugs.gnu.org \
--cc=ekaitz@elenq.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.