From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id WCEsN+h2819ZbwAA0tVLHw (envelope-from ) for ; Mon, 04 Jan 2021 20:13:28 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 8F/wMuh281/QPgAAB5/wlQ (envelope-from ) for ; Mon, 04 Jan 2021 20:13:28 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F246C94065D for ; Mon, 4 Jan 2021 20:13:25 +0000 (UTC) Received: from localhost ([::1]:42880 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwWEG-0007L6-Ug for larch@yhetil.org; Mon, 04 Jan 2021 15:13:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47674) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwWDu-0007KC-Sb for guix-patches@gnu.org; Mon, 04 Jan 2021 15:13:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:48822) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kwWDu-0002PX-LY for guix-patches@gnu.org; Mon, 04 Jan 2021 15:13:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kwWDu-00043w-Gg for guix-patches@gnu.org; Mon, 04 Jan 2021 15:13:02 -0500 Subject: bug#45573: [PATCH] Correct freecad runtime errors Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Mon, 04 Jan 2021 20:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 45573 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ekaitz Zarraga Mail-Followup-To: 45573@debbugs.gnu.org, leo@famulari.name, ekaitz@elenq.tech Received: via spool by 45573-done@debbugs.gnu.org id=D45573.160979115915579 (code D ref 45573); Mon, 04 Jan 2021 20:13:02 +0000 Received: (at 45573-done) by debbugs.gnu.org; 4 Jan 2021 20:12:39 +0000 Received: from localhost ([127.0.0.1]:60365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwWDX-00043C-3G for submit@debbugs.gnu.org; Mon, 04 Jan 2021 15:12:39 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:53413) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwWDV-00042z-5q for 45573-done@debbugs.gnu.org; Mon, 04 Jan 2021 15:12:37 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id DC79A5C012F; Mon, 4 Jan 2021 15:12:31 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 04 Jan 2021 15:12:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=yOBs6Q+4yMdFQ47JDQCxBsgD Q9ZW0+4TQXxNnAdoSO8=; b=w7oNDrTfvVWbMPxnBxXfa1tO6lnzFRs+R06PWuy2 V8kNMtC7+vGoILsOEGrqagbv9fiZotCLOk0DL86wPcgDi4WTFBJv5fzCroVVMBKr xXhZpfobQlXmq4oR5+vkiTe8k4T7P5lKnNSWYn9u93BN9piHyLFlxGVb3oAkW/F9 3/M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=yOBs6Q +4yMdFQ47JDQCxBsgDQ9ZW0+4TQXxNnAdoSO8=; b=PSFBsiNERHGFh6B3KC3ZQt hJhF0JTZR8LW93aFjtiYNBIBxKzzyzKX9DmP2MNceHgVSNYE5LwQpP6uTcl3sc/S 4iOLcsyj8Sv6LMRwUjMPtn1kUcT6CtpviyT2SMCOM1NcdIPgjPmZSaiAqo6w5nwg dhRu7iNpya/ynDNvuWcWDcu5LNhdcvUKH3uYtRZEr/CJi/YvQ4E7+mGe2QfWexfr 63E5u1ugKqfF1nZz21j+33RwWTTp02XevH+YVlI5bBAL9XrCD1ADRPVzLgv/TBsS enADh2H3wmB+M+fjCMkDy+4Cu/z9LhU6YuKF+T4RHvaOHlW2vOdyKukLTfK5DGnQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdeffedgudefiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth htvghrnhepueekkedtffdvtddugeejgedtvefhueefiedvjeeitdeigedtveejvdejheff vefgnecukfhppeejfedrudeguddruddvjedrudegieenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (c-73-141-127-146.hsd1.pa.comcast.net [73.141.127.146]) by mail.messagingengine.com (Postfix) with ESMTPA id 6320424005C; Mon, 4 Jan 2021 15:12:31 -0500 (EST) Date: Mon, 4 Jan 2021 15:12:29 -0500 From: Leo Famulari Message-ID: References: <6b2IbqX7a-q86Pjb_nOtz_XcCOrATSHf2T7vfIU5qrXWhYtQFsoex3XlfmDVhLt8UXjnOonMiLCS-1oKUzxXpp8x3HSUjNkzUjhUsKGc3Iw=@elenq.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "45573@debbugs.gnu.org" <45573-done@debbugs.gnu.org> Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -0.77 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=famulari.name header.s=mesmtp header.b=w7oNDrTf; dkim=fail (headers rsa verify failed) header.d=messagingengine.com header.s=fm1 header.b=PSFBsiNE; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: F246C94065D X-Spam-Score: -0.77 X-Migadu-Scanner: scn1.migadu.com X-TUID: M8kSxRU+FNd0 On Mon, Jan 04, 2021 at 12:15:26PM +0000, Ekaitz Zarraga wrote: > I think they are broken upstream. > > When they are run during the guix compilation they report a circular > dependency issue when loading but once the lib is installed i'm able to > import it without issues. Thanks for the info. I added it to a comment. It helps reviewers (and later readers of the package definition) to include bits of info to help understand why the package definition does something non-standard. > I tried that and I was unable to solve it that way. > I'm not a CMake expert but I think the problem is that even if CMake finds > Coin3D, it's not taking it in account during the compilation, so it needs > that patch to use it. Okay. > The only part that is affected by qtwebkit is the first screen of the > program that shows some examples, links and news. So it's safe to remove > but I'm not sure if the substitutes were unavailable because of this or > because the compilation was failing (it have been broken for a long time). > > I'm not sure about how to proceed here. I'm ok with a FreeCad that > is open in a blank screen and shows a couple of warnings on load. I'll > leave the decision of including this patch or not on you guys if you don't > mind. Now that I understand that the absence of QtWebKit breaks part of the FreeCAD interface, I agree that it should be included. I squashed the patches in a way that seemed appropriate, wrote the commit messages, and pushed as ed2e0b1b50587a38ad26574585f73979874e56f0