all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "\( via Guix-patches" via <guix-patches@gnu.org>
To: "jgart" <jgart@dismail.de>, <57688@debbugs.gnu.org>
Subject: [bug#57688] [PATCH v6] gnu: Add wiggle.
Date: Sat, 10 Sep 2022 08:39:07 +0100	[thread overview]
Message-ID: <CMSJTT6Z1Q9W.12S3RFR2ZGEZW@guix-aspire> (raw)
In-Reply-To: <20220910011729.17233-1-jgart@dismail.de>

Hello again!

`guix style's choices can be a wee bit dubious at times, as seen below:

On Sat Sep 10, 2022 at 2:17 AM BST, jgart via Guix-patches via wrote:
> +     (list #:make-flags #~(list "-I. -O3"
              ^^^^^^^^^^^^^^^
Put the value on the next line.
> +                                (string-append "CC="
> +                                               #$(cc-for-target))
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Put this expression all on one line.
> +                                "INSTALL=\"install\""
> +                                "STRIP=-s"
> +                                (string-append "BINDIR="
> +                                               #$output "/bin")
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Same here.
> +                                (string-append "MANDIR="
> +                                               #$output "/share/man")
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Same here.
> +                                (string-append "PREFIX="
> +                                               #$output))
                                   ^^^^^^^^^^^^^^^^^^^^^^^^
Same here.
> +           #:phases #~(modify-phases %standard-phases
              ^^^^^^^^^^^
Put the value on the next line here, too.

    -- (




  reply	other threads:[~2022-09-10  7:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-08 23:15 [bug#57688] [PATCH] gnu: Add wiggle jgart via Guix-patches via
2022-09-08 23:24 ` [bug#57688] [PATCH v2] " jgart via Guix-patches via
2022-09-08 23:51 ` [bug#57688] [PATCH] " Maxime Devos
2022-09-09  1:27 ` [bug#57688] [PATCH v3] " jgart via Guix-patches via
2022-09-09  4:14 ` [bug#57688] [PATCH v4] " jgart via Guix-patches via
2022-09-09 12:35   ` Maxime Devos
2022-09-09 14:06 ` [bug#57688] [PATCH v5] " jgart via Guix-patches via
2022-09-09 23:03   ` ( via Guix-patches via
2022-09-10  1:15     ` jgart via Guix-patches via
2022-09-10  1:17 ` [bug#57688] [PATCH v6] " jgart via Guix-patches via
2022-09-10  7:39   ` ( via Guix-patches via [this message]
2022-09-10 14:40     ` jgart via Guix-patches via
2022-09-10 15:43 ` [bug#57688] [PATCH v7] " jgart via Guix-patches via
2022-09-10 16:49   ` ( via Guix-patches via
2022-09-10 17:33     ` jgart via Guix-patches via
2022-09-10 17:39       ` ( via Guix-patches via
2022-09-11 10:46   ` bug#57688: " Liliana Marie Prikler
2022-09-11 11:23     ` [bug#57688] " jgart via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CMSJTT6Z1Q9W.12S3RFR2ZGEZW@guix-aspire \
    --to=guix-patches@gnu.org \
    --cc=57688@debbugs.gnu.org \
    --cc=jgart@dismail.de \
    --cc=paren@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.