all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "\( via Guix-patches" via <guix-patches@gnu.org>
To: "jgart" <jgart@dismail.de>, <57688@debbugs.gnu.org>
Cc: Maxime Devos <maximedevos@telenet.be>
Subject: [bug#57688] [PATCH v5] gnu: Add wiggle.
Date: Sat, 10 Sep 2022 00:03:02 +0100	[thread overview]
Message-ID: <CMS8UNYQC0MP.3RMHR78TEMZF1@guix-aspire> (raw)
In-Reply-To: <20220909140612.1910-1-jgart@dismail.de>

Hello! :D

On Fri Sep 9, 2022 at 3:06 PM BST, jgart via Guix-patches via wrote:
> +(define-public wiggle
> +    (package
     ^^
Unnecessary indentation here.

> +      (name "wiggle")
> +      (version "1.3")
> +      (source
> +       (origin
         ^^^^^^^^
Change to `(source (origin'.

> +         (method git-fetch)
> +         (uri
> +          (git-reference
            ^^^^^^^^^^^^^^^
Change to `(uri (git-reference'.

> +      (inputs
> +        (list ncurses))
         ^^^^^^^
Change to `(inputs (list ...))'.

> +      (arguments
> +        (list #:make-flags
          ^
This extra indentation isn't the norm.

> +              #~(list "-I. -O3"
> +                      (string-append "CC=" #$(cc-for-target))
> +                      "INSTALL=\"install\""
> +                      "STRIP=-s"
> +                      (string-append "BINDIR=" #$output "/bin")
> +                      (string-append "MANDIR=" #$output "/share/man")
> +                      (string-append "CC=" #$(cc-for-target))
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Duplicate `CC' definition.

> +                      (string-append "PREFIX=" #$output))
> +               #:phases
> +               #~(modify-phases %standard-phases
> +                   (delete 'configure)
> +                   (replace 'check
> +                     (lambda* (#:key inputs ouputs tests? #:allow-other-keys)
                                        ^^^^^^^^^^^^^
These two are unnecessary, and the latter has a typo anyway.

> +      (home-page "http://neil.brown.name/wiggle/")
> +      (synopsis "Tool for applying patches with conflicts")
> +      (description
> +"@code{wiggle} attempts to apply patches to a target file even if the
   ^^^^^^^^
Add indentation here.

    -- (




  reply	other threads:[~2022-09-09 23:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-08 23:15 [bug#57688] [PATCH] gnu: Add wiggle jgart via Guix-patches via
2022-09-08 23:24 ` [bug#57688] [PATCH v2] " jgart via Guix-patches via
2022-09-08 23:51 ` [bug#57688] [PATCH] " Maxime Devos
2022-09-09  1:27 ` [bug#57688] [PATCH v3] " jgart via Guix-patches via
2022-09-09  4:14 ` [bug#57688] [PATCH v4] " jgart via Guix-patches via
2022-09-09 12:35   ` Maxime Devos
2022-09-09 14:06 ` [bug#57688] [PATCH v5] " jgart via Guix-patches via
2022-09-09 23:03   ` ( via Guix-patches via [this message]
2022-09-10  1:15     ` jgart via Guix-patches via
2022-09-10  1:17 ` [bug#57688] [PATCH v6] " jgart via Guix-patches via
2022-09-10  7:39   ` ( via Guix-patches via
2022-09-10 14:40     ` jgart via Guix-patches via
2022-09-10 15:43 ` [bug#57688] [PATCH v7] " jgart via Guix-patches via
2022-09-10 16:49   ` ( via Guix-patches via
2022-09-10 17:33     ` jgart via Guix-patches via
2022-09-10 17:39       ` ( via Guix-patches via
2022-09-11 10:46   ` bug#57688: " Liliana Marie Prikler
2022-09-11 11:23     ` [bug#57688] " jgart via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CMS8UNYQC0MP.3RMHR78TEMZF1@guix-aspire \
    --to=guix-patches@gnu.org \
    --cc=57688@debbugs.gnu.org \
    --cc=jgart@dismail.de \
    --cc=maximedevos@telenet.be \
    --cc=paren@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.