From: Sharlatan Hellseher <sharlatanus@gmail.com>
To: Simon Tournier <zimon.toutoune@gmail.com>
Cc: 60793@debbugs.gnu.org
Subject: [bug#60793] [PATCH] gnu: Add julia-cfitsio-jll.
Date: Mon, 16 Jan 2023 20:36:03 +0000 [thread overview]
Message-ID: <CAO+9K5rq73BAw28ewe3hvOuuCvq8u3=spKy2ZC_YOBDU73=P5w@mail.gmail.com> (raw)
In-Reply-To: <87zgais8z5.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2165 bytes --]
Hi Simon,
Thanks for your review and comments.
Yes it's a long journey to bring Julia's Astronomical projects to Guix.
Here is my plan:
https://git.sr.ht/~hellseher/ffab/tree/main/item/org/astronomy.org#L1202
cfitsio, wcs and erfa would be essential jll bindings for base Julia
packages.
I've got a question on how to group Julia packages related just to
Astronomy. gnu/packages/astronomy.scm contains python bindings to cfitsio,
wcs and erfa would I follow the same pass and add Julia packages next to
them?
Regards,
Oleg
On Mon, 16 Jan 2023, 18:36 Simon Tournier, <zimon.toutoune@gmail.com> wrote:
> Hi,
>
> On ven., 13 janv. 2023 at 22:16, Sharlatan Hellseher <
> sharlatanus@gmail.com> wrote:
> > * gnu/packages/julia-jll.scm (julia-cfitsio-jll): New variable.
>
> Thank for this patch.
>
> Well, out of curiosity, why is this package required? I mean, usually
> JLL packages are binding to access from Julia to some libraries.
> Therefore, do you plan to use this package for another regular Julia
> package?
>
>
> > + #:use-module (guix gexp)
>
> [...]
>
> > + #~(modify-phases %standard-phases
> > + (add-after 'link-depot 'override-binary-path
> > + (lambda* (#:key inputs #:allow-other-keys)
>
> [...]
>
> > + (assoc-ref inputs "cfitsio") "\")\n"))))
>
> I do not think (guix gexp) is required here. For instance, other
> packages just use, for instance:
>
> --8<---------------cut here---------------start------------->8---
> (arguments
> '(#:tests? #f ; no runtests
> #:phases
> (modify-phases %standard-phases
> (add-after 'link-depot 'override-binary-path
> (lambda* (#:key inputs #:allow-other-keys)
> (map
> (lambda (wrapper)
> (substitute* wrapper
> (("artifact\"FFMPEG\"")
> (string-append "\"" (assoc-ref inputs "ffmpeg")
> "\""))))
> ;; There's a Julia file for each platform, override them all
> (find-files "src/wrappers/" "\\.jl$")))))))
> --8<---------------cut here---------------end--------------->8---
>
>
> Cheers,
> simon
>
[-- Attachment #2: Type: text/html, Size: 3372 bytes --]
next prev parent reply other threads:[~2023-01-16 20:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 22:16 [bug#60793] [PATCH] gnu: Add julia-cfitsio-jll Sharlatan Hellseher
2023-01-16 17:08 ` Simon Tournier
2023-01-16 20:36 ` Sharlatan Hellseher [this message]
2023-01-17 8:03 ` Simon Tournier
2023-01-29 22:26 ` Sharlatan Hellseher
2023-01-30 11:11 ` Simon Tournier
2023-01-29 22:29 ` [bug#60793] [PATCH 1/3] " Sharlatan Hellseher
2023-01-29 22:29 ` [bug#60793] [PATCH 2/3] gnu: Add julia-cfitsio Sharlatan Hellseher
2023-01-29 22:29 ` [bug#60793] [PATCH 3/3] gnu: Add julia-fitsio Sharlatan Hellseher
2023-01-30 10:59 ` [bug#60793] [PATCH 1/3] gnu: Add julia-cfitsio-jll Simon Tournier
2023-01-30 11:12 ` [bug#60793] [PATCH v2 " Simon Tournier
2023-01-30 11:12 ` [bug#60793] [PATCH v2 2/3] gnu: Add julia-cfitsio Simon Tournier
2023-01-30 11:12 ` [bug#60793] [PATCH v2 3/3] gnu: Add julia-fitsio Simon Tournier
2023-02-08 10:13 ` bug#60793: [PATCH v2 1/3] gnu: Add julia-cfitsio-jll Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAO+9K5rq73BAw28ewe3hvOuuCvq8u3=spKy2ZC_YOBDU73=P5w@mail.gmail.com' \
--to=sharlatanus@gmail.com \
--cc=60793@debbugs.gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.