From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id sDbmLYq1xWM5ugAAbAwnHQ (envelope-from ) for ; Mon, 16 Jan 2023 21:37:30 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 4GnxLYq1xWOSNQAA9RJhRA (envelope-from ) for ; Mon, 16 Jan 2023 21:37:30 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4E0B888AE for ; Mon, 16 Jan 2023 21:37:30 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHWE4-0007Y2-EJ; Mon, 16 Jan 2023 15:37:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHWE2-0007XY-Qw for guix-patches@gnu.org; Mon, 16 Jan 2023 15:37:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pHWE2-00048j-Is for guix-patches@gnu.org; Mon, 16 Jan 2023 15:37:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pHWE2-0000ja-83 for guix-patches@gnu.org; Mon, 16 Jan 2023 15:37:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60793] [PATCH] gnu: Add julia-cfitsio-jll. Resent-From: Sharlatan Hellseher Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 16 Jan 2023 20:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60793 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Simon Tournier Cc: 60793@debbugs.gnu.org Received: via spool by 60793-submit@debbugs.gnu.org id=B60793.16739013822758 (code B ref 60793); Mon, 16 Jan 2023 20:37:02 +0000 Received: (at 60793) by debbugs.gnu.org; 16 Jan 2023 20:36:22 +0000 Received: from localhost ([127.0.0.1]:34934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHWDO-0000iQ-3B for submit@debbugs.gnu.org; Mon, 16 Jan 2023 15:36:22 -0500 Received: from mail-qk1-f172.google.com ([209.85.222.172]:41492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHWDL-0000iB-L6 for 60793@debbugs.gnu.org; Mon, 16 Jan 2023 15:36:20 -0500 Received: by mail-qk1-f172.google.com with SMTP id w21so1743942qkf.8 for <60793@debbugs.gnu.org>; Mon, 16 Jan 2023 12:36:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=JGk6NYCqvLSBcqM+ZTpfMxdPLoF5ykTRh9sC4XjDsCo=; b=PtDsl3LbyamiMc6GVl/CZAVWoseAhWx8I7oRvR1ZN9bcKg48QDozrWvDh0YCL1I7bt JrAOjRb5EKYjsfqZpqcCeELyhGs2w6YnTVWPf2R0M9cbTer2+WQhcXX86rHT/SZBHp5B zaQePId35OhnMwu1xhzwUfjlzu+8sRNlZgytLzErAuN8kIp0M7gyPz0zLMwkWd6lWy9T Er9Ykr1yHpBx908AHoQUeoRNBn4xx+JCl5f53JDd8i65rVtCVgvmC+veFVDIsQE3/D6S O23rRjUmvfurkcDPv4Ir3MBnodtBb+z3VzUGnpaIXTerrrMNP3lsQTFkVSCInbbNMCXU F5Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JGk6NYCqvLSBcqM+ZTpfMxdPLoF5ykTRh9sC4XjDsCo=; b=W6g/dDQtAhiO7KREKE5Q/ykaVi5y8Y4sQR6ncs3REXsBf96GbdynjXmsp65W5WvVaI +ISA4UzmkfnXejoMs9ScRLOiXcGC+AX/x8AOYbZ9OvuFLKBKmDuSu0UGw0mEfMFDAgfW UytecDDu+zP+oCOeZZkAL/FNwyIRfFBLhIVigtYbjKScggjr6AByq2bIgZeydBNceLwC SWxuuOzh6zeRVTq1p21iMPxarDGUt6y1ELV8VqZGbFGctcsE65yL8kssIGUZBD1e2Vjs cCwGn50OEXqy55HS1jMdJIexhdwv80BikWm2FYM6K8bIKI6yZ0nSsPE5n47sJ+EjoXFj 3nXg== X-Gm-Message-State: AFqh2kr83SJdQJuHVXbQT6CS24DdPK10GXLgxec4KtSWG3AFp4MUgS8S Yk/vH6urohnKQfDubjy27YeXFmjAgAhtYlNFE58= X-Google-Smtp-Source: AMrXdXsB0kKsyXd0vdoBP/Y5Nx8vW68+qEPPt3t31MVZV9JiHF6ws5YP4FL+P+72dsulO+TkfEgxl8NRgXugvDjtQlk= X-Received: by 2002:a37:ef0b:0:b0:705:48ec:a949 with SMTP id j11-20020a37ef0b000000b0070548eca949mr9252qkk.418.1673901374030; Mon, 16 Jan 2023 12:36:14 -0800 (PST) MIME-Version: 1.0 References: <20230113221658.8158-1-sharlatanus@gmail.com> <87zgais8z5.fsf@gmail.com> In-Reply-To: <87zgais8z5.fsf@gmail.com> From: Sharlatan Hellseher Date: Mon, 16 Jan 2023 20:36:03 +0000 Message-ID: Content-Type: multipart/alternative; boundary="000000000000c9c70105f2678833" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673901450; a=rsa-sha256; cv=none; b=b7jD7GURCsr+kNE3rMNpBUnYtXbYEyvwexcb24trCtJNnmyBLs5SClTx5lmpIMuUdzN2Pv bAu5XVU2bgieeP+1tMtOoFEri28tgVGSI996RM5O2E2ClVeYxyYdHNS10hFPkEkAsBlXef lo2Dl93G1aAl2m9HpmBJGStCQBIXwjvqbNmqHPwmHvWnOXb2ZZ9pTRAHydNhCvI4YRvGZP x/JbjsHMzOzNV28Rm4+v+ROwXUVqLgfChmLZM+0PIo+2Vn2lYwR3LgSOqnT3+erGp0rfuE BVCAl8YwTxK6fdz/LFZIT4HWA/5EUkYj45ZAyYkTuxbzxY15RCAncPo2UpPd4Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=PtDsl3Lb; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673901450; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=JGk6NYCqvLSBcqM+ZTpfMxdPLoF5ykTRh9sC4XjDsCo=; b=OQAgIj+92hZP4JL/Ep/z/MZZ9xQ66FhU+CFNIWoAzN2CZpZ/YzBl44RxsgUoLfxg/JL0dQ kpXMqeRjbMvzNGMJik05+F5j0YwZqIyWgDwZawFiZKpOd7fKKYl6T7ANqL/dzamnnudCJW l+tNpvdHR6M9sdwP9dhaFEICjhhmONGw92DTgWUuIPn0XQQd/jSK2Ip3AbXok01DeKOxfX NWuGX/Hmpo9HqJPhZ+jQ1+cqgQMPBVabmRbN95/lwSCB9eoXvo9mNVSAMqg7B6wAb/BoK0 5ThOyQWxvuyWS4dhtbLA3jJMzVN2c47pDiSXevOi7ywtZbddz+mhnXS80xJWlw== X-Migadu-Spam-Score: -0.53 X-Spam-Score: -0.53 X-Migadu-Queue-Id: 4E0B888AE X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=PtDsl3Lb; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-TUID: ma1QXnfN+uoO --000000000000c9c70105f2678833 Content-Type: text/plain; charset="UTF-8" Hi Simon, Thanks for your review and comments. Yes it's a long journey to bring Julia's Astronomical projects to Guix. Here is my plan: https://git.sr.ht/~hellseher/ffab/tree/main/item/org/astronomy.org#L1202 cfitsio, wcs and erfa would be essential jll bindings for base Julia packages. I've got a question on how to group Julia packages related just to Astronomy. gnu/packages/astronomy.scm contains python bindings to cfitsio, wcs and erfa would I follow the same pass and add Julia packages next to them? Regards, Oleg On Mon, 16 Jan 2023, 18:36 Simon Tournier, wrote: > Hi, > > On ven., 13 janv. 2023 at 22:16, Sharlatan Hellseher < > sharlatanus@gmail.com> wrote: > > * gnu/packages/julia-jll.scm (julia-cfitsio-jll): New variable. > > Thank for this patch. > > Well, out of curiosity, why is this package required? I mean, usually > JLL packages are binding to access from Julia to some libraries. > Therefore, do you plan to use this package for another regular Julia > package? > > > > + #:use-module (guix gexp) > > [...] > > > + #~(modify-phases %standard-phases > > + (add-after 'link-depot 'override-binary-path > > + (lambda* (#:key inputs #:allow-other-keys) > > [...] > > > + (assoc-ref inputs "cfitsio") "\")\n")))) > > I do not think (guix gexp) is required here. For instance, other > packages just use, for instance: > > --8<---------------cut here---------------start------------->8--- > (arguments > '(#:tests? #f ; no runtests > #:phases > (modify-phases %standard-phases > (add-after 'link-depot 'override-binary-path > (lambda* (#:key inputs #:allow-other-keys) > (map > (lambda (wrapper) > (substitute* wrapper > (("artifact\"FFMPEG\"") > (string-append "\"" (assoc-ref inputs "ffmpeg") > "\"")))) > ;; There's a Julia file for each platform, override them all > (find-files "src/wrappers/" "\\.jl$"))))))) > --8<---------------cut here---------------end--------------->8--- > > > Cheers, > simon > --000000000000c9c70105f2678833 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Simon,

Th= anks for your review and comments.

Yes it's a long journey to bring Julia's Astronomical pr= ojects to Guix.


cfitsio, wcs and erfa would be essential jll bindings for base Julia pack= ages.

I've got a que= stion on how to group Julia packages related just to Astronomy. gnu/package= s/astronomy.scm contains python bindings to cfitsio, wcs and erfa would I f= ollow the same pass and add Julia packages next to them?

Regards,
Oleg
=

= On Mon, 16 Jan 2023, 18:36 Simon Tournier, <zimon.toutoune@gmail.c= om> wrote:
Hi,

On ven., 13 janv. 2023 at 22:16, Sharlatan Hellseher <shar= latanus@gmail.com> wrote:
> * gnu/packages/julia-jll.scm (julia-cfitsio-jll): New variable.

Thank for this patch.

Well, out of curiosity, why is this package required?=C2=A0 I mean, usually=
JLL packages are binding to access from Julia to some libraries.
Therefore, do you plan to use this package for another regular Julia
package?


> +=C2=A0 #:use-module (guix gexp)

[...]

> +=C2=A0 =C2=A0 =C2=A0 #~(modify-phases %standard-phases
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (add-after 'link-depot 'ov= erride-binary-path
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (lambda* (#:key inputs #:al= low-other-keys)

[...]

> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0(assoc-ref inputs "cfitsio") "\")\n"))))
I do not think (guix gexp) is required here.=C2=A0 For instance, other
packages just use, for instance:

--8<---------------cut here---------------start------------->8---
=C2=A0 =C2=A0 (arguments
=C2=A0 =C2=A0 =C2=A0'(#:tests? #f ; no runtests
=C2=A0 =C2=A0 =C2=A0 =C2=A0#:phases
=C2=A0 =C2=A0 =C2=A0 =C2=A0(modify-phases %standard-phases
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(add-after 'link-depot 'override-= binary-path
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(lambda* (#:key inputs #:allow-oth= er-keys)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(map
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(lambda (wrapper) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(substitute* = wrapper
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0((&quo= t;artifact\"FFMPEG\"")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (stri= ng-append "\"" (assoc-ref inputs "ffmpeg") "\= ""))))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;; There's a Jul= ia file for each platform, override them all
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(find-files "sr= c/wrappers/" "\\.jl$")))))))
--8<---------------cut here---------------end--------------->8---


Cheers,
simon
--000000000000c9c70105f2678833--