From: Sharlatan Hellseher <sharlatanus@gmail.com>
To: 68617@debbugs.gnu.org
Cc: poptsov.artyom@gmail.com
Subject: [bug#68617] [PATCH] gnu: Add go-github-com-gabriel-vasile-mimetype.
Date: Sat, 3 Feb 2024 05:42:58 +0000 [thread overview]
Message-ID: <CAO+9K5qvoD4FGBK7Or8Vh_OduMvuYqAWnF8o7hkWEG=vLG5UyQ@mail.gmail.com> (raw)
In-Reply-To: <87msszev23.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1008 bytes --]
Hi,
Thank you for the patch!
> + (add-before 'check 'add-supported-mimes-md
> + (lambda* (#:key inputs #:allow-other-keys #:rest args)
> + ;; This file needs to be available for writing during the
Instead of path string you may use import-path (change inputs in
lambda to use it. Check for examples in golang.scm.
> + ;; tests otherwise they will fail.
> + (let ((file
> + "src/
github.com/gabriel-vasile/mimetype/supported_mimes.md"))
It would be something like this (invoke "touch" (string-append import-path
"supported_mimes.md"). Or check if the code
depends on HOME envar.
>+ (description
> + "A fast Golang library for media type and file extension detection,
based on
> +magic numbers .")
Trailing space in the end of the sentence. Try to add more detail,
I've checked github page there is a link to a little bit detailed doc.
Apply common steps: guix lint, guix style.
Looking forward for v2.
Thanks,
Oleg
[-- Attachment #2: Type: text/html, Size: 1852 bytes --]
next prev parent reply other threads:[~2024-02-03 5:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-20 18:09 [bug#68617] [PATCH] gnu: Add go-github-com-gabriel-vasile-mimetype Artyom V. Poptsov
2024-02-03 5:42 ` Sharlatan Hellseher [this message]
2024-02-04 6:58 ` Artyom V. Poptsov
2024-02-04 17:14 ` Artyom V. Poptsov
2024-02-05 15:51 ` bug#68617: " Sharlatan Hellseher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAO+9K5qvoD4FGBK7Or8Vh_OduMvuYqAWnF8o7hkWEG=vLG5UyQ@mail.gmail.com' \
--to=sharlatanus@gmail.com \
--cc=68617@debbugs.gnu.org \
--cc=poptsov.artyom@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.