From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id yC9bJaXSvWVG1wAAe85BDQ:P1 (envelope-from ) for ; Sat, 03 Feb 2024 06:44:05 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id yC9bJaXSvWVG1wAAe85BDQ (envelope-from ) for ; Sat, 03 Feb 2024 06:44:05 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=hCS5rb3v; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1706939045; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=qtEPh2Adf38r291rN7sinK3p1gAGcEOFdTQi1zhGHlY=; b=Fr3hVCIq9V88E9TSpVLvrpJ6mNpqApNAdKku1Q0MGewObwLpzYu+VFfo9rxQdcgLvEzDVP 0rbL0GA1WkHM0kz9IbIdvc/zmawA9Yt1VnakCkejfOrVYCOSk46ixQ8OiSCvYn6WSo3oRK 7dn2wZG0SdzsozqkW27U2k9c34ereWZNXgLytTuXRpZ+8W3pGUVCYh3hv8CzHBi+Al8/x2 hpakhQfuyBXl8UIXZCM5h5GJU4jjQ2dzB17KOFClAy7kPd3026MFH89Uk7fse0Z+5w9DX1 oQnl51AY8dDR6mnrgNbQB2kFKY2KkUxtDuOlAjlyNXiRRar5rU5ObbE9slufrQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=hCS5rb3v; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1706939045; a=rsa-sha256; cv=none; b=Y1jFwECXjdXfpwIQYH4uiIclydAbiDpVY5IzXBoXeRbM8CmvTlAU0PEeJQg4dPeAqdu1ut mN2ovvABFvMM6yXSxSriCKUu1DJjqv4tqwU9qprHeGjF4TY9mk3HEoVmvYeOjLhG00V2al Ja/2wEZcAkz5YM9AyMwO1WDjLFSuckbYlc0rFnyvoRBTbJ4KqCyJf+2agGDTDhSMyjBgjj GXAvt4Cfz5IzWRhJFqFcoFsv6N9E04NlaW8YdiuKivN0LIvlp0AOV/XiUCuxC6mvPgYaQB WurWAsf5I/dikwE3okR/g+b0RU4yoQPrvzkReENXeiwibZaeOyGgs/GbTwaclA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3A42540447 for ; Sat, 3 Feb 2024 06:44:05 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rW8oj-0001xj-J3; Sat, 03 Feb 2024 00:43:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rW8oh-0001xN-Rv for guix-patches@gnu.org; Sat, 03 Feb 2024 00:43:51 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rW8oh-0006Dz-K9 for guix-patches@gnu.org; Sat, 03 Feb 2024 00:43:51 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rW8os-0001Y9-99 for guix-patches@gnu.org; Sat, 03 Feb 2024 00:44:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68617] [PATCH] gnu: Add go-github-com-gabriel-vasile-mimetype. References: <87msszev23.fsf@gmail.com> In-Reply-To: <87msszev23.fsf@gmail.com> Resent-From: Sharlatan Hellseher Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 03 Feb 2024 05:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68617 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 68617@debbugs.gnu.org Cc: poptsov.artyom@gmail.com Received: via spool by 68617-submit@debbugs.gnu.org id=B68617.17069390105912 (code B ref 68617); Sat, 03 Feb 2024 05:44:02 +0000 Received: (at 68617) by debbugs.gnu.org; 3 Feb 2024 05:43:30 +0000 Received: from localhost ([127.0.0.1]:45780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rW8oM-0001XI-CS for submit@debbugs.gnu.org; Sat, 03 Feb 2024 00:43:30 -0500 Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]:44087) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rW8oJ-0001X3-Kw for 68617@debbugs.gnu.org; Sat, 03 Feb 2024 00:43:28 -0500 Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-511396ec8c7so1969105e87.0 for <68617@debbugs.gnu.org>; Fri, 02 Feb 2024 21:43:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706938990; x=1707543790; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=qtEPh2Adf38r291rN7sinK3p1gAGcEOFdTQi1zhGHlY=; b=hCS5rb3vS37L6BimDOlBV+eELfCjiQlWDyFaIz+u/0hDodiaH5LTal6pKe7PuFOggK hx/OTGjsZrjLIL68wB8aqr/CBEtWGIA0n7QBpLPeNUmxebHoj8ZFcAv3KTKzXtwYGc0k vIYZ7LYRrh5rDG22uiYIrnwEI2r9hdJLbOUVKKFa2YS94F22KRDrN1egTpIZWv41MLXp aYjI9HAe29FfjJQH0E47YC4smEYsvA2acot0SrDftMBfPXYlngX3RszelG43U3M1HncA v7ElGdHJOmgnEm++Djjo7I8IkTyYk0JpHWvzaUspmbuA8RCW00/6Kahup6AILzT+Ffaf y9UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706938990; x=1707543790; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=qtEPh2Adf38r291rN7sinK3p1gAGcEOFdTQi1zhGHlY=; b=O0KGQtqJWI51wT0bYU8nR4FLMksxNkJ4kM1Hu2nRNVO3HyXMf19oN0IVxXD4Av+xUj 3shMhRSV1jOIZ5oLBSKt5HypQZU22FHFMaMy/bfEbOvcRsAqelCTLL0DQ2Vv9d1yN6c7 iQPhpCcKXQeluml7KQkm+00rfxsqGwAhtuC99bIKZtl44/0DMQ0vhMkblEQYlzstu0zH oxphOXln8yQ5XUvBV0k1nQ34z2dbYdT4EM3WfnVY0QC8okRFAC3LV1cohx2I1MntXmZq OMIJ12kGVlTpYHaHN6/mwsiVfcgvj0UbbEXWiaR5FZFwFqhhjCDBouSwRtDBn7Vsv+hg QAuQ== X-Gm-Message-State: AOJu0Yx1J6kF/FBf7gYmUZz8xo//nq5WS+pSsDKzTonl+ZsyDCbb5TNH NK1KaQ+qcO/6xNhETgWOVSYYgM2rYjT2Yqfyy6lxTUcJ9Nt/nEGULP0cMs2Rl0Djdu3qbi7bPJY 0zENMQtgIaz6PUKN2lLd2ur/+JBMxm2tu X-Google-Smtp-Source: AGHT+IG47CqLTRcwrrrtEZlxhS3ROMyfQ0o1bUTTC+BUpXEHzYFVqyt9qmljn6Yx4RulweMnUF83PD/cP33LJ2Z5JAQ= X-Received: by 2002:a19:8c4a:0:b0:511:382e:361c with SMTP id i10-20020a198c4a000000b00511382e361cmr2064778lfj.37.1706938989633; Fri, 02 Feb 2024 21:43:09 -0800 (PST) MIME-Version: 1.0 From: Sharlatan Hellseher Date: Sat, 3 Feb 2024 05:42:58 +0000 Message-ID: Content-Type: multipart/alternative; boundary="000000000000216432061073b459" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 2.34 X-Migadu-Queue-Id: 3A42540447 X-Spam-Score: 2.34 X-Migadu-Scanner: mx11.migadu.com X-TUID: rcbw1fqVnyAD --000000000000216432061073b459 Content-Type: text/plain; charset="UTF-8" Hi, Thank you for the patch! > + (add-before 'check 'add-supported-mimes-md > + (lambda* (#:key inputs #:allow-other-keys #:rest args) > + ;; This file needs to be available for writing during the Instead of path string you may use import-path (change inputs in lambda to use it. Check for examples in golang.scm. > + ;; tests otherwise they will fail. > + (let ((file > + "src/ github.com/gabriel-vasile/mimetype/supported_mimes.md")) It would be something like this (invoke "touch" (string-append import-path "supported_mimes.md"). Or check if the code depends on HOME envar. >+ (description > + "A fast Golang library for media type and file extension detection, based on > +magic numbers .") Trailing space in the end of the sentence. Try to add more detail, I've checked github page there is a link to a little bit detailed doc. Apply common steps: guix lint, guix style. Looking forward for v2. Thanks, Oleg --000000000000216432061073b459 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

Thank you for the patch!

<= div dir=3D"auto">> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (add-before '= check 'add-supported-mimes-md
> +=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (lambda* (#:key inputs #:allow-other-keys #= :rest args)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 ;; This file needs to be available for writing during the
Instead of path string you may use import-path (change= inputs in
lambda to use it. Check for examples in g= olang.scm.

> +=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; tests otherwise they will fail= .
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 (let ((file
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"src/github.com/gabriel= -vasile/mimetype/supported_mimes.md"))
It w= ould be something like this (invoke "touch" (string-append import= -path "supported_mimes.md"). Or check if the code
=C2=A0depends on HOME envar.=C2=A0

>+=C2=A0 =C2=A0 (description
> +=C2=A0 =C2=A0 =C2=A0"A fast Golang library for media type and f= ile extension detection, based on
> +magic number= s .")
Trailing space in the end of the sentence= . Try to add more detail,
I've checked github pa= ge there is a link to a little bit detailed doc.
Apply common steps: guix lint, guix style.

Looking forward for v2.

Thanks,
= Oleg
--000000000000216432061073b459--