From: Sharlatan Hellseher <sharlatanus@gmail.com>
To: 51765@debbugs.gnu.org
Cc: Vinicius Monego <monego@posteo.net>
Subject: [bug#51765]
Date: Tue, 4 Jan 2022 21:39:21 +0000 [thread overview]
Message-ID: <CAO+9K5p1RGRZb=m5xpDBg7A1_R43T=wkavxbb_h=7DMKdM+CiA@mail.gmail.com> (raw)
In-Reply-To: <b97bedbd76523e9917b4dc82099289d19090b0b4.camel@posteo.net>
Hi!
Thank you for fead back @Vinicius Monego !
I've added aditional changes to all mentioned patches but I've not
created patch list from scratch. Let me know if would be easy to merge
patches first.
Sharlatan Hellseher (5):
gnu: asdf-transform-schemas: Enable tests
gnu: asdf-coordinates-schemas: Enable tests
gnu: asdf-astropy: Enable tests
gnu: asdf-wcs-schemas: Enable tests
gnu: gwcs: Refactor package
gnu/packages/astronomy.scm | 101 +++++++++++++++++++++----------------
1 file changed, 57 insertions(+), 44 deletions(-)
base-commit: 4c812db049d5c9f2c438748e180f9486ad221b0a
prerequisite-patch-id: 56820d9ea09a7a53f0c576466db455e706707db2
prerequisite-patch-id: ad03d8286b6789e5c16216f66766ffa403ba2e87
prerequisite-patch-id: 7ada40e42ec009357b74914aa3ed3e31bc0924aa
prerequisite-patch-id: 18f6a0a2503f7359d051f10cfe01e421a3c20511
prerequisite-patch-id: dabf500576aec3742492c67f9a80fabf56872502
prerequisite-patch-id: ee0536ce1c726c3c7cea82067b7bc983d785139c
On Tue, 4 Jan 2022 at 02:41, Vinicius Monego <monego@posteo.net> wrote:
>
> Hi Sharlatan,
>
> I am commenting on the second patch and will comment on the others in
> this same message.
>
> > + (arguments
> > + (list
> > + ;; FIXME: (Sharlatan-20211229T160902+0000): tests run via tox
> > + #:tests? #f))
>
> The procedure is more or less the same for all Astropy related
> packages. They use tox as an abstraction for pytest. You can run tests
> by overriding the check phase:
>
> > (arguments
> > `(#:phases
> > (modify-phases %standard-phases
> > (replace 'check
> > (lambda* (#:key inputs outputs tests? #:allow-other-keys)
> > (when tests?
> > (add-installed-pythonpath inputs outputs)
> > (invoke "python" "-m" "pytest")))))))
>
> I also had to add a few more native inputs:
>
> > (native-inputs
> > (list python-jsonschema
> > python-numpy
> > python-pytest
> > python-pyyaml
> > python-semantic-version
> > python-setuptools-scm))
>
> It should work all the same for the remaining packages in the series.
>
> There's no need to add a comment about the copyright holder:
>
> > + ;; Copyright (C) 2021 Association of Universities for Research
> > in Astronomy (AURA)
> > + ;;
> > https://github.com/asdf-format/asdf-transform-schemas/blob/master/LICENSE
>
> Some of the other patches like 3 and 4 do not follow description
> standards like missing full sentences and full stop. You can run `guix
> lint` in the packages to catch some linting errors.
>
> In patch 6, gexp is being used without ungexp. In that case it
> shouldn't be used. `(arguments (list ...))` should be `(arguments `())`
> when gexp isn't being used, same for the other patches too. gwcs
> license is bsd-3 according to copyright headers and the LICENSE file in
> the license/ directory. Inputs in patches 5 and 6 may also have to be
> propagated if they are libraries.
>
--
… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.
next prev parent reply other threads:[~2022-01-04 21:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 13:17 [bug#51765] [PATCH]: gnu: Add python-gwcs Sharlatan Hellseher
2021-12-26 19:01 ` [bug#51765] Sharlatan Hellseher
2021-12-26 19:55 ` [bug#51765] [PATCH]: gnu: Add python-gwcs Mathieu Othacehe
2021-12-26 20:47 ` Sharlatan Hellseher
2021-12-26 20:55 ` Mathieu Othacehe
2022-01-02 22:48 ` Sharlatan Hellseher
2022-01-02 22:48 ` [bug#51765] Sharlatan Hellseher
2022-01-02 22:48 ` [bug#51765] Sharlatan Hellseher
2022-01-04 2:41 ` [bug#51765] Vinicius Monego
2022-01-04 21:39 ` Sharlatan Hellseher [this message]
2022-01-04 23:01 ` [bug#51765] Vinicius Monego
2022-01-14 23:40 ` [bug#51765] Sharlatan Hellseher
2022-01-02 22:48 ` [bug#51765] Sharlatan Hellseher
2022-01-02 22:49 ` [bug#51765] Sharlatan Hellseher
2022-01-02 22:49 ` [bug#51765] Sharlatan Hellseher
2022-01-02 22:49 ` [bug#51765] Sharlatan Hellseher
2022-01-04 21:39 ` [bug#51765] Sharlatan Hellseher
2022-01-04 21:40 ` [bug#51765] Sharlatan Hellseher
2022-01-04 21:40 ` [bug#51765] Sharlatan Hellseher
2022-01-04 21:40 ` [bug#51765] Sharlatan Hellseher
2022-01-04 21:40 ` [bug#51765] Sharlatan Hellseher
2022-01-14 23:40 ` [bug#51765] [PATCH 1/6] gnu: python-asdf: Update to 2.8.3 Sharlatan Hellseher
2022-01-14 23:40 ` [bug#51765] [PATCH 2/6] gnu: Add asdf-transform-schemas Sharlatan Hellseher
2022-01-14 23:40 ` [bug#51765] [PATCH 3/6] gnu: Add asdf-coordinates-schemas Sharlatan Hellseher
2022-01-14 23:40 ` [bug#51765] [PATCH 4/6] gnu: Add asdf-astropy Sharlatan Hellseher
2022-01-14 23:40 ` [bug#51765] [PATCH 5/6] gnu: Add asdf-wcs-schemas Sharlatan Hellseher
2022-01-14 23:40 ` [bug#51765] [PATCH 6/6] gnu: Add gwcs Sharlatan Hellseher
2022-01-30 15:07 ` bug#51765: [PATCH 1/6] gnu: python-asdf: Update to 2.8.3 Vinicius Monego
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAO+9K5p1RGRZb=m5xpDBg7A1_R43T=wkavxbb_h=7DMKdM+CiA@mail.gmail.com' \
--to=sharlatanus@gmail.com \
--cc=51765@debbugs.gnu.org \
--cc=monego@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.