all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Vinicius Monego <monego@posteo.net>
To: Sharlatan Hellseher <sharlatanus@gmail.com>, 51765@debbugs.gnu.org
Subject: [bug#51765]
Date: Tue, 04 Jan 2022 02:41:29 +0000	[thread overview]
Message-ID: <b97bedbd76523e9917b4dc82099289d19090b0b4.camel@posteo.net> (raw)
In-Reply-To: <CAO+9K5pAJOaLoJ_c0eF3hRUO+BcLM1=AXTBq_QzAAX6zwcxN0Q@mail.gmail.com>

Hi Sharlatan,

I am commenting on the second patch and will comment on the others in
this same message.

> +    (arguments
> +     (list
> +      ;; FIXME: (Sharlatan-20211229T160902+0000): tests run via tox
> +      #:tests? #f))

The procedure is more or less the same for all Astropy related
packages. They use tox as an abstraction for pytest. You can run tests
by overriding the check phase:

>     (arguments
>      `(#:phases
>        (modify-phases %standard-phases
>          (replace 'check
>            (lambda* (#:key inputs outputs tests? #:allow-other-keys)
>              (when tests?
>                (add-installed-pythonpath inputs outputs)
>                (invoke "python" "-m" "pytest")))))))

I also had to add a few more native inputs:

>     (native-inputs
>      (list python-jsonschema
>            python-numpy
>            python-pytest
>            python-pyyaml
>            python-semantic-version
>            python-setuptools-scm))

It should work all the same for the remaining packages in the series.

There's no need to add a comment about the copyright holder:

> +    ;; Copyright (C) 2021 Association of Universities for Research
> in Astronomy (AURA)
> +    ;;  
> https://github.com/asdf-format/asdf-transform-schemas/blob/master/LICENSE

Some of the other patches like 3 and 4 do not follow description
standards like missing full sentences and full stop. You can run `guix
lint` in the packages to catch some linting errors.

In patch 6, gexp is being used without ungexp. In that case it
shouldn't be used. `(arguments (list ...))` should be `(arguments `())`
when gexp isn't being used, same for the other patches too. gwcs
license is bsd-3 according to copyright headers and the LICENSE file in
the license/ directory. Inputs in patches 5 and 6 may also have to be
propagated if they are libraries.





  reply	other threads:[~2022-01-04  2:42 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-11 13:17 [bug#51765] [PATCH]: gnu: Add python-gwcs Sharlatan Hellseher
2021-12-26 19:01 ` [bug#51765] Sharlatan Hellseher
2021-12-26 19:55 ` [bug#51765] [PATCH]: gnu: Add python-gwcs Mathieu Othacehe
2021-12-26 20:47   ` Sharlatan Hellseher
2021-12-26 20:55     ` Mathieu Othacehe
2022-01-02 22:48       ` Sharlatan Hellseher
2022-01-02 22:48 ` [bug#51765] Sharlatan Hellseher
2022-01-02 22:48 ` [bug#51765] Sharlatan Hellseher
2022-01-04  2:41   ` Vinicius Monego [this message]
2022-01-04 21:39     ` [bug#51765] Sharlatan Hellseher
2022-01-04 23:01       ` [bug#51765] Vinicius Monego
2022-01-14 23:40         ` [bug#51765] Sharlatan Hellseher
2022-01-02 22:48 ` [bug#51765] Sharlatan Hellseher
2022-01-02 22:49 ` [bug#51765] Sharlatan Hellseher
2022-01-02 22:49 ` [bug#51765] Sharlatan Hellseher
2022-01-02 22:49 ` [bug#51765] Sharlatan Hellseher
2022-01-04 21:39 ` [bug#51765] Sharlatan Hellseher
2022-01-04 21:40 ` [bug#51765] Sharlatan Hellseher
2022-01-04 21:40 ` [bug#51765] Sharlatan Hellseher
2022-01-04 21:40 ` [bug#51765] Sharlatan Hellseher
2022-01-04 21:40 ` [bug#51765] Sharlatan Hellseher
2022-01-14 23:40 ` [bug#51765] [PATCH 1/6] gnu: python-asdf: Update to 2.8.3 Sharlatan Hellseher
2022-01-14 23:40   ` [bug#51765] [PATCH 2/6] gnu: Add asdf-transform-schemas Sharlatan Hellseher
2022-01-14 23:40   ` [bug#51765] [PATCH 3/6] gnu: Add asdf-coordinates-schemas Sharlatan Hellseher
2022-01-14 23:40   ` [bug#51765] [PATCH 4/6] gnu: Add asdf-astropy Sharlatan Hellseher
2022-01-14 23:40   ` [bug#51765] [PATCH 5/6] gnu: Add asdf-wcs-schemas Sharlatan Hellseher
2022-01-14 23:40   ` [bug#51765] [PATCH 6/6] gnu: Add gwcs Sharlatan Hellseher
2022-01-30 15:07   ` bug#51765: [PATCH 1/6] gnu: python-asdf: Update to 2.8.3 Vinicius Monego

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b97bedbd76523e9917b4dc82099289d19090b0b4.camel@posteo.net \
    --to=monego@posteo.net \
    --cc=51765@debbugs.gnu.org \
    --cc=sharlatanus@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.