all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 43946@debbugs.gnu.org
Subject: [bug#43946] [PATCH] doc: Add item to "Submitting Patches" section.
Date: Fri, 15 Jan 2021 15:00:20 +0100	[thread overview]
Message-ID: <CAJ3okZ316hbOsXJ3R8UCpEs--yqdVaw8pm3qp0p138JTDox6-w@mail.gmail.com> (raw)
In-Reply-To: <87zh1axr7c.fsf@gnu.org>

Hi Ludo,

On Fri, 15 Jan 2021 at 14:30, Ludovic Courtès <ludo@gnu.org> wrote:

> > +We recommend to use the command @code{git format-patch --base} to
> > +include the commit where your patch applies.
>
> I’m not entirely convinced TBH, in part because I know I often pile a
> couple of WIP branches on top of one another, “knowing what I’m doing”
> (actually hoping that I do), and so the base commit would be useless in
> this case.

I am not buying your argument. :-)
It is not because <name> does not use this information that it cannot
be a recommendation, i.e., a suggestion or advice on what seems
helpful.
Other said, it is not because it is "useless in this case" that it is
useless in other cases.

For example, this information about which known commit that patch
applies is helping for the automation of testing patches.  Well, see
[1,2] for instance.  Discussions of such tooling happened in #44625
[3] and Emacs helper [4].


1: <https://git.kernel.org/pub/scm/utils/b4/b4.git/tree/README.rst>
2: <https://docs.kyleam.com/piem/Using-b4-to-apply-patches.html>
3: <http://issues.guix.gnu.org/44625>
4: <https://inbox.kyleam.com/piem/20201115061518.22191-1-kyle@kyleam.com/>

> Closing?  :-)

As you want. :-)
But, I think "qui peut le plus peut le moins".  Even if maybe my
wording is not the good one, I still think that the "base-commit"
where the patch applies should be provided, at least suggested.

Cheers,
simon




  reply	other threads:[~2021-01-15 14:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-12  8:20 [bug#43946] [PATCH] doc: Add item to "Submitting Patches" section zimoun
2020-10-24  9:01 ` bug#43946: " Oleg Pykhalov
2020-10-24  9:17   ` [bug#43946] " zimoun
2021-01-15 13:30 ` Ludovic Courtès
2021-01-15 14:00   ` zimoun [this message]
2021-03-26  5:40     ` zimoun
2021-09-21  9:53   ` zimoun
2021-09-22 13:02     ` bug#43946: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJ3okZ316hbOsXJ3R8UCpEs--yqdVaw8pm3qp0p138JTDox6-w@mail.gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=43946@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.