From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id UHN8M6WlAWARPAAA0tVLHw (envelope-from ) for ; Fri, 15 Jan 2021 14:24:37 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 6JlEL6WlAWDuQQAAB5/wlQ (envelope-from ) for ; Fri, 15 Jan 2021 14:24:37 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5279C9403AA for ; Fri, 15 Jan 2021 14:24:37 +0000 (UTC) Received: from localhost ([::1]:41788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0Q1k-0003PC-5X for larch@yhetil.org; Fri, 15 Jan 2021 09:24:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47730) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0Pey-0001OF-Ah for guix-patches@gnu.org; Fri, 15 Jan 2021 09:01:08 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:56832) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l0Pev-0002mk-PZ for guix-patches@gnu.org; Fri, 15 Jan 2021 09:01:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l0Pev-0002Bs-Mr for guix-patches@gnu.org; Fri, 15 Jan 2021 09:01:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#43946] [PATCH] doc: Add item to "Submitting Patches" section. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 15 Jan 2021 14:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43946 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 43946-submit@debbugs.gnu.org id=B43946.16107192418383 (code B ref 43946); Fri, 15 Jan 2021 14:01:01 +0000 Received: (at 43946) by debbugs.gnu.org; 15 Jan 2021 14:00:41 +0000 Received: from localhost ([127.0.0.1]:40145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0Pea-0002B9-KX for submit@debbugs.gnu.org; Fri, 15 Jan 2021 09:00:40 -0500 Received: from mail-qv1-f47.google.com ([209.85.219.47]:32771) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0PeY-0002Av-2p for 43946@debbugs.gnu.org; Fri, 15 Jan 2021 09:00:39 -0500 Received: by mail-qv1-f47.google.com with SMTP id a13so3966164qvv.0 for <43946@debbugs.gnu.org>; Fri, 15 Jan 2021 06:00:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Oc4OhbpU65PcXL9WwaqfoX63BCLIggAiU1/UaJdzrnE=; b=YxdHmwLSkZVQRF9JiVVPaHsGkTc6APhEYx2DndXmZn+gHal6R6jbM5jydawjBYAU+Z p14oX5BwCCJ5okwjgjUuCv+hRp+xBMlWN/lj11jpejluahVw04Xbry61oOgP1OjCH9Kj iDRAmvT+K3P6NjEihCRXCkAj+a0GOeZvZL2529GDSTmz3o1rJtNyNhxsdYLbauHUsTRr m6cu/LKp5jaNUSbqKa7iFjdiVAbxEoxzsGSQdaBDgfDVLdKdI0s2x26YPl8ICpWZ/m9/ jH3l0qArFKQdtrUv5Lk7jBRQjWy+hytQhkMQ8t7u72zdLilRdLyQv423YBtobhsi6p+o djFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Oc4OhbpU65PcXL9WwaqfoX63BCLIggAiU1/UaJdzrnE=; b=nFShRMk+Jo3SjGSrAsLBELNdkNKy+LPq9mCupsoAc7H4sCPLFBGqZscWmk0ap+gpoT geLPCUlf1nt4I33KR1w1mAUXoUveHgZGnYsY6pQHGxJ4J+xZt1EnWHOThX9XxQIplL/E FPwk1YqvkIrbnG4zgY8fmw8uK99XqDHljCScqCn+pMHz37Zu384dPOBtzn1RFy5C5/6I FOcKQ81HJIOhEBg/2tRLP0pbzHFHncPXvSBhvPWv97JhvatnU4FtzzNY3tVsRAVyJWb3 5jHuO41IhSfn92A+vXAOV/NMWZC5REKl39pl72JAJcQAAkYDPrCXI8Ms3abCrUEf1q+i pJbw== X-Gm-Message-State: AOAM531tCP9fHol7ni4frPQr3+XgacKYtjiyyx2TI+kzloPm8t3IoQAc eImN/gwpJtbGkUQ45uQrIGEw5c9U+1n/hviYYso= X-Google-Smtp-Source: ABdhPJwa0mHPABmXrPUX2l1+VAW/0/O20inzKMnzH8BbFE3RIr2Ojp9jl4EYXfuWuKiQ7yoD9Vvnv2ARP1yCP1VjNW8= X-Received: by 2002:a0c:df94:: with SMTP id w20mr11939825qvl.33.1610719232387; Fri, 15 Jan 2021 06:00:32 -0800 (PST) MIME-Version: 1.0 References: <20201012082003.19936-1-zimon.toutoune@gmail.com> <87zh1axr7c.fsf@gnu.org> In-Reply-To: <87zh1axr7c.fsf@gnu.org> From: zimoun Date: Fri, 15 Jan 2021 15:00:20 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 43946@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.26 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=YxdHmwLS; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 5279C9403AA X-Spam-Score: -1.26 X-Migadu-Scanner: scn1.migadu.com X-TUID: U0i8x7ML/6MO Hi Ludo, On Fri, 15 Jan 2021 at 14:30, Ludovic Court=C3=A8s wrote: > > +We recommend to use the command @code{git format-patch --base} to > > +include the commit where your patch applies. > > I=E2=80=99m not entirely convinced TBH, in part because I know I often pi= le a > couple of WIP branches on top of one another, =E2=80=9Cknowing what I=E2= =80=99m doing=E2=80=9D > (actually hoping that I do), and so the base commit would be useless in > this case. I am not buying your argument. :-) It is not because does not use this information that it cannot be a recommendation, i.e., a suggestion or advice on what seems helpful. Other said, it is not because it is "useless in this case" that it is useless in other cases. For example, this information about which known commit that patch applies is helping for the automation of testing patches. Well, see [1,2] for instance. Discussions of such tooling happened in #44625 [3] and Emacs helper [4]. 1: 2: 3: 4: > Closing? :-) As you want. :-) But, I think "qui peut le plus peut le moins". Even if maybe my wording is not the good one, I still think that the "base-commit" where the patch applies should be provided, at least suggested. Cheers, simon