bug#52347: Shell: error when -m manifest is removed

bug#52347: Shell: error when -m manifest is removed

[Cayetano Santos via Bug reports for GNU Guix]

Hi guix,

  Using latest guix, and considering a local manifest.scm file 
  with only

    (specifications->manifest (list "python"))

  Following command works

    guix shell --container -m manifest.scm -- python3

  But

    guix shell --container -- python3

gives an error. However,

    guix shell --container

followed by

    python3

works.

  So, by just removing the ’-m manifest.scm’ flag, I get an error.

Regards,

Cayetano Santos

bug#52347: Shell: error when -m manifest is removed

[zimoun]

Hi,

On Tue, 7 Dec 2021 at 09:41, Cayetano Santos via Bug reports for GNU
Guix <bug-guix@gnu.org> wrote:

>     guix shell --container
>
> followed by
>
>     python3
>
> works.

It works correctly for me.  With Guix f43a783:

--8<---------------cut here---------------start------------->8---
$ guix shell -C -m manifest.scm -- python3 -c 'import this'
$ guix shell -C -m manifest.scm
[env]$ python3 -c 'import this'

$ guix shell -C
guix shell: warning: no packages specified; creating an empty environment
guix shell: warning: no packages specified; creating an empty environment
[env]$ python3
sh: python3: command not found
[env]$ $GUIX_ENVIRONMENT/bin/python3
sh: /gnu/store/h3al0y1pbr64gcjhmn4wn3v863vhc72a-profile/bin/python3:
No such file or directory
[env]$ $GUIX_ENVIRONMENT/bin
sh: /gnu/store/h3al0y1pbr64gcjhmn4wn3v863vhc72a-profile/bin: No such
file or directory

$ tree /gnu/store/h3al0y1pbr64gcjhmn4wn3v863vhc72a-profile
/gnu/store/h3al0y1pbr64gcjhmn4wn3v863vhc72a-profile
├── etc
│   └── profile
└── manifest

1 directory, 2 files
--8<---------------cut here---------------end--------------->8---


Cheers,
simon

bug#52347: Shell: error when -m manifest is removed

[Cayetano Santos via Bug reports for GNU Guix]

Problem is

  guix shell -C -- python3

Tried after ’guix pull’ and problem remains.

C.

>mar. 07 déc. 2021 at 10:26, zimoun <zimon.toutoune@gmail.com> ...

> Hi,
>
> On Tue, 7 Dec 2021 at 09:41, Cayetano Santos via Bug reports for 
> GNU
> Guix <bug-guix@gnu.org> wrote:
>
>>     guix shell --container
>>
>> followed by
>>
>>     python3
>>
>> works.
>
> It works correctly for me.  With Guix f43a783:
>
> --8<---------------cut 
> here---------------start------------->8---
> $ guix shell -C -m manifest.scm -- python3 -c 'import this'
> $ guix shell -C -m manifest.scm
> [env]$ python3 -c 'import this'
>
> $ guix shell -C
> guix shell: warning: no packages specified; creating an empty 
> environment
> guix shell: warning: no packages specified; creating an empty 
> environment
> [env]$ python3
> sh: python3: command not found
> [env]$ $GUIX_ENVIRONMENT/bin/python3
> sh: 
> /gnu/store/h3al0y1pbr64gcjhmn4wn3v863vhc72a-profile/bin/python3:
> No such file or directory
> [env]$ $GUIX_ENVIRONMENT/bin
> sh: /gnu/store/h3al0y1pbr64gcjhmn4wn3v863vhc72a-profile/bin: No 
> such
> file or directory
>
> $ tree /gnu/store/h3al0y1pbr64gcjhmn4wn3v863vhc72a-profile
> /gnu/store/h3al0y1pbr64gcjhmn4wn3v863vhc72a-profile
> ├── etc
> │   └── profile
> └── manifest
>
> 1 directory, 2 files
> --8<---------------cut 
> here---------------end--------------->8---
>
>
> Cheers,
> simon

bug#52347: Shell: error when -m manifest is removed

[zimoun]

Hi,

On Tue, 7 Dec 2021 at 11:10, Cayetano Santos
<cayetano.santos@inventati.org> wrote:
>
>
> Problem is
>
>   guix shell -C -- python3
>
> Tried after ’guix pull’ and problem remains.

Which revision do you use?  Because using f43a783, it fails as expected. :-)

Are you running Guix on foreign distro or Guix System?


Cheers,
simon

bug#52347: Shell: error when -m manifest is removed

[Cayetano Santos via Bug reports for GNU Guix]

>mar. 07 déc. 2021 at 11:18, zimoun <zimon.toutoune@gmail.com> ...

> Hi,
>
> On Tue, 7 Dec 2021 at 11:10, Cayetano Santos
> <cayetano.santos@inventati.org> wrote:
>>
>> Problem is
>>
>>   guix shell -C -- python3
>>
>> Tried after ’guix pull’ and problem remains.
>
> Which revision do you use?  Because using f43a783, it fails as 
> expected. :-)

I’m using guix 05deb26.

Is it expected to fail when I remove the ’-m manifest’ flag and I 
just run ’guix shell -C -- python3’ ?

> Are you running Guix on foreign distro or Guix System?

Foreign, on top of ArchLinux.

C.

bug#52347: Shell: error when -m manifest is removed

[zimoun]

Hi,

On Tue, 7 Dec 2021 at 11:25, Cayetano Santos
<cayetano.santos@inventati.org> wrote:

> Is it expected to fail when I remove the ’-m manifest’ flag and I
> just run ’guix shell -C -- python3’ ?

The command "guix shell -C -- python3" fails.  It cannot work, because
the environment (new shell) is empty.  You need to provide what this
shell has to contain, via command line package list or via manifest.


Cheers,
simon

bug#52347: Shell: error when -m manifest is removed

[Cayetano Santos via Bug reports for GNU Guix]

>mar. 07 déc. 2021 at 11:35, zimoun <zimon.toutoune@gmail.com> ...

> Hi,
>
> On Tue, 7 Dec 2021 at 11:25, Cayetano Santos
> <cayetano.santos@inventati.org> wrote:
>
>> Is it expected to fail when I remove the ’-m manifest’ flag and 
>> I
>> just run ’guix shell -C -- python3’ ?
>
> The command "guix shell -C -- python3" fails.  It cannot work, 
> because
> the environment (new shell) is empty.  You need to provide what 
> this
> shell has to contain, via command line package list or via 
> manifest.

To my understanding, in this blog entry

  https://guix.gnu.org/en/blog/2021/from-guix-environment-to-guix-shell/

they claim that "guix shell automatically loads guix.scm or 
manifest.scm, from the current directory"

No need to "-m manifest.scm", then.

C.

bug#52347: Shell: error when -m manifest is removed

[zimoun]

Hi,

On Tue, 7 Dec 2021 at 11:44, Cayetano Santos
<cayetano.santos@inventati.org> wrote:

> they claim that "guix shell automatically loads guix.scm or
> manifest.scm, from the current directory"
>
> No need to "-m manifest.scm", then.

Ah yes, sorry.  Since I personally find implicit a bad thing, I have
forgotten about it. :-)
Anyway!

Indeed, there is a bug.  It comes from 'stat:uid' vs 'getuid' in
'find-file-in-parent-directories'.  On my machine, this

    (= (stat:uid stat) (getuid))

compares 0 against 1001.


Cheers,
simon

bug#52347: Shell: error when -m manifest is removed

[Liliana Marie Prikler]

Hi,

I am experiencing a similar situation without the container.  At work,
I need some special Emacs packages, that I don't need/want in my normal
setup, so I do `guix shell -m manifest.scm -- emacs'.  Even with the
directory added to the good noodles list, `guix shell -- emacs' fails,
probably because Guix assumes it has arguments when those really are
just the command to run.  IOW the check for "when is implicit okay"
might be too narrow for this use case.

Cheers

bug#52347: Shell: error when -m manifest is removed

[zimoun]

On Tue, 7 Dec 2021 at 14:33, Liliana Marie Prikler
<liliana.prikler@ist.tugraz.at> wrote:

> I am experiencing a similar situation without the container.  At work,
> I need some special Emacs packages, that I don't need/want in my normal
> setup, so I do `guix shell -m manifest.scm -- emacs'.  Even with the
> directory added to the good noodles list, `guix shell -- emacs' fails,
> probably because Guix assumes it has arguments when those really are
> just the command to run.  IOW the check for "when is implicit okay"
> might be too narrow for this use case.

Similar root, I guess, described by https://issues.guix.gnu.org/52347#8 :-)


Cheers,
simon

bug#52347: Shell: error when -m manifest is removed

[Liliana Marie Prikler]

Am Dienstag, den 07.12.2021, 14:41 +0100 schrieb zimoun:
> On Tue, 7 Dec 2021 at 14:33, Liliana Marie Prikler
> <liliana.prikler@ist.tugraz.at> wrote:
> 
> > I am experiencing a similar situation without the container.  At
> > work,
> > I need some special Emacs packages, that I don't need/want in my
> > normal
> > setup, so I do `guix shell -m manifest.scm -- emacs'.  Even with
> > the
> > directory added to the good noodles list, `guix shell -- emacs'
> > fails,
> > probably because Guix assumes it has arguments when those really
> > are
> > just the command to run.  IOW the check for "when is implicit okay"
> > might be too narrow for this use case.
> 
> Similar root, I guess, described by 
> https://issues.guix.gnu.org/52347#8 :-)
I am pretty sure all files are owned by the same user in my case.  Can
stat:uid really return 0 then?

bug#52347: Shell: error when -m manifest is removed

[zimoun]

Hi,

On Tue, 7 Dec 2021 at 14:48, Liliana Marie Prikler
<liliana.prikler@ist.tugraz.at> wrote:

> I am pretty sure all files are owned by the same user in my case.  Can
> stat:uid really return 0 then?

Maybe I am doing wrong but I just 'pk' in find-file-in-parent-directories. :-)

Cheers,
simon

bug#52347: Shell: error when -m manifest is removed

[Liliana Marie Prikler]

Am Dienstag, den 07.12.2021, 15:27 +0100 schrieb zimoun:
> Hi,
> 
> On Tue, 7 Dec 2021 at 14:48, Liliana Marie Prikler
> <liliana.prikler@ist.tugraz.at> wrote:
> 
> > I am pretty sure all files are owned by the same user in my
> > case.  Can
> > stat:uid really return 0 then?
> 
> Maybe I am doing wrong but I just 'pk' in find-file-in-parent-
> directories. :-)
You are doing wrong:

  (if (or (not interactive?) ; true if giving -- COMMAND
          disallow-implicit-load?
          (options-contain-payload? opts))

So the pk in find-file-in-parent-directories should not even fire.  I'm
pretty sure the interactive constraint has a reasoning that was
explained back then, so we should investigate carefully whether we want
to overthrow that.  Warning, that noninteractive use of `guix shell'
requires an explicit manifest is also an option imo.

By the way, if we do search for a file, but find none, the warning
(warning (G_ "no packages specified; creating an empty environment~%"))
is displayed twice; once by auto-detect-manifest and once by guix-
environment*.  We should probably change that string to something that
indicates that we've attempted to auto-load a manifest.

Cheers

bug#52347: Shell: error when -m manifest is removed

[zimoun]

Hi,

On Tue, 7 Dec 2021 at 17:23, Liliana Marie Prikler
<liliana.prikler@gmail.com> wrote:

> > Maybe I am doing wrong but I just 'pk' in find-file-in-parent-
> > directories. :-)
> You are doing wrong:
>
>   (if (or (not interactive?) ; true if giving -- COMMAND

Yes, indeed.  I simply grepped "manifest" and looked at
'find-file-in-parent-directories', because if it is not called, the
"manifest" file cannot be loaded. :-)  Then I incorrectly used the
wrong command line invokation.  Bad day with a lot of inattentive
today. :-/


> So the pk in find-file-in-parent-directories should not even fire.  I'm
> pretty sure the interactive constraint has a reasoning that was
> explained back then, so we should investigate carefully whether we want
> to overthrow that.  Warning, that noninteractive use of `guix shell'
> requires an explicit manifest is also an option imo.

I am in favour to keep it explicit. (Personally, I already find that
"guix shell" is wrong ;-))


> By the way, if we do search for a file, but find none, the warning
> (warning (G_ "no packages specified; creating an empty environment~%"))
> is displayed twice; once by auto-detect-manifest and once by guix-
> environment*.  We should probably change that string to something that
> indicates that we've attempted to auto-load a manifest.

I agree.

Cheers,
simon

bug#52347: Shell: error when -m manifest is removed

[Maxime Devos]

Cayetano Santos via Bug reports for GNU Guix schreef op di 07-12-2021
om 09:33 [+0100]:
> 
> Hi guix,
> 
>   Using latest guix, and considering a local manifest.scm file 
>   with only
> 
>     (specifications->manifest (list "python"))
> 
>   Following command works
> 
>     guix shell --container -m manifest.scm -- python3
> 
>   But
> 
>     guix shell --container -- python3
> 
> gives an error. However,

What's the error message?

Greetings,
Maxime

bug#52347: Shell: error when -m manifest is removed

[Cayetano Santos via Bug reports for GNU Guix]

>mar. 07 déc. 2021 at 12:02, Maxime Devos <maximedevos@telenet.be> 
>...

> What's the error message?

Output to ’guix shell --container -- python3’ gives

guix shell: avertissement : aucun paquet spécifié ; création d'un 
environnement vide
guix shell: erreur : python3: command not found
Backtrace:
          16 (primitive-load "/usr/local/bin/guix")
In guix/ui.scm:
   2206:7 15 (run-guix . _)
  2169:10 14 (run-guix-command _ . _)
In ice-9/boot-9.scm:
  1752:10 13 (with-exception-handler _ _ #:unwind? _ # _)
  1752:10 12 (with-exception-handler _ _ #:unwind? _ # _)
In guix/store.scm:
   658:37 11 (thunk)
   1320:8 10 (call-with-build-handler _ _)
   1320:8  9 (call-with-build-handler #<procedure 7fbb1d6516f0 at 
   g…> …)
In guix/status.scm:
    800:4  8 (call-with-status-report _ _)
In guix/scripts/environment.scm:
   951:12  7 (_)
In guix/store.scm:
  2119:24  6 (run-with-store #<store-connection 256.99 
  7fbb2132ccd0> …)
In guix/scripts/environment.scm:
   627:17  5 (_ _)
   576:23  4 (validate-exit-status _ _ 32512)
In guix/utils.scm:
    954:4  3 (string-closest _ _ #:threshold _)
In guix/combinators.scm:
    46:32  2 (fold2 #<procedure 7fbb10e14380 at 
    guix/utils.scm:954:…> …)
In ice-9/boot-9.scm:
  1685:16  1 (raise-exception _ #:continuable? _)
  1685:16  0 (raise-exception _ #:continuable? _)

ice-9/boot-9.scm:1685:16: In procedure raise-exception:
In procedure car: Wrong type argument in position 1 (expecting 
pair): #f

bug#52347: Shell: error when -m manifest is removed

[Maxime Devos]

Cayetano Santos schreef op di 07-12-2021 om 19:11 [+0100]:
> In guix/scripts/environment.scm:
>    627:17  5 (_ _)
>    576:23  4 (validate-exit-status _ _ 32512)
> In guix/utils.scm:
>     954:4  3 (string-closest _ _ #:threshold _)
> In guix/combinators.scm:
>     46:32  2 (fold2 #<procedure 7fbb10e14380 at 
>     guix/utils.scm:954:…> …)
> In ice-9/boot-9.scm:
>   1685:16  1 (raise-exception _ #:continuable? _)
>   1685:16  0 (raise-exception _ #:continuable? _)
> 
> ice-9/boot-9.scm:1685:16: In procedure raise-exception:
> In procedure car: Wrong type argument in position 1 (expecting 
> pair): #f

Seems like suggest-command-name is passing #f to string-closest instead
of a list (a bug!).

bug#52347: Shell: error when -m manifest is removed

[Ludovic Courtès]

Hi,

Cayetano Santos <cayetano.santos@inventati.org> skribis:

> In guix/scripts/environment.scm:
>   627:17  5 (_ _)
>   576:23  4 (validate-exit-status _ _ 32512)
> In guix/utils.scm:
>    954:4  3 (string-closest _ _ #:threshold _)
> In guix/combinators.scm:
>    46:32  2 (fold2 #<procedure 7fbb10e14380 at
>    guix/utils.scm:954:…> …)
> In ice-9/boot-9.scm:
>  1685:16  1 (raise-exception _ #:continuable? _)
>  1685:16  0 (raise-exception _ #:continuable? _)
>
> ice-9/boot-9.scm:1685:16: In procedure raise-exception:
> In procedure car: Wrong type argument in position 1 (expecting pair):
> #f

This particular issue was fixed in
16e9e538386bf30da690502c65b8053ff266e8cb.

Thanks,
Ludo’.

bug#52347: Shell: error when -m manifest is removed

[Ludovic Courtès]

Hi Cayetano,

Cayetano Santos <cayetano.santos@inventati.org> skribis:

>  Following command works
>
>    guix shell --container -m manifest.scm -- python3
>
>  But
>
>    guix shell --container -- python3
>
> gives an error. However,
>
>    guix shell --container
>
> followed by
>
>    python3
>
> works.
>
>  So, by just removing the ’-m manifest.scm’ flag, I get an error.

As Liliana noted, this is the intended behavior: auto-loading of
‘manifest.scm’ happens only for interactive use.  This is to keep
non-interactive use context-independent and thereby avoid bad surprises.

Note that when ‘manifest.scm’ is auto-loaded, a message is printed; when
it’s not considered, no message is printed.  Likewise, when creating an
empty environment, a warning is printed (twice even :-)).

Any suggestions on things we might improve to avoid confusion?

Thanks,
Ludo’.