From: Prafulla Giri <pratheblackdiamond@gmail.com>
To: Brendan Tildesley <mail@brendan.scot>
Cc: 43249@debbugs.gnu.org
Subject: [bug#43249]
Date: Fri, 18 Sep 2020 19:11:05 +0545 [thread overview]
Message-ID: <CAFw+=j24Rpq8cQex0_SoqmFgsM_yQzrjNeDYv80QrYyDkHSUUQ@mail.gmail.com> (raw)
In-Reply-To: <CAFw+=j15_YoTP5WT3gU+DN9WGyMZOeyn6_xKvkp8B4twAxD8Sg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1864 bytes --]
Mr. Tildesley,
The patch has just been merged: https://issues.guix.gnu.org/43419#1
Thank you for your guidance!
On Tue, Sep 15, 2020 at 5:35 PM Prafulla Giri <pratheblackdiamond@gmail.com>
wrote:
> Dear Mr. Tildesley,
>
> I have sent in a patch to do as you've suggested.
> https://issues.guix.gnu.org/43419
>
> Thank you very much.
>
> I will remember this trick of not wrapping wrappers from now on. Thank you
> very much.
>
> On Sun, Sep 13, 2020 at 6:28 PM Brendan Tildesley <mail@brendan.scot>
> wrote:
>
>> On 8/9/20 10:22 pm, Prafulla Giri wrote:
>>
>> I see.
>>
>> Yes, it does make sense now why you chose to replace the 'wrap phase.
>>
>> I wonder.... perhaps it'd be better altogether if the (wrap-program)
>> procedure could be re-written to not make ..*.real.real programs...? That
>> would save us a lot of code-duplication...
>>
>> I have come to understand wrap-program a little better and I realised
>> your patch could have actually been fixed in a better way than I did. The
>> issue is with the part of your code that runs
>>
>>
>> (find-files "." ".*")
>>
>>
>> This is what matches all the .calibre-real files
>> If instead of that, it was:
>>
>> (find-files "." (lambda (file stat) (not (wrapper? file))))
>>
>> or
>>
>> (find-files "." (lambda (file stat) (not (string-prefix "." (basename
>> file))))
>> It should avoid double wrapping. An even simpler way would have been to
>> use (add-before 'wrap ..., instead of (add-after 'wrap ...
>>
>> If you are still interested, feel free to make a patch overwriting mine
>> to use this more correct method, instead of where i duplicated the wrap
>> PYTHONPATH bit.
>>
>> The fact that this happened is a bug though. I created some patches I
>> think fix this for core-updates. It would have made your original patch
>> error and force you to fix it: https://issues.guix.gnu.org/43367
>>
>>
[-- Attachment #2: Type: text/html, Size: 3282 bytes --]
prev parent reply other threads:[~2020-09-18 13:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-06 18:32 [bug#43249] Resolve Calibre run-time dependency Prafulla Giri
2020-09-06 20:09 ` Jonathan Brielmaier
2020-09-07 8:12 ` Brendan Tildesley
2020-09-07 8:15 ` bug#43151: " Brendan Tildesley
2020-09-08 20:11 ` Andreas Enge
2020-09-09 8:38 ` [bug#43249] " Prafulla Giri
2020-09-08 12:22 ` [bug#43249] Prafulla Giri
2020-09-08 13:38 ` [bug#43249] Brendan Tildesley
2020-09-08 19:57 ` [bug#43249] Ricardo Wurmus
2020-09-10 12:46 ` [bug#43249] Brendan Tildesley
2020-09-10 13:22 ` [bug#43249] Ricardo Wurmus
2020-09-11 8:18 ` [bug#43249] Brendan Tildesley
2020-09-11 8:38 ` [bug#43249] Ricardo Wurmus
2020-09-12 11:33 ` [bug#43249] Brendan Tildesley
2020-09-12 12:21 ` [bug#43249] Ricardo Wurmus
2020-09-13 12:43 ` [bug#43249] Brendan Tildesley
2020-09-15 11:50 ` [bug#43249] Prafulla Giri
2020-09-18 13:26 ` Prafulla Giri [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFw+=j24Rpq8cQex0_SoqmFgsM_yQzrjNeDYv80QrYyDkHSUUQ@mail.gmail.com' \
--to=pratheblackdiamond@gmail.com \
--cc=43249@debbugs.gnu.org \
--cc=mail@brendan.scot \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.