From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id MJ2GLq+1ZF/gegAA0tVLHw (envelope-from ) for ; Fri, 18 Sep 2020 13:27:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id OM5lKq+1ZF9iSAAA1q6Kng (envelope-from ) for ; Fri, 18 Sep 2020 13:27:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 44A2C940539 for ; Fri, 18 Sep 2020 13:27:11 +0000 (UTC) Received: from localhost ([::1]:51220 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJGPu-0006Vj-82 for larch@yhetil.org; Fri, 18 Sep 2020 09:27:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45820) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJGPm-0006TS-E0 for guix-patches@gnu.org; Fri, 18 Sep 2020 09:27:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57989) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJGPm-0002FY-4G for guix-patches@gnu.org; Fri, 18 Sep 2020 09:27:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJGPm-0000kw-0V for guix-patches@gnu.org; Fri, 18 Sep 2020 09:27:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43249] Resent-From: Prafulla Giri Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 18 Sep 2020 13:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43249 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Brendan Tildesley Cc: 43249@debbugs.gnu.org Received: via spool by 43249-submit@debbugs.gnu.org id=B43249.16004355852857 (code B ref 43249); Fri, 18 Sep 2020 13:27:01 +0000 Received: (at 43249) by debbugs.gnu.org; 18 Sep 2020 13:26:25 +0000 Received: from localhost ([127.0.0.1]:41302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJGPA-0000k0-NW for submit@debbugs.gnu.org; Fri, 18 Sep 2020 09:26:25 -0400 Received: from mail-pj1-f44.google.com ([209.85.216.44]:39854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJGP9-0000jo-9a for 43249@debbugs.gnu.org; Fri, 18 Sep 2020 09:26:23 -0400 Received: by mail-pj1-f44.google.com with SMTP id v14so3021346pjd.4 for <43249@debbugs.gnu.org>; Fri, 18 Sep 2020 06:26:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=v/bzjBtiQydfT55xtQ0CYJWRfcVkmCUXuJkGM8T1CYk=; b=fh3NBE0nGmwN6WQYdn+oFjeiaJ9cvVglr4RI+V14NjFUQKujVGzEfS9RtsG/mMn1TO nC/6VgL1U7uBWr534EKiaPpLK00UkuO0aRK82gaM4+oUZ3yWcLXYPlM+zIykiwg+4dKm THGoXmsihJcoONnT6EU+YncFud0JDFJryWM9qJc7B+tkdFfX1fo1udLJCWyqJei4nYXO 0Ddcj6Nhdsi2qFDUzNUm+xVYYeHKeNl9urNGGs+NUYRmxxEIE81Lwn8ajS/sf5I0DRwZ RnKM9PaIZxvsWxasrpc5gudgQvQgpVq+GB99AeY80kP3JMu3i0WQ+IX1C/3iPTKU6WYv DVuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=v/bzjBtiQydfT55xtQ0CYJWRfcVkmCUXuJkGM8T1CYk=; b=KlOOsPsWhtLtmsdiQYBQSrQGegLTfw5PZb6qpi97WYhV1zimli0MnuE53rkkZt6hRQ vbG8Oed59CyV7iuxfC9iEz+CW/i4Uby2wVRU38Gcc4bMSLjYXnchv7hnii34LG/3yuG5 xzf12Q1hLl7UjtInKORLPazU+bSh+5IgZIFyLcFg/QeDpEQamvqDqfywRxkcDEU6c3QQ RZqFSIYKFM3rWtw7TKDYRhpFg1Pmp7iWWjdy2gcpR+AoJ+ox6mvKzmRplDmaReDgZ5nh YAKGEd87hADKA2CX6nFiQeUHNnEOcfz/jtCk+VE/8DxZdNUwEqbe+0xasKJ2PMiGxnAl sYCA== X-Gm-Message-State: AOAM530EBkbhPozmOHLMp8qjy27ClyeCSWV3/Zupd5Pc9ELSS4+UkJHr N05BK7eAKTG9TNsqVeh+2SvnqvISrj1pKkJCUNyraoHPq7Txbw== X-Google-Smtp-Source: ABdhPJyfoDuBPPlOdA4a+3tMq15dVSsHqBnkb7aHBg+VBOpeEtuD5Ce5VGGl1aziKkbmNOfbfmmZadu7a0UNoKzAvx4= X-Received: by 2002:a17:902:b583:b029:d1:c807:da44 with SMTP id a3-20020a170902b583b02900d1c807da44mr23919177pls.15.1600435576629; Fri, 18 Sep 2020 06:26:16 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Prafulla Giri Date: Fri, 18 Sep 2020 19:11:05 +0545 Message-ID: Content-Type: multipart/alternative; boundary="00000000000007eddb05af967202" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=fh3NBE0n; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 1.59 X-TUID: CjxKJWjrfej8 --00000000000007eddb05af967202 Content-Type: text/plain; charset="UTF-8" Mr. Tildesley, The patch has just been merged: https://issues.guix.gnu.org/43419#1 Thank you for your guidance! On Tue, Sep 15, 2020 at 5:35 PM Prafulla Giri wrote: > Dear Mr. Tildesley, > > I have sent in a patch to do as you've suggested. > https://issues.guix.gnu.org/43419 > > Thank you very much. > > I will remember this trick of not wrapping wrappers from now on. Thank you > very much. > > On Sun, Sep 13, 2020 at 6:28 PM Brendan Tildesley > wrote: > >> On 8/9/20 10:22 pm, Prafulla Giri wrote: >> >> I see. >> >> Yes, it does make sense now why you chose to replace the 'wrap phase. >> >> I wonder.... perhaps it'd be better altogether if the (wrap-program) >> procedure could be re-written to not make ..*.real.real programs...? That >> would save us a lot of code-duplication... >> >> I have come to understand wrap-program a little better and I realised >> your patch could have actually been fixed in a better way than I did. The >> issue is with the part of your code that runs >> >> >> (find-files "." ".*") >> >> >> This is what matches all the .calibre-real files >> If instead of that, it was: >> >> (find-files "." (lambda (file stat) (not (wrapper? file)))) >> >> or >> >> (find-files "." (lambda (file stat) (not (string-prefix "." (basename >> file)))) >> It should avoid double wrapping. An even simpler way would have been to >> use (add-before 'wrap ..., instead of (add-after 'wrap ... >> >> If you are still interested, feel free to make a patch overwriting mine >> to use this more correct method, instead of where i duplicated the wrap >> PYTHONPATH bit. >> >> The fact that this happened is a bug though. I created some patches I >> think fix this for core-updates. It would have made your original patch >> error and force you to fix it: https://issues.guix.gnu.org/43367 >> >> --00000000000007eddb05af967202 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Mr. Tildesley,

The patch has= just been merged: https://= issues.guix.gnu.org/43419#1

Thank you for your= guidance!

On Tue, Sep 15, 2020 at 5:35 PM Prafulla Giri <pratheblackdiamond@gmail.com= > wrote:
Dear Mr. Tildesley,

I have sent = in a patch to do as you've suggested. https://issues.guix.gnu.org/43419
<= div>
Thank you very much.

I will rem= ember this trick of not wrapping wrappers from now on. Thank you very much.=

On Sun, Sep 13, 2020 at 6:28 PM Brendan Tildesley <mail@brenda= n.scot> wrote:
=20
I see.

Yes, it does make sense now why you chose to replace the 'wrap phase.

I wonder.... perhaps it'd be better altogether if the (wrap-program) procedure could be re-written to not make ..*.real.real programs...? That would save us a lot of code-duplication...

I have come to understand wrap-program a little better and I realised your patch could have actually been fixed in a better way than I did. The issue is with the part of your code that runs


(find-files "." ".*")


This is what matches all the .calibre-real files

If instead of that, it was:

(find-files "." (lambda (file stat) (not (wrapper? file)))= )

or

(find-files "." (lambda (file stat) (not (string-prefix &qu= ot;." (basename file))))

It should avoid double wrapping. An even simpler way would have been to use (add-before 'wrap ..., instead of (add-after 'wrap ...
If you are still interested, feel free to make a patch overwriting mine to use this more correct method, instead of where i duplicated the wrap PYTHONPATH bit.

The fact that this happened is a bug though. I created some patches I think fix this for core-updates. It would have made your original patch error and force you to fix it: https= ://issues.guix.gnu.org/43367


  





--00000000000007eddb05af967202--