* Re: Confused while submitting patch
2020-10-15 7:51 Confused while submitting patch Aniket Patil
@ 2020-10-15 12:48 ` Julien Lepiller
2020-10-15 13:39 ` zimoun
2020-10-16 5:32 ` Arun Isaac
2 siblings, 0 replies; 6+ messages in thread
From: Julien Lepiller @ 2020-10-15 12:48 UTC (permalink / raw)
To: help-guix, Aniket Patil
Le 15 octobre 2020 03:51:51 GMT-04:00, Aniket Patil <aniket112.patil@gmail.com> a écrit :
>Hi all,
>I am new when it comes to submitting patches through email. For my
>first
>patch, I copied all the body from the .path file and pasted in mail.
>Also
>from the subject line, I copied the subject and pasted it in the
>subject of
>my email. To be on the safer side I also attached a patch file to the
>email. What is the write way? I thought submitting through email is the
>easier way than submitting it to git email.
>
>Regards,
>Aniket.
Hi Aniket,
Either use git send-email or, as you did, attach the patch to your message. For long series, you really need to use send-email, otherwise it's fine.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Confused while submitting patch
2020-10-15 7:51 Confused while submitting patch Aniket Patil
2020-10-15 12:48 ` Julien Lepiller
@ 2020-10-15 13:39 ` zimoun
2020-10-16 5:32 ` Arun Isaac
2 siblings, 0 replies; 6+ messages in thread
From: zimoun @ 2020-10-15 13:39 UTC (permalink / raw)
To: Aniket Patil, help-guix
Hi,
On Thu, 15 Oct 2020 at 13:21, Aniket Patil <aniket112.patil@gmail.com> wrote:
> Hi all,
> I am new when it comes to submitting patches through email. For my first
> patch, I copied all the body from the .path file and pasted in mail. Also
> from the subject line, I copied the subject and pasted it in the subject of
> my email. To be on the safer side I also attached a patch file to the
> email. What is the write way? I thought submitting through email is the
> easier way than submitting it to git email.
Well, it depends on the tools you are working on. Let describe the
workflow with plain git commands, then using Magit (the emacs porcelaine)
is let as an exercise.
You need “guix install guix:send-email” and please read the section
Example in [1] for an easy setup.
Now, you are in the fresh cloned repo and you created one branch with
some new commits in. You simply do:
git format-patch -<N> --base=master
where <N> is the number of commit you did. For example, ’-1’ for one
commit, ’-2’ for 2 commits, etc.. You can omit the ’--base’ but it is
useful to know on which commit your commit applies. I also recommend to
use the option ’--cover-letter’, which allows you to describe your
change. Please read “git format-patch --help”.
Well, the ’format-patch’ command should produce:
0000-cover-letter.patch
0001-blabla.patch
Then, it is easy:
git send-email --to=guix-patches@gnu.org 0000-cover-letter.patch
assuming you used the ’--cover-letter’ option. :-) Then you wait a bit
that the robot assigns a Patch number. Check your inbox; if everything
is correctly setup-ed.
You can send your patch with:
git send-email --to=123456@debbugs.gnu.org 0001-blabla.patch
Done!
For patch set (several commits), you replace the last command by:
git send-email --to=123456@debbugs.gnu.org 000?-*.patch
So good, so far.
After the review, you will have modification to do, so you “rebase
interactively” (git rebase -i) and you tweak. Once it is ready to send
the new version of your patch, you have to generate a new one:
git format-patch -<N> -v2
here, you can omit ’--cover-letter’. This will produce:
v2-0001-blabla.patch
and let send it:
git send-email --to=123456@debbugs.gnu.org v2-0001-blabla.patch
It is important to keep the same patch number. Please give a look at
<http://issues.guix.gnu.org/>
for all the patches.
Does that help?
All the best,
simon
1: <https://git-scm.com/docs/git-send-email>
^ permalink raw reply [flat|nested] 6+ messages in thread