[bug#38487] [PATCH] Add ghc-apply-refact

[bug#38487] [PATCH] Add ghc-apply-refact

[Brian Leung]

[-- Attachment #1.1: Type: text/plain, Size: 14 bytes --]

See attached.

[-- Attachment #1.2: Type: text/html, Size: 39 bytes --]

[-- Attachment #2: 0001-gnu-Add-ghc-apply-refact.patch --]
[-- Type: text/x-patch, Size: 2078 bytes --]

From e2df81c5a5e8692e3f981ec9bf5c28cf65cfa124 Mon Sep 17 00:00:00 2001
From: Brian Leung <brian@debian>
Date: Tue, 3 Dec 2019 23:03:06 -0800
Subject: [PATCH] gnu: Add ghc-apply-refact.

* gnu/packages/haskell-xyz.scm (ghc-apply-refact): New variable.
---
 gnu/packages/haskell-xyz.scm | 38 ++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/haskell-xyz.scm b/gnu/packages/haskell-xyz.scm
index fb6833207d..57a64fa880 100644
--- a/gnu/packages/haskell-xyz.scm
+++ b/gnu/packages/haskell-xyz.scm
@@ -13148,3 +13148,41 @@ Zstandard compression algorithm, a fast lossless compression algorithm
 targeting real-time compression scenarios at zlib-level and better
 compression ratios.")
     (license license:bsd-3)))
+
+(define-public ghc-apply-refact
+  (package
+    (name "ghc-apply-refact")
+    (version "0.6.0.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://hackage.haskell.org/package/apply-refact/apply-refact-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "0p2mqgjcqr1zcmk8zgr0yq7g8z1agsa6l493lkj6g3ya9lyhxgig"))))
+    (build-system haskell-build-system)
+    (inputs
+     `(("ghc-refact" ,ghc-refact)
+       ("ghc-exactprint" ,ghc-exactprint)
+       ("ghc-syb" ,ghc-syb)
+       ("ghc-temporary" ,ghc-temporary)
+       ("ghc-filemanip" ,ghc-filemanip)
+       ("ghc-unix-compat" ,ghc-unix-compat)
+       ("ghc-optparse-applicative"
+        ,ghc-optparse-applicative)))
+    (native-inputs
+     `(("ghc-tasty" ,ghc-tasty)
+       ("ghc-tasty-golden" ,ghc-tasty-golden)
+       ("ghc-tasty-expected-failure"
+        ,ghc-tasty-expected-failure)
+       ("ghc-silently" ,ghc-silently)))
+    (home-page
+     "http://hackage.haskell.org/package/apply-refact")
+    (synopsis
+     "Perform refactorings specified by the refact library.")
+    (description
+     "Perform refactorings specified by the refact library. It is primarily used with HLint's --refactor flag.")
+    (license license:bsd-3)))
-- 
2.24.0

[bug#38487] [PATCH] gnu: Add ghc-apply-refact.

[John Soo]

Hi Brian,

Thanks for another haskell tool! I built it this morning and it built.
I do not use apply-refact, though. Have you been using it with
success?

My only thought is to move this package to haskell-apps.scm and call
the package apply-refact. What do you think?

John

[bug#38487] [PATCH] gnu: Add ghc-apply-refact.

[Brian Leung]

[-- Attachment #1.1: Type: text/plain, Size: 517 bytes --]

Hi John,

Thanks for your reply. I tested it just now and it seems to work. I've made
your suggested changes and also attached a related patch.

Best,
Brian

On Fri, Jan 17, 2020 at 8:33 AM John Soo <jsoo1@asu.edu> wrote:

> Hi Brian,
>
> Thanks for another haskell tool! I built it this morning and it built.
> I do not use apply-refact, though. Have you been using it with
> success?
>
> My only thought is to move this package to haskell-apps.scm and call
> the package apply-refact. What do you think?
>
> John
>

[-- Attachment #1.2: Type: text/html, Size: 898 bytes --]

[-- Attachment #2: 0001-gnu-Add-apply-refact.patch --]
[-- Type: text/x-patch, Size: 2176 bytes --]

From 477b6b85eff0534e25e25bd990c7c2d2f5783294 Mon Sep 17 00:00:00 2001
From: Brian Leung <leungbk@mailfence.com>
Date: Thu, 23 Jan 2020 19:26:27 -0800
Subject: [PATCH 1/2] gnu: Add apply-refact.

* gnu/packages/haskell-apps.scm (apply-refact): New variable.
---
 gnu/packages/haskell-apps.scm | 38 +++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/haskell-apps.scm b/gnu/packages/haskell-apps.scm
index 5b5b20cd65..38d043cf6d 100644
--- a/gnu/packages/haskell-apps.scm
+++ b/gnu/packages/haskell-apps.scm
@@ -49,6 +49,44 @@
   #:use-module (gnu packages rsync)
   #:use-module (gnu packages version-control))
 
+(define-public apply-refact
+  (package
+    (name "apply-refact")
+    (version "0.6.0.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://hackage.haskell.org/package/apply-refact/apply-refact-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "0p2mqgjcqr1zcmk8zgr0yq7g8z1agsa6l493lkj6g3ya9lyhxgig"))))
+    (build-system haskell-build-system)
+    (inputs
+     `(("ghc-refact" ,ghc-refact)
+       ("ghc-exactprint" ,ghc-exactprint)
+       ("ghc-syb" ,ghc-syb)
+       ("ghc-temporary" ,ghc-temporary)
+       ("ghc-filemanip" ,ghc-filemanip)
+       ("ghc-unix-compat" ,ghc-unix-compat)
+       ("ghc-optparse-applicative"
+        ,ghc-optparse-applicative)))
+    (native-inputs
+     `(("ghc-tasty" ,ghc-tasty)
+       ("ghc-tasty-golden" ,ghc-tasty-golden)
+       ("ghc-tasty-expected-failure"
+        ,ghc-tasty-expected-failure)
+       ("ghc-silently" ,ghc-silently)))
+    (home-page
+     "http://hackage.haskell.org/package/apply-refact")
+    (synopsis
+     "Perform refactorings specified by the refact library.")
+    (description
+     "Perform refactorings specified by the refact library. It is primarily used with HLint's --refactor flag.")
+    (license license:bsd-3)))
+
 ;; In Stackage LTS 14, this package is at 2.4.1.0.  However, that
 ;; version requires version 2.4.1.0 of the 'Cabal' package, which is
 ;; provided by GHC 8.6.5 at version 2.4.0.1.  Hence, we use an older
-- 
2.24.0


[-- Attachment #3: 0002-gnu-Add-emacs-hlint-refactor-mode.patch --]
[-- Type: text/x-patch, Size: 2107 bytes --]

From 8eb239e18e98848ddbc20d6dc0677b270547c147 Mon Sep 17 00:00:00 2001
From: Brian Leung <leungbk@mailfence.com>
Date: Thu, 23 Jan 2020 20:36:20 -0800
Subject: [PATCH 2/2] gnu: Add emacs-hlint-refactor-mode.

* gnu/packages/emacs-xyz.scm (emacs-hlint-refactor-mode): New variable.
---
 gnu/packages/emacs-xyz.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 40839d4869..f119cf690b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -101,6 +101,7 @@
   #:use-module (gnu packages guile)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages gnome)
+  #:use-module (gnu packages haskell-apps)
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages python)
   #:use-module (gnu packages python-xyz)
@@ -15986,6 +15987,32 @@ text in neighboring sections.")
 Pandoc, the document-conversion tool.")
     (license license:bsd-3)))
 
+(define-public emacs-hlint-refactor-mode
+  (let ((commit "c4307f86aad6d02e32e9b30cb6edc115584c791c")
+        (revision "1"))
+    (package
+      (name "emacs-hlint-refactor-mode")
+      (version (git-version "0.0.1" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/mpickering/hlint-refactor-mode")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "1c71w9s34n0i7mm4njchxn6s3ri1y6mh3akgbg4nq41d42h8iap3"))))
+      (build-system emacs-build-system)
+      (propagated-inputs
+       `(("apply-refact" ,apply-refact)
+         ("hlint" ,hlint)))
+      (home-page "https://github.com/mpickering/hlint-refactor-mode")
+      (synopsis "Emacs bindings for @code{hlint}'s @code{--refactor} option")
+      (description "This package applies refactoring suggestions from
+@code{hlint}.")
+      (license license:expat))))
+
 (define-public emacs-ccls
   (let ((commit "aab3e31fd716daf59f9794e62d473357263e8cc0")
         (revision "4"))
-- 
2.24.0

bug#38487: [PATCH] gnu: Add ghc-apply-refact.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 346 bytes --]

Brian Leung <bkleung89@gmail.com> writes:

> Hi John,
>
> Thanks for your reply. I tested it just now and it seems to work. I've made
> your suggested changes and also attached a related patch.

Thanks!  I added copyright information for you, fixed some issues
reported by 'guix lint' as well as unnecessary linebreaks, and applied
both patches.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]