all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#34724] Guix patch: emacs-debpaste
@ 2019-03-04  0:46 Brian Leung
  2019-03-04  2:24 ` [bug#34724] emacs-debpaste addendum Brian Leung
  2019-03-11 22:07 ` bug#34724: Guix patch: emacs-debpaste Ludovic Courtès
  0 siblings, 2 replies; 3+ messages in thread
From: Brian Leung @ 2019-03-04  0:46 UTC (permalink / raw)
  To: 34724


[-- Attachment #1.1: Type: text/plain, Size: 14 bytes --]

See attached.

[-- Attachment #1.2: Type: text/html, Size: 39 bytes --]

[-- Attachment #2: 0003-gnu-Add-emacs-debpaste.patch --]
[-- Type: text/x-patch, Size: 1626 bytes --]

From 6de902f6b87258530eaba97963393f3ac585b878 Mon Sep 17 00:00:00 2001
From: Brian Leung <bkleung89@gmail.com>
Date: Mon, 4 Mar 2019 01:40:38 +0100
Subject: [PATCH 3/3] gnu: Add emacs-debpaste.
To: guix-patches@gnu.org

---
 gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b1a0d99efb..8ee2888948 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11358,6 +11358,30 @@ Org-mode.  It features:
 @end itemize\n")
       (license license:gpl3+))))
 
+(define-public emacs-debpaste
+  (package
+    (name "emacs-debpaste")
+    (version "0.1.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/alezost/debpaste.el/archive/v"
+             version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "16qqa32ys3gvxf9x1va2cnjcmw1zvbwgc16pqasgrf4mh7qwsd9b"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-xml-rpc" ,emacs-xml-rpc)))
+    (home-page "https://github.com/alezost/debpaste.el")
+    (synopsis "This package provides an interface for receiving, posting and
+deleting pastes from the Debian Pastezone.")
+    (description "Debpaste is an Emacs interface for the Debian Pastezone.
+It provides receiving, posting and deleting pastes using XML-RPC.")
+    (license license:gpl3+)))
+
 (define-public emacs-xml-rpc
   (let ((commit "8f624f8b964e9145acb504e4457c9510e87dd93c")
         (revision "1"))
-- 
2.21.0


[-- Attachment #3: 0002-gnu-Add-emacs-xml-rpc.patch --]
[-- Type: text/x-patch, Size: 1841 bytes --]

From f789513e7f359540725f93d601d9f17b04eb3243 Mon Sep 17 00:00:00 2001
From: Brian Leung <bkleung89@gmail.com>
Date: Mon, 4 Mar 2019 01:39:57 +0100
Subject: [PATCH 2/3] gnu: Add emacs-xml-rpc.
To: guix-patches@gnu.org

---
 gnu/packages/emacs-xyz.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index dda5500f9d..b1a0d99efb 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11358,6 +11358,33 @@ Org-mode.  It features:
 @end itemize\n")
       (license license:gpl3+))))
 
+(define-public emacs-xml-rpc
+  (let ((commit "8f624f8b964e9145acb504e4457c9510e87dd93c")
+        (revision "1"))
+    (package
+      (name "emacs-xml-rpc")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/hexmode/xml-rpc-el")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "0xa54z52rsfl3n0xgmbycj4zazp8ksgdwcq56swzs6wp72zlalmj"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/hexmode/xml-rpc-el")
+      (synopsis "This is an XML-RPC client implementation in Elisp,
+capable of both synchronous and asynchronous method calls using the url
+package's async retrieval functionality.")
+      (description "@file{xml-rpc.el} represents XML-RPC datatypes as Lisp values,
+automatically converting to and from the XML datastructures as needed, both
+for method parameters and return values, making using XML-RPC methods fairly
+transparent to the Lisp code.")
+      (license license:gpl3+))))
+
 (define-public emacs-fish-completion
   (package
     (name "emacs-fish-completion")
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#34724] emacs-debpaste addendum
  2019-03-04  0:46 [bug#34724] Guix patch: emacs-debpaste Brian Leung
@ 2019-03-04  2:24 ` Brian Leung
  2019-03-11 22:07 ` bug#34724: Guix patch: emacs-debpaste Ludovic Courtès
  1 sibling, 0 replies; 3+ messages in thread
From: Brian Leung @ 2019-03-04  2:24 UTC (permalink / raw)
  To: 34724

[-- Attachment #1: Type: text/plain, Size: 126 bytes --]

For the emacs-xml-rpc package, I elected not to use the Release versions
since they don't work properly with Emacs 25 and up.

[-- Attachment #2: Type: text/html, Size: 155 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#34724: Guix patch: emacs-debpaste
  2019-03-04  0:46 [bug#34724] Guix patch: emacs-debpaste Brian Leung
  2019-03-04  2:24 ` [bug#34724] emacs-debpaste addendum Brian Leung
@ 2019-03-11 22:07 ` Ludovic Courtès
  1 sibling, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2019-03-11 22:07 UTC (permalink / raw)
  To: Brian Leung; +Cc: 34724-done

[-- Attachment #1: Type: text/plain, Size: 109 bytes --]

Hi Brian,

I applied the first patch with these changes to address issues reported
by ‘guix lint’:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1698 bytes --]

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 2e6cb7c627..b15917113b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11363,7 +11363,7 @@ Org-mode.  It features:
         (revision "1"))
     (package
       (name "emacs-xml-rpc")
-      (version (git-version "0" revision commit))
+      (version (git-version "1.6.12" revision commit))
       (source
        (origin
          (method git-fetch)
@@ -11376,13 +11376,13 @@ Org-mode.  It features:
            "0xa54z52rsfl3n0xgmbycj4zazp8ksgdwcq56swzs6wp72zlalmj"))))
       (build-system emacs-build-system)
       (home-page "https://github.com/hexmode/xml-rpc-el")
-      (synopsis "This is an XML-RPC client implementation in Elisp,
-capable of both synchronous and asynchronous method calls using the url
-package's async retrieval functionality.")
-      (description "@file{xml-rpc.el} represents XML-RPC datatypes as Lisp values,
-automatically converting to and from the XML datastructures as needed, both
-for method parameters and return values, making using XML-RPC methods fairly
-transparent to the Lisp code.")
+      (synopsis "XML-RPC client for Emacs")
+      (description "This package provides an XML-RPC client for Emacs capable
+of both synchronous and asynchronous method calls using the @code{url}
+package's async retrieval functionality.  @file{xml-rpc.el} represents XML-RPC
+datatypes as Lisp values, automatically converting to and from the XML
+datastructures as needed, both for method parameters and return values, making
+using XML-RPC methods fairly transparent to the Lisp code.")
       (license license:gpl3+))))
 
 (define-public emacs-fish-completion

[-- Attachment #3: Type: text/plain, Size: 33 bytes --]


Likewise for the second patch:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #4: Type: text/x-patch, Size: 1632 bytes --]

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 8d521cffce..69ea0b3b74 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11362,24 +11362,23 @@ Org-mode.  It features:
   (package
     (name "emacs-debpaste")
     (version "0.1.5")
+    (home-page "https://github.com/alezost/debpaste.el")
     (source
      (origin
-       (method url-fetch)
-       (uri (string-append
-             "https://github.com/alezost/debpaste.el/archive/v"
-             version ".tar.gz"))
+       (method git-fetch)
+       (uri (git-reference (url home-page)
+                           (commit (string-append "v" version))))
        (file-name (string-append name "-" version ".tar.gz"))
        (sha256
         (base32
-         "16qqa32ys3gvxf9x1va2cnjcmw1zvbwgc16pqasgrf4mh7qwsd9b"))))
+         "1wi70r56pd5z0x4dp4m58p9asq03j74kdm4fi9vai83vsl2z9amq"))))
     (build-system emacs-build-system)
     (propagated-inputs
      `(("emacs-xml-rpc" ,emacs-xml-rpc)))
-    (home-page "https://github.com/alezost/debpaste.el")
-    (synopsis "This package provides an interface for receiving, posting and
-deleting pastes from the Debian Pastezone.")
-    (description "Debpaste is an Emacs interface for the Debian Pastezone.
-It provides receiving, posting and deleting pastes using XML-RPC.")
+    (synopsis "Manipulate pastes from the Debian Pastezone")
+    (description "Debpaste is an Emacs interface for the Debian Pastezone,
+allowing you to receive, post, and delete pastes.  It communicates with the
+server using XML-RPC.")
     (license license:gpl3+)))
 
 (define-public emacs-xml-rpc

[-- Attachment #5: Type: text/plain, Size: 221 bytes --]


I also tweaked the commit log to follow our conventions.

Please do not miss
<https://www.gnu.org/software/guix/manual/en/html_node/Submitting-Patches.html>
for your future contributions.

Thank you!

Ludo’.

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-03-11 22:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-04  0:46 [bug#34724] Guix patch: emacs-debpaste Brian Leung
2019-03-04  2:24 ` [bug#34724] emacs-debpaste addendum Brian Leung
2019-03-11 22:07 ` bug#34724: Guix patch: emacs-debpaste Ludovic Courtès

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.