From: Maxime Devos <maximedevos@telenet.be>
To: Tobias Geerinckx-Rice <me@tobias.gr>, 55892@debbugs.gnu.org
Subject: [bug#55892] [PATCH] pull: Fail if cache directory ownership is suspect.
Date: Fri, 10 Jun 2022 23:55:28 +0200 [thread overview]
Message-ID: <9ed7f25f4748f52ce1d52ac14f651c366f6b5b36.camel@telenet.be> (raw)
In-Reply-To: <20220605000425.20480-1-me@tobias.gr>
[-- Attachment #1: Type: text/plain, Size: 1060 bytes --]
Tobias Geerinckx-Rice via Guix-patches via schreef op zo 05-06-2022 om
02:04 [+0200]:
> Hi Guix,
>
> Another one in the ‘low-level support noise paper-cut’ series.
> The XXX comment would not land upstream, I think.
>
> I didn't test this on a foreign distribution. My understanding is
> that distributions where sudo already defaults to ‘-i’ won't throw
> the warning nor suffer from the problem.
>
> Kind regards,
>
> T G-R
>
Concept looks sounds to me!
Nitpick:
+ (let ((our:user (passwd:name (getpwuid our:uid)))
+ (dir:user (passwd:name (getpwuid dir:uid))))
what if the current user does not have an entry in /etc/passwd or
equivalent? (E.g. if the user accidentally removed an entry in
/etc/passwd on a foreign system and then runs "guix pull" & "guix shell
THE_EDITOR" to get their favourite editor to edit /etc/passwd back?)
Maybe in that case, it should be reported as NNNN (NNNN = user number)?
Or would that be simply considered unsupported?
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2022-06-10 21:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-05 0:04 [bug#55892] [PATCH] pull: Fail if cache directory ownership is suspect Tobias Geerinckx-Rice via Guix-patches via
[not found] ` <handler.55892.B.165487726311767.ack@debbugs.gnu.org>
2022-06-10 16:10 ` Tobias Geerinckx-Rice via Guix-patches via
2022-06-10 21:55 ` Maxime Devos [this message]
2022-06-11 2:26 ` bug#55892: " Tobias Geerinckx-Rice via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ed7f25f4748f52ce1d52ac14f651c366f6b5b36.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=55892@debbugs.gnu.org \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.