From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YJ5ZFvu9o2KnawEAbAwnHQ (envelope-from ) for ; Fri, 10 Jun 2022 23:56:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id MGRkFvu9o2KZ/AAAauVa8A (envelope-from ) for ; Fri, 10 Jun 2022 23:56:11 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2B32D26E9B for ; Fri, 10 Jun 2022 23:56:11 +0200 (CEST) Received: from localhost ([::1]:50042 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nzmbx-00030d-F2 for larch@yhetil.org; Fri, 10 Jun 2022 17:56:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42856) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzmbq-00030V-5G for guix-patches@gnu.org; Fri, 10 Jun 2022 17:56:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57578) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nzmbp-0001Ei-SN for guix-patches@gnu.org; Fri, 10 Jun 2022 17:56:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nzmbp-0003hg-NU for guix-patches@gnu.org; Fri, 10 Jun 2022 17:56:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55892] [PATCH] pull: Fail if cache directory ownership is suspect. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 10 Jun 2022 21:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55892 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tobias Geerinckx-Rice , 55892@debbugs.gnu.org Received: via spool by 55892-submit@debbugs.gnu.org id=B55892.165489813214200 (code B ref 55892); Fri, 10 Jun 2022 21:56:01 +0000 Received: (at 55892) by debbugs.gnu.org; 10 Jun 2022 21:55:32 +0000 Received: from localhost ([127.0.0.1]:51475 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzmbM-0003gw-An for submit@debbugs.gnu.org; Fri, 10 Jun 2022 17:55:32 -0400 Received: from xavier.telenet-ops.be ([195.130.132.52]:51032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzmbK-0003go-BN for 55892@debbugs.gnu.org; Fri, 10 Jun 2022 17:55:30 -0400 Received: from [172.20.10.5] ([213.119.181.187]) by xavier.telenet-ops.be with bizsmtp id hZvU2700B42zmhR01ZvU5n; Fri, 10 Jun 2022 23:55:29 +0200 Message-ID: <9ed7f25f4748f52ce1d52ac14f651c366f6b5b36.camel@telenet.be> From: Maxime Devos Date: Fri, 10 Jun 2022 23:55:28 +0200 In-Reply-To: <20220605000425.20480-1-me@tobias.gr> References: <20220605000425.20480-1-me@tobias.gr> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-OabmK8zc5yXCgXw04VSq" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1654898129; bh=EuIjZGxnsFeycjQXYUTOmh9/JqkMBK1xpJnEbCHbYM4=; h=Subject:From:To:Date:In-Reply-To:References; b=EyfAuKrdFFwyoCTf5igjUPrEJGb4bKBU6cusGzjEfqbTuy1NHdFZ9Sz7b8s2PbAuT XrOIY2FqSeo4L+HqsO4Ykasvp4hj8xOCD2vru3RNLjQK2JROEhPIRVnsH3JoaDVQ8G RAsljWXdsdPgyZL8CWJJ6usFRGK7CKS8WgBGVSb2ZtyWDl+VFMidUWfVZSNChniv5K totkJqPlvJIMcusjT3Q4As/zTm+iI7kWqEe7R40cqRYerextXPsl/Oi/PVoBbbNRtD +F7dPxW6GzzEN/1d3BN0psz9KBumrUQOGTGF141ZV6oLmN+3DAnGo+TkogJUUkyJIB vIaht9CUbMA5w== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654898171; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=EuIjZGxnsFeycjQXYUTOmh9/JqkMBK1xpJnEbCHbYM4=; b=S3PJthlZ/FCuZSXQ7h+YNkNIxgTDiHKh26ibo1taedDoa2ZzK3109wuRNLCnjDH/m0b4tC rK7/TC05ptnVV8qi3wAJpwG3hCm7d6YUn7b0pnvAl82rQH0Eas8KuBqJjp4RAPu+YMsSxk H5ZInBN+1dB3ElvaiBeB/iMOaiHmtaEWPBgcEVtBydjNXVFA9Y7dgGh5ITwtRIUkPoyeTi vevZlRdMrDWzVr2ibwRcICunpmdoOaXDaVDMXvO/vpX4AgP1eQTA8dsMnor88Aj536U5ib P9Plq9vusromiTBqBZ7KeLnxeC1X+N0L9pS/i8dEL7MEcwO7e84Bns4zwPUVcg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654898171; a=rsa-sha256; cv=none; b=O4mtYqVdYfHh8b8yHlYXHNdmmpe8G7a9fAVVlFKuAJxsaC7JMncpm4nhYfmokPaKJeOA3o zK88hFZiWn90GEIil2Ho8GuU6Ijc5dUcxxKTBeJ44DddV2wyIze5vTx9FbeZq2jieCTlEB hnXrRa1Ih2ZblVxJX7YACqMLqGYzWDDjshOlIuEmeDkcIqCZ0nPNmPlpiudCDY6fYkKEzW Bd4WAljOivYyrjeAkwt1rM8v6smGHelCB4sMza+hyB5MpFjdQhuAsLnJPbSz4us9k37qpA YYSPdVDQibWekwE9psCSvMtfK3XUDwtECqMyEnJuHkHgiw3NHiDozjFW1M3qtQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=EyfAuKrd; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.92 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=EyfAuKrd; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2B32D26E9B X-Spam-Score: 2.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: BSW04e9vOZXi --=-OabmK8zc5yXCgXw04VSq Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Tobias Geerinckx-Rice via Guix-patches via schreef op zo 05-06-2022 om 02:04 [+0200]: > Hi Guix, >=20 > Another one in the =E2=80=98low-level support noise paper-cut=E2=80=99 se= ries. > The XXX comment would not land upstream, I think. >=20 > I didn't test this on a foreign distribution.=C2=A0 My understanding is > that distributions where sudo already defaults to =E2=80=98-i=E2=80=99 wo= n't throw > the warning nor suffer from the problem. >=20 > Kind regards, >=20 > T G-R >=20 Concept looks sounds to me! Nitpick: + (let ((our:user (passwd:name (getpwuid our:uid))) + (dir:user (passwd:name (getpwuid dir:uid)))) what if the current user does not have an entry in /etc/passwd or equivalent? (E.g. if the user accidentally removed an entry in /etc/passwd on a foreign system and then runs "guix pull" & "guix shell THE_EDITOR" to get their favourite editor to edit /etc/passwd back?) Maybe in that case, it should be reported as NNNN (NNNN =3D user number)? Or would that be simply considered unsupported? Greetings, Maxime. --=-OabmK8zc5yXCgXw04VSq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYqO90BccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7otHAQCsenGfmkTOhTLk83p0s3qqlzFA nOOO5/2htUxQc1EEWAD6A5X/c68GuLki69Dh+sU/GmnSA6i1GV/uXcjyYHLoQgI= =lRN+ -----END PGP SIGNATURE----- --=-OabmK8zc5yXCgXw04VSq--