bug#57477: "guix refresh -u" sometimes 'unmirrors' source URLs

bug#57477: "guix refresh -u" sometimes 'unmirrors' source URLs

[Maxime Devos]

[-- Attachment #1.1.1: Type: text/plain, Size: 288 bytes --]

As noted in #57463 (https://issues.guix.gnu.org/57463#1) by Marius Bakke:

> The updater has a tendency to change the URI from mirror:// to the
> resolved URL, which can be easy to miss when staging the patch.
>
> (it would be nice to fix that bug)
TBI ...

Greetings,
Maxime


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

bug#57477: "guix refresh -u" sometimes 'unmirrors' source URLs

[Maxime Devos]

[-- Attachment #1.1.1: Type: text/plain, Size: 167 bytes --]

The problem appears to be that latest-ftp-release in (guix 
gnu-maintenance) always constructs a ftp:// URL, even if mirror:// is 
desired.

Greetings,
Maxime


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

bug#57477: "guix refresh -u" sometimes 'unmirrors' source URLs

[Maxime Devos]

[-- Attachment #1.1.1: Type: text/plain, Size: 602 bytes --]


On 29-08-2022 19:30, Maxime Devos wrote:
> As noted in #57463 (https://issues.guix.gnu.org/57463#1) by Marius Bakke:
>
>> The updater has a tendency to change the URI from mirror:// to the
>> resolved URL, which can be easy to miss when staging the patch.
>>
>> (it would be nice to fix that bug)
> TBI ...
>
> Greetings,
> Maxime
>
This happens for the gnu-ftp updater, which is according to a comment 
next to its definition, obsolescent. I'll try changing the packages to 
use the generic-html updater instead, maybe gnu-ftp can be removed 
afterwards ...

Greetings,
Maxime.


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

bug#57477: "guix refresh -u" sometimes 'unmirrors' source URLs

[Maxime Devos]

[-- Attachment #1.1.1: Type: text/plain, Size: 92 bytes --]

The 'change to generic-html' plan didn't work out, generic-html has the 
same problem ...

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

bug#57477: "guix refresh -u" sometimes 'unmirrors' source URLs

[Maxime Devos]

[-- Attachment #1.1.1: Type: text/plain, Size: 184 bytes --]

I think I've found a solution: extract some mirror://-generating code 
from check-mirror-url and use it in check-mirror-url. Currently trying 
this out ...

Greetings,
Maxime.


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

bug#57477: "guix refresh -u" sometimes 'unmirrors' source URLs

[Maxime Devos]

[-- Attachment #1.1.1: Type: text/plain, Size: 17 bytes --]

Fixed in #57515

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]