From: "Ludovic Courtès" <ludo@gnu.org>
To: Meiyo Peng <meiyo.peng@gmail.com>
Cc: 33849@debbugs.gnu.org
Subject: [bug#33849] [PATCH] gnu: Add polybar
Date: Sun, 23 Dec 2018 18:41:19 +0100 [thread overview]
Message-ID: <87zhswgmyo.fsf@gnu.org> (raw)
In-Reply-To: <87imzkfe3g.fsf@gmail.com> (Meiyo Peng's message of "Sun, 23 Dec 2018 23:38:11 +0800")
Hello,
Meiyo Peng <meiyo.peng@gmail.com> skribis:
>>From e5871eaba91a1d5909fbc0ffcea767244204f644 Mon Sep 17 00:00:00 2001
> From: Meiyo Peng <meiyo.peng@gmail.com>
> Date: Sun, 23 Dec 2018 23:05:38 +0800
> Subject: [PATCH] gnu: Add polybar.
>
> * gnu/packages/wm.scm (polybar): New variable.
[...]
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "https://github.com/jaagr/polybar/releases/"
> + "download/" version "/polybar.tar"))
> + (sha256
> + (base32 "1zpsvh1n77bx7s6mqqh3ba828k9xbp35c2mjmcl9nywfp6r5ldqi"))
> + (file-name (string-append name "-" version ".tar"))))
Please use ‘git-fetch’ rather than downloading a generated tarball (it’s
a generated tarball, right?).
> + (build-system cmake-build-system)
> + (arguments
> + ;; Test is disabled because it requires downloading googletest from the
> + ;; Internet.
> + '(#:tests? #f))
Did you try adding ‘googletest’ to ‘native-inputs’, and perhaps also
disabling the code that tries to download it?
The rest LGTM! Could you send an updated patch?
Thank you,
Ludo’.
next prev parent reply other threads:[~2018-12-23 17:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-23 15:38 [bug#33849] [PATCH] gnu: Add polybar Meiyo Peng
2018-12-23 17:41 ` Ludovic Courtès [this message]
2018-12-24 6:27 ` Meiyo Peng
2018-12-25 16:45 ` bug#33849: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhswgmyo.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=33849@debbugs.gnu.org \
--cc=meiyo.peng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.