From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56062)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gb7lN-0002Rb-3t
	for guix-patches@gnu.org; Sun, 23 Dec 2018 12:42:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gb7lK-00057Z-9x
	for guix-patches@gnu.org; Sun, 23 Dec 2018 12:42:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:57976)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gb7lK-00057L-3p
	for guix-patches@gnu.org; Sun, 23 Dec 2018 12:42:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gb7lJ-0006lp-Ve
	for guix-patches@gnu.org; Sun, 23 Dec 2018 12:42:02 -0500
Subject: [bug#33849] [PATCH] gnu: Add polybar
Resent-Message-ID: <handler.33849.B33849.154558688325972@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <87imzkfe3g.fsf@gmail.com>
Date: Sun, 23 Dec 2018 18:41:19 +0100
In-Reply-To: <87imzkfe3g.fsf@gmail.com> (Meiyo Peng's message of "Sun, 23 Dec
	2018 23:38:11 +0800")
Message-ID: <87zhswgmyo.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Meiyo Peng <meiyo.peng@gmail.com>
Cc: 33849@debbugs.gnu.org

Hello,

Meiyo Peng <meiyo.peng@gmail.com> skribis:

>>>From e5871eaba91a1d5909fbc0ffcea767244204f644 Mon Sep 17 00:00:00 2001
> From: Meiyo Peng <meiyo.peng@gmail.com>
> Date: Sun, 23 Dec 2018 23:05:38 +0800
> Subject: [PATCH] gnu: Add polybar.
>
> * gnu/packages/wm.scm (polybar): New variable.

[...]

> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/jaagr/polybar/releases/"
> +                           "download/" version "/polybar.tar"))
> +       (sha256
> +        (base32 "1zpsvh1n77bx7s6mqqh3ba828k9xbp35c2mjmcl9nywfp6r5ldqi"))
> +       (file-name (string-append name "-" version ".tar"))))

Please use =E2=80=98git-fetch=E2=80=99 rather than downloading a generated =
tarball (it=E2=80=99s
a generated tarball, right?).

> +    (build-system cmake-build-system)
> +    (arguments
> +     ;; Test is disabled because it requires downloading googletest from=
 the
> +     ;; Internet.
> +     '(#:tests? #f))

Did you try adding =E2=80=98googletest=E2=80=99 to =E2=80=98native-inputs=
=E2=80=99, and perhaps also
disabling the code that tries to download it?

The rest LGTM!  Could you send an updated patch?

Thank you,
Ludo=E2=80=99.