[bug#38075] [PATCH] services: mpd: add pulseaudio support

[Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 1879 bytes --]

Peter [CC'd],

I see that you added the Guix MPD service in 2017, and wrote then 
that it ‘uses pulseaudio for output’[0].  Do you have an opinion 
on this patch[1]?  Did something change?

Kind regards,

T G-R

[0]: http://guix.gnu.org/manual/en/html_node/Audio-Services.html
[1]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38075

Ludovic Courtès 写道：
> Robert Smith <robertsmith@posteo.net> skribis:
>
>> Set the XDG_RUNTIME_PATH environment variable in the mpd 
>> service so
>> that it can detect pulseaudio when run under a user account.
>> ---
>>  gnu/services/audio.scm | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm
>> index 471c5fd95f..424ccc7c8f 100644
>> --- a/gnu/services/audio.scm
>> +++ b/gnu/services/audio.scm
>> @@ -140,6 +140,12 @@ audio_output {
>>                     "--no-daemon"
>>                     #$(mpd-config->file config))
>>               #:pid-file #$(mpd-file-name config "pid")
>> +             #:environment-variables
>> +             '(#$(string-append
>> +                   "XDG_RUNTIME_DIR=/run/user/"
>> +                   (number->string
>> +                     (passwd:uid 
>> +                       (getpwnam (mpd-configuration-user 
>> config))))))
>>               #:log-file #$(mpd-file-name config "log")))
>
> I suppose this is meant for the libpulse client library, right? 
> (I’m
> surprised it’s not the default, but apparently that’s the way it 
> is.)
>
> Note that this also has an effect on mpd itself from what I can 
> see in
> the source: mpd will listen to $XDG_RUNTIME_DIR/mpd/socket 
> instead of
> (in addition to?) listening on TCP.
>
> I don’t use mpd myself; could you ensure that the socket change 
> is also
> fine and doesn’t cause any troubles for mpd clients?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]