all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: 38075-done@debbugs.gnu.org, Robert Smith <robertsmith@posteo.net>
Subject: bug#38075: [PATCH] services: mpd: add pulseaudio support
Date: Fri, 08 Nov 2019 21:34:58 +0100	[thread overview]
Message-ID: <87y2wqw1hp.fsf@nckx> (raw)
In-Reply-To: <20191105224645.12269-1-robertsmith@posteo.net>

[-- Attachment #1: Type: text/plain, Size: 869 bytes --]

Robert,

Thanks for the patch!

Robert Smith 写道：
> +             #:environment-variables
> +             '(#$(string-append
> +                   "XDG_RUNTIME_DIR=/run/user/"
> +                   (number->string
> +                     (passwd:uid 
> +                       (getpwnam (mpd-configuration-user 
> config))))))

Like Ludo', I'm surprised this isn't the default.  My XDG-foo is 
weak, though.

Your patch failed to break my set-up (better luck next time) so 
I've pushed it as 970cb5ceceaa85765230a9f896a43783cdcb4e6c with 
the following tweaks:

- Adjusted the commit message to follow the GNU change log 
  standards & Guix's conventions
- Promoted your commenty commit message to first-class comment
- Removed a trailing space after ‘passwd:uid’ (git diff/show/… 
  should highlight this)

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

      parent reply	other threads:[~2019-11-08 20:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-05 22:46 [bug#38075] [PATCH] services: mpd: add pulseaudio support Robert Smith
2019-11-06 11:22 ` Ludovic Courtès
2019-11-06 13:32   ` Robert Smith
2019-11-06 18:27   ` Leo Famulari
2019-11-06 23:54     ` Robert Smith
2019-11-08 19:53   ` Tobias Geerinckx-Rice via Guix-patches via
2019-11-08 20:28     ` Peter Mikkelsen
2019-11-08 20:34 ` Tobias Geerinckx-Rice via Guix-patches via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2wqw1hp.fsf@nckx \
    --to=guix-patches@gnu.org \
    --cc=38075-done@debbugs.gnu.org \
    --cc=me@tobias.gr \
    --cc=robertsmith@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.