From: Brett Gilio <brettg@posteo.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 34698-done@debbugs.gnu.org, "Nicolò Balzarotti" <anothersms@gmail.com>
Subject: bug#34698: [PATCH] gnu: add org-noter.
Date: Mon, 09 Dec 2019 22:55:51 -0600 [thread overview]
Message-ID: <87zhg0lqy0.fsf@posteo.net> (raw)
In-Reply-To: <87lg1f230z.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Fri, 15 Mar 2019 23:20:28 +0100")
Ludovic Courtès <ludo@gnu.org> writes:
> Hello,
>
> Nicolò Balzarotti <anothersms@gmail.com> skribis:
>
>> ---
>> gnu/packages/emacs-xyz.scm | 32 ++++++++++++++++++++++++++++++++
>> 1 file changed, 32 insertions(+)
>
> Could you add a commit log that follows our conventions?
>
>> + (method url-fetch)
>> + (uri (string-append
>> + "https://stable.melpa.org/packages/org-noter-"
>> + version
>> + ".el"))
>
> Since files on MELPA are unversioned and regularly modified in place,
> could you instead use the upstream URL (presumably the GitHub repo)?
>
>> + (synopsis
>> + "A synchronized, Org-mode, document annotator")
> ^
> ‘guix lint’ probably complains about this; please remove the “A”.
>
>> + (description
>> + "The idea is to let you create notes that are kept in sync when you scroll through the
>> +document, but that are external to it - the notes themselves live in an Org-mode file. As
>> +such, this leverages the power of Org-mode (the notes may have outlines, latex fragments,
>> +babel, etc...) while acting like notes that are made /in/ the document.
>> +
>> +Also, I must thank Sebastian for the original idea and inspiration!
>> +Link to the original Interleave package:
>> +https://github.com/rudolfochrist/interleave
>
> Please change the description to describe the package contents from the
> viewpoint of an outsider. See the guidelines at
> <https://www.gnu.org/software/guix/manual/en/html_node/Synopses-and-Descriptions.html>.
>
>> + (license license:gpl3)))
>
> The source file header explicitly says “or any later version”, so it
> should be ‘license:gpl3+’.
>
> Could you send an updated patch?
>
> Thank you,
> Ludo’.
>
>
>
>
Hi Ludo' and Nicolò,
Closing this as it was added in commit
576cb396eac4e8cea2b54d96382f8e77f3584e89 on 2019-06-13.
Thanks!
--
Brett M. Gilio
Homepage -- https://scm.pw/
GNU Guix -- https://guix.gnu.org/
next prev parent reply other threads:[~2019-12-10 4:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 8:07 [bug#34699] [PATCH] gnu: add emacs-smart-hungry-delete Nicolò Balzarotti
2019-03-01 8:07 ` [bug#34698] [PATCH] gnu: add org-noter Nicolò Balzarotti
2019-03-15 22:20 ` Ludovic Courtès
2019-12-10 4:55 ` Brett Gilio [this message]
2019-03-01 8:07 ` [bug#34697] [PATCH] gnu: add r-lintr Nicolò Balzarotti
2019-03-07 19:47 ` Ricardo Wurmus
2019-12-11 8:19 ` [bug#34697] [PATCH 3/3] gnu: Add r-lintr Nicolò Balzarotti
2019-12-11 11:12 ` bug#34697: " Ricardo Wurmus
2019-12-11 8:19 ` [bug#34697] [PATCH 1/3] gnu: Add r-xmlparsedata Nicolò Balzarotti
2019-12-11 8:19 ` [bug#34697] [PATCH 2/3] gnu: Add r-cyclocomp Nicolò Balzarotti
2019-03-01 8:07 ` [bug#34696] [PATCH] gnu: add r-rematch2 Nicolò Balzarotti
2019-03-14 9:58 ` bug#34696: " Ricardo Wurmus
2019-03-01 8:07 ` [bug#34695] [PATCH] gnu: add r-rex Nicolò Balzarotti
2019-04-13 9:13 ` bug#34695: " Ricardo Wurmus
2019-03-01 8:07 ` [bug#34692] [PATCH] gnu: add r-statcheck Nicolò Balzarotti
2019-03-07 19:43 ` Ricardo Wurmus
2019-03-23 20:58 ` Ludovic Courtès
2019-03-23 21:18 ` Nicolò Balzarotti
2019-12-11 9:00 ` Nicolò Balzarotti
2019-12-11 10:15 ` bug#34692: " Ricardo Wurmus
2019-03-01 8:07 ` [bug#34694] [PATCH] gnu: add r-styler Nicolò Balzarotti
2019-04-19 17:15 ` bug#34694: " Ricardo Wurmus
2019-03-01 8:07 ` [bug#34693] [PATCH] services: mpd: add more configuration options Nicolò Balzarotti
2019-03-08 11:34 ` Ludovic Courtès
2019-03-08 13:29 ` Nicolò Balzarotti
2019-03-15 22:08 ` bug#34693: " Ludovic Courtès
2020-12-11 6:28 ` bug#34699: [PATCH] gnu: add emacs-smart-hungry-delete Arun Isaac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhg0lqy0.fsf@posteo.net \
--to=brettg@posteo.net \
--cc=34698-done@debbugs.gnu.org \
--cc=anothersms@gmail.com \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.