From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:35107) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ieXa3-0007er-Id for guix-patches@gnu.org; Mon, 09 Dec 2019 23:57:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ieXa2-0003w8-6P for guix-patches@gnu.org; Mon, 09 Dec 2019 23:57:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:48746) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ieXa1-0003vr-OG for guix-patches@gnu.org; Mon, 09 Dec 2019 23:57:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ieXa1-00072N-Nl for guix-patches@gnu.org; Mon, 09 Dec 2019 23:57:01 -0500 Subject: bug#34698: [PATCH] gnu: add org-noter. Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Brett Gilio References: <20190301080758.5548-1-anothersms@gmail.com> <20190301080758.5548-2-anothersms@gmail.com> <87lg1f230z.fsf@gnu.org> Date: Mon, 09 Dec 2019 22:55:51 -0600 In-Reply-To: <87lg1f230z.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Fri, 15 Mar 2019 23:20:28 +0100") Message-ID: <87zhg0lqy0.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 34698-done@debbugs.gnu.org, =?UTF-8?Q?Nicol=C3=B2?= Balzarotti Ludovic Court=C3=A8s writes: > Hello, > > Nicol=C3=B2 Balzarotti skribis: > >> --- >> gnu/packages/emacs-xyz.scm | 32 ++++++++++++++++++++++++++++++++ >> 1 file changed, 32 insertions(+) > > Could you add a commit log that follows our conventions? > >> + (method url-fetch) >> + (uri (string-append >> + "https://stable.melpa.org/packages/org-noter-" >> + version >> + ".el")) > > Since files on MELPA are unversioned and regularly modified in place, > could you instead use the upstream URL (presumably the GitHub repo)? > >> + (synopsis >> + "A synchronized, Org-mode, document annotator") > ^ > =E2=80=98guix lint=E2=80=99 probably complains about this; please remove = the =E2=80=9CA=E2=80=9D. > >> + (description >> + "The idea is to let you create notes that are kept in sync when yo= u scroll through the >> +document, but that are external to it - the notes themselves live in an= Org-mode file. As >> +such, this leverages the power of Org-mode (the notes may have outlines= , latex fragments, >> +babel, etc...) while acting like notes that are made /in/ the document. >> + >> +Also, I must thank Sebastian for the original idea and inspiration! >> +Link to the original Interleave package: >> +https://github.com/rudolfochrist/interleave > > Please change the description to describe the package contents from the > viewpoint of an outsider. See the guidelines at > . > >> + (license license:gpl3))) > > The source file header explicitly says =E2=80=9Cor any later version=E2= =80=9D, so it > should be =E2=80=98license:gpl3+=E2=80=99. > > Could you send an updated patch? > > Thank you, > Ludo=E2=80=99. > > > > Hi Ludo' and Nicol=C3=B2, Closing this as it was added in commit 576cb396eac4e8cea2b54d96382f8e77f3584e89 on 2019-06-13. Thanks! --=20 Brett M. Gilio Homepage -- https://scm.pw/ GNU Guix -- https://guix.gnu.org/