From: Mathieu Othacehe <othacehe@gnu.org>
To: Jan Wielkiewicz <tona_kosmicznego_smiecia@interia.pl>
Cc: 40677@debbugs.gnu.org
Subject: [bug#40677] [PATCH v4] gnu: Add ffmpeg-jami.
Date: Thu, 14 May 2020 09:05:03 +0200 [thread overview]
Message-ID: <87zhab2e00.fsf@gnu.org> (raw)
In-Reply-To: <20200513181234.27548-1-tona_kosmicznego_smiecia@interia.pl> (Jan Wielkiewicz's message of "Wed, 13 May 2020 20:12:34 +0200")
Hello Jan,
> +;; This procedure composes the configure flags list for ffmpeg-jami.
> +(define (ffmpeg-compose-configure-flags)
> + (let* ((flags %ffmpeg-default-configure-flags)
> + (append-flags (lambda (l)
> + (set! flags (append flags l))))
It's better to avoid using "set!".
> + (system=? (lambda (s)
> + (string-prefix? %current-system s))))
This should be (%current-system), plus I think arguments should be
transposed.
> + (if (string-contains %current-system "linux")
> + (begin (append-flags %ffmpeg-linux-configure-flags)
> + (cond ((or (system=? "i686")
> + (system=? "x86_64"))
> + (append-flags %ffmpeg-linux-x86-configure-flags))
> + ((system=? "x86_64")
> + (append-flags '("--arch=x86_64")))
If the first branch of the cond succeeds, we will never add this flag.
Plus, it seems than ffmpeg is able to detect the running system. So I
would suggest to do this:
--8<---------------cut here---------------start------------->8---
;; This procedure composes the configure flags list for ffmpeg-jami.
(define (ffmpeg-compose-configure-flags)
(define (system=? s)
(string-prefix? s (%current-system)))
`(,@%ffmpeg-default-configure-flags
;; Add Linux specific flags.
,@(if (string-contains %current-system "linux")
%ffmpeg-linux-configure-flags
'())
,@(if (or (system=? "i686") (system=? "x86_64"))
%ffmpeg-linux-x86-configure-flags
'())))
--8<---------------cut here---------------end--------------->8---
What do you think?
Thanks,
Mathieu
next prev parent reply other threads:[~2020-05-14 7:06 UTC|newest]
Thread overview: 144+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 0:00 [bug#40677] Jami Jan Wielkiewicz
2020-04-17 0:34 ` [bug#40677] [PATCH 01/30] gnu: jami: Move Jami and its dependencies to jami.scm Jan Wielkiewicz
2020-04-17 0:34 ` [bug#40677] [PATCH 02/30] gnu: jami: Bump to 20200203.1.5ee7e10 Jan Wielkiewicz
2020-04-17 0:34 ` [bug#40677] [PATCH 03/30] gnu: jami: Fix downloading by changing the prefix to "jami_"; Use the "release" dir instead of the deprecated "ring-release" Jan Wielkiewicz
2020-04-18 12:16 ` Mathieu Othacehe
2020-04-17 0:34 ` [bug#40677] [PATCH 04/30] gnu: jami: Add a generalized procedure for applying patches made by Savoir-faire linux to Jami dependencies Jan Wielkiewicz
2020-04-18 12:24 ` Mathieu Othacehe
2020-04-17 0:34 ` [bug#40677] [PATCH 05/30] gnu: pjproject-jami: Use the jami-apply-dependency-patches procedure Jan Wielkiewicz
2020-04-18 12:27 ` Mathieu Othacehe
2020-04-17 0:34 ` [bug#40677] [PATCH 06/30] gnu: Add libnatpmp Jan Wielkiewicz
2020-04-18 12:30 ` Mathieu Othacehe
2020-04-17 0:34 ` [bug#40677] [PATCH 07/30] gnu: libring: Add libnatpmp as an optional dependency; remove unnecessary comment Jan Wielkiewicz
2020-04-18 12:33 ` Mathieu Othacehe
2020-04-17 0:34 ` [bug#40677] [PATCH 08/30] gnu: libupnp: Bump to 1.8.6; change the download method to git-fetch; add missing dependencies Jan Wielkiewicz
2020-04-18 12:37 ` Mathieu Othacehe
2020-04-17 0:34 ` [bug#40677] [PATCH 09/30] gnu: opendht: Bump to 2.0.0rc1 Jan Wielkiewicz
2020-04-17 0:34 ` [bug#40677] [PATCH 10/30] gnu: Add ffmpeg-jami Jan Wielkiewicz
2020-04-18 12:49 ` Mathieu Othacehe
2020-04-19 20:03 ` Jan
2020-04-17 0:34 ` [bug#40677] [PATCH 11/30] gnu: libring: Use ffmpeg-jami instead of ffmpeg Jan Wielkiewicz
2020-04-17 0:34 ` [bug#40677] [PATCH 12/30] gnu: restinio: Bump to 0.6.1.1 Jan Wielkiewicz
2020-04-17 0:34 ` [bug#40677] [PATCH 13/30] gnu: pjproject: Add and apply a patch fixing the crash Jan Wielkiewicz
2020-04-18 12:54 ` Mathieu Othacehe
2020-04-19 22:26 ` Jan
2020-04-17 0:34 ` [bug#40677] [PATCH 14/30] gnu: jami.scm: Add a missing module Jan Wielkiewicz
2020-04-18 12:55 ` Mathieu Othacehe
2020-04-17 0:34 ` [bug#40677] [PATCH 15/30] gnu: jami: Bump to 20200206.2.996bf03 Jan Wielkiewicz
2020-04-18 12:56 ` Mathieu Othacehe
2020-04-19 19:49 ` Jan
2020-04-17 0:34 ` [bug#40677] [PATCH 16/30] gnu: pjproject-jami: Add a new SFL patch Jan Wielkiewicz
2020-04-18 13:00 ` Mathieu Othacehe
2020-04-19 19:49 ` Jan
2020-04-19 20:32 ` Michael Rohleder
2020-04-17 0:34 ` [bug#40677] [PATCH 17/30] gnu: pjproject: Fix formatting Jan Wielkiewicz
2020-04-17 0:34 ` [bug#40677] [PATCH 18/30] gnu: jami: Make gettext a native input Jan Wielkiewicz
2020-04-17 0:34 ` [bug#40677] [PATCH 19/30] gnu: jami.scm: Untabify by emacs Jan Wielkiewicz
2020-04-18 13:08 ` Mathieu Othacehe
2020-04-17 0:34 ` [bug#40677] [PATCH 20/30] gnu: jami: Bump to 20200214.1.7488e86 Jan Wielkiewicz
2020-04-17 0:34 ` [bug#40677] [PATCH 21/30] gnu: opendht: Bump to 2.0.0rc2 Jan Wielkiewicz
2020-04-17 0:34 ` [bug#40677] [PATCH 22/30] gnu: networking.scm: Add missing copyright year Jan Wielkiewicz
2020-04-17 0:34 ` [bug#40677] [PATCH 23/30] gnu: pjproject, pjproject-jami: Remove broken pjproject package. Make pjproject-jami package stand-alone by moving package code from pjproject into it Jan Wielkiewicz
2020-04-18 13:03 ` Mathieu Othacehe
2020-04-19 19:44 ` Jan
2020-04-17 0:34 ` [bug#40677] [PATCH 24/30] gnu: jami: Bump to 20200326.1.f8d3d10 Jan Wielkiewicz
2020-04-17 0:34 ` [bug#40677] [PATCH 25/30] gnu: pjproject-jami: Bump to 2.10; apply some cool patches Jan Wielkiewicz
2020-04-17 0:34 ` [bug#40677] [PATCH 26/30] gnu: jami.scm: Indent code properly Jan Wielkiewicz
2020-04-17 0:34 ` [bug#40677] [PATCH 27/30] gnu: opendht: Bump to 2.0.0 Jan Wielkiewicz
2020-04-17 0:34 ` [bug#40677] [PATCH 28/30] gnu: jami: Bump to 20200401.1.6f090de Jan Wielkiewicz
2020-04-17 0:34 ` [bug#40677] [PATCH 29/30] gnu: jami: Replace gnu-gettext with gettext-minimal, just like on master Jan Wielkiewicz
2020-04-17 0:34 ` [bug#40677] [PATCH 30/30] gnu: pjproject-jami: Add the missing "--enable-epoll" flag Jan Wielkiewicz
2020-04-18 13:13 ` Mathieu Othacehe
2020-04-18 12:13 ` [bug#40677] [PATCH 01/30] gnu: jami: Move Jami and its dependencies to jami.scm Mathieu Othacehe
2020-04-20 22:55 ` [bug#40677] Code review problems resolved Jan
2020-04-21 7:04 ` Christopher Baines
2020-04-21 7:28 ` Mathieu Othacehe
2020-04-21 16:10 ` [bug#40677] [PATCH 01/18] gnu: jami: Move Jami and its dependencies to jami.scm Jan Wielkiewicz
2020-04-21 16:10 ` [bug#40677] [PATCH 02/18] gnu: jami: Fix downloading Jan Wielkiewicz
2020-04-21 16:10 ` [bug#40677] [PATCH 03/18] gnu: jami.scm: Add and use a generalized procedure for applying patches made by Savoir-faire linux to Jami dependencies Jan Wielkiewicz
2020-04-22 9:07 ` Mathieu Othacehe
2020-04-21 16:10 ` [bug#40677] [PATCH 04/18] gnu: Add libnatpmp Jan Wielkiewicz
2020-04-22 9:27 ` Mathieu Othacehe
2020-04-27 22:55 ` Jan
2020-04-28 7:19 ` Mathieu Othacehe
2020-04-29 22:31 ` Jan
2020-04-30 7:04 ` Mathieu Othacehe
2020-04-21 16:10 ` [bug#40677] [PATCH 05/18] gnu: libring: Add libnatpmp as an optional dependency Jan Wielkiewicz
2020-04-21 16:10 ` [bug#40677] [PATCH 06/18] gnu: libupnp: Bump to 1.8.6; change the download method to git-fetch; add missing dependencies Jan Wielkiewicz
2020-04-21 16:10 ` [bug#40677] [PATCH 07/18] gnu: Add ffmpeg-jami Jan Wielkiewicz
2020-04-21 16:10 ` [bug#40677] [PATCH 08/18] gnu: libring: Use ffmpeg-jami instead of ffmpeg Jan Wielkiewicz
2020-04-21 16:10 ` [bug#40677] [PATCH 09/18] gnu: restinio: Bump to 0.6.1.1 Jan Wielkiewicz
2020-04-21 16:10 ` [bug#40677] [PATCH 10/18] gnu: pjproject-jami: Add a new SFL patch Jan Wielkiewicz
2020-04-21 16:10 ` [bug#40677] [PATCH 11/18] gnu: pjproject: Fix formatting Jan Wielkiewicz
2020-04-22 9:32 ` Mathieu Othacehe
2020-04-21 16:10 ` [bug#40677] [PATCH 12/18] gnu: jami: Make gettext a native input Jan Wielkiewicz
2020-04-21 16:10 ` [bug#40677] [PATCH 13/18] gnu: pjproject, pjproject-jami: Remove broken pjproject package. Make pjproject-jami package stand-alone by moving package code from pjproject into it Jan Wielkiewicz
2020-04-22 9:39 ` Mathieu Othacehe
2020-04-22 11:42 ` Jan
2020-04-21 16:10 ` [bug#40677] [PATCH 14/18] gnu: pjproject-jami: Bump to 2.10, apply new SFL patches Jan Wielkiewicz
2020-04-22 9:40 ` Mathieu Othacehe
2020-04-21 16:10 ` [bug#40677] [PATCH 15/18] gnu: opendht: Bump to 2.0.0 Jan Wielkiewicz
2020-04-21 16:10 ` [bug#40677] [PATCH 16/18] gnu: jami: Bump to 20200401.1.6f090de Jan Wielkiewicz
2020-04-21 16:10 ` [bug#40677] [PATCH 17/18] gnu: jami: Replace gnu-gettext with gettext-minimal, just like on master Jan Wielkiewicz
2020-04-21 16:10 ` [bug#40677] [PATCH 18/18] gnu: pjproject-jami: Add the missing, linux-only "--enable-epoll" flag Jan Wielkiewicz
2020-04-22 9:44 ` Mathieu Othacehe
2020-04-22 8:59 ` [bug#40677] [PATCH 01/18] gnu: jami: Move Jami and its dependencies to jami.scm Mathieu Othacehe
2020-04-22 10:42 ` Jan
2020-04-22 11:42 ` Mathieu Othacehe
2020-04-27 23:18 ` Jan
2020-04-28 7:14 ` Mathieu Othacehe
2020-04-22 16:08 ` Christopher Baines
2020-05-02 1:14 ` [bug#40677] [PATCH V3 00/15] Jami patches Jan Wielkiewicz
2020-05-02 1:14 ` [bug#40677] [PATCH V3 01/15] gnu: telephony.scm: Move Jami and its dependencies to jami.scm Jan Wielkiewicz
2020-05-02 8:45 ` Mathieu Othacehe
2020-05-02 1:14 ` [bug#40677] [PATCH V3 02/15] gnu: jami: Fix downloading Jan Wielkiewicz
2020-05-02 8:47 ` Mathieu Othacehe
2020-05-02 1:14 ` [bug#40677] [PATCH V3 03/15] gnu: jami.scm: Add and use a generalized procedure for applying patches to Jami dependencies Jan Wielkiewicz
2020-05-02 8:54 ` Mathieu Othacehe
2020-05-02 1:14 ` [bug#40677] [PATCH V3 04/15] gnu: Add libnatpmp Jan Wielkiewicz
2020-05-02 8:22 ` Mathieu Othacehe
2020-05-02 1:14 ` [bug#40677] [PATCH V3 05/15] gnu: libring: Add libnatpmp as an optional dependency Jan Wielkiewicz
2020-05-02 8:56 ` Mathieu Othacehe
2020-05-02 1:14 ` [bug#40677] [PATCH V3 06/15] gnu: libupnp: Bump to 1.8.6 Jan Wielkiewicz
2020-05-02 8:30 ` Mathieu Othacehe
2020-05-02 1:14 ` [bug#40677] [PATCH V3 07/15] gnu: Add ffmpeg-jami Jan Wielkiewicz
2020-05-02 9:36 ` Mathieu Othacehe
2020-05-02 11:31 ` Jan
2020-05-04 18:26 ` Jan
2020-05-05 7:18 ` Mathieu Othacehe
2020-05-07 0:22 ` Jan
2020-05-08 8:43 ` Mathieu Othacehe
2020-05-07 20:03 ` Jan
2020-05-08 8:35 ` Mathieu Othacehe
2020-05-13 14:57 ` Jan
2020-05-13 15:51 ` Mathieu Othacehe
2020-05-02 1:14 ` [bug#40677] [PATCH V3 08/15] gnu: libring: Use ffmpeg-jami instead of ffmpeg Jan Wielkiewicz
2020-05-02 1:14 ` [bug#40677] [PATCH V3 09/15] gnu: restinio: Bump to 0.6.1.1 Jan Wielkiewicz
2020-05-02 8:32 ` Mathieu Othacehe
2020-05-02 1:14 ` [bug#40677] [PATCH V3 10/15] gnu: jami: Make gettext a native input Jan Wielkiewicz
2020-05-02 8:58 ` Mathieu Othacehe
2020-05-02 1:14 ` [bug#40677] [PATCH V3 11/15] gnu: pjproject, pjproject-jami: Bump to 2.10, apply new SFL patches Jan Wielkiewicz
2020-05-02 9:14 ` Mathieu Othacehe
2020-05-02 15:17 ` Jan
2020-05-02 1:14 ` [bug#40677] [PATCH V3 12/15] gnu: jami: Bump to 20200401.1.6f090de Jan Wielkiewicz
2020-05-02 9:19 ` Mathieu Othacehe
2020-05-02 11:33 ` Jan
2020-05-02 9:25 ` Mathieu Othacehe
2020-05-02 15:04 ` Jan
2020-05-02 1:14 ` [bug#40677] [PATCH V3 13/15] gnu: jami: Replace gnu-gettext with gettext-minimal, just like on master Jan Wielkiewicz
2020-05-02 9:28 ` Mathieu Othacehe
2020-05-02 1:14 ` [bug#40677] [PATCH V3 14/15] gnu: pjproject-jami: Add the missing, linux-only "--enable-epoll" flag Jan Wielkiewicz
2020-05-02 9:32 ` Mathieu Othacehe
2020-05-02 1:14 ` [bug#40677] [PATCH V3 15/15] gnu: opendht: Bump to 2.0.0 Jan Wielkiewicz
2020-05-02 8:38 ` Mathieu Othacehe
2020-05-02 9:52 ` [bug#40677] [PATCH V3 00/15] Jami patches Mathieu Othacehe
2020-05-02 11:26 ` Jan
2020-05-03 7:34 ` Mathieu Othacehe
2020-05-03 14:32 ` Jan
2020-05-02 14:58 ` Jan
2020-05-13 18:12 ` [bug#40677] [PATCH v4] gnu: Add ffmpeg-jami Jan Wielkiewicz
2020-05-14 7:05 ` Mathieu Othacehe [this message]
2020-05-14 12:43 ` Jan
2020-05-15 6:59 ` Mathieu Othacehe
2020-05-15 0:47 ` [bug#40677] [PATCH v5] " Jan Wielkiewicz
2020-05-15 7:11 ` bug#40677: " Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhab2e00.fsf@gnu.org \
--to=othacehe@gnu.org \
--cc=40677@debbugs.gnu.org \
--cc=tona_kosmicznego_smiecia@interia.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.