From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id UMSzMuDtvF5aTwAA0tVLHw (envelope-from ) for ; Thu, 14 May 2020 07:06:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id IFMALeDtvF4sCQAA1q6Kng (envelope-from ) for ; Thu, 14 May 2020 07:06:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A180094053F for ; Thu, 14 May 2020 07:06:05 +0000 (UTC) Received: from localhost ([::1]:35156 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZ7wT-0000Zt-EG for larch@yhetil.org; Thu, 14 May 2020 03:06:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43604) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZ7wQ-0000ZQ-Pf for guix-patches@gnu.org; Thu, 14 May 2020 03:06:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48531) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jZ7wQ-00005i-Gi for guix-patches@gnu.org; Thu, 14 May 2020 03:06:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jZ7wQ-0001j7-CP for guix-patches@gnu.org; Thu, 14 May 2020 03:06:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#40677] [PATCH v4] gnu: Add ffmpeg-jami. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 14 May 2020 07:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40677 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Jan Wielkiewicz Cc: 40677@debbugs.gnu.org Received: via spool by 40677-submit@debbugs.gnu.org id=B40677.15894399196577 (code B ref 40677); Thu, 14 May 2020 07:06:02 +0000 Received: (at 40677) by debbugs.gnu.org; 14 May 2020 07:05:19 +0000 Received: from localhost ([127.0.0.1]:60077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZ7vh-0001hv-5b for submit@debbugs.gnu.org; Thu, 14 May 2020 03:05:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jZ7vc-0001hd-C2 for 40677@debbugs.gnu.org; Thu, 14 May 2020 03:05:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55222) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZ7vW-0008GV-Nd; Thu, 14 May 2020 03:05:06 -0400 Received: from [2a01:cb18:832e:5f00:8906:a4cb:3f4a:242f] (port=47574 helo=meru) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jZ7vV-0004K8-Pp; Thu, 14 May 2020 03:05:06 -0400 From: Mathieu Othacehe References: <20200417015857.0650ff6a@interia.pl> <20200513181234.27548-1-tona_kosmicznego_smiecia@interia.pl> Date: Thu, 14 May 2020 09:05:03 +0200 In-Reply-To: <20200513181234.27548-1-tona_kosmicznego_smiecia@interia.pl> (Jan Wielkiewicz's message of "Wed, 13 May 2020 20:12:34 +0200") Message-ID: <87zhab2e00.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 X-Spam-Score: -1.01 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Scan-Result: default: False [-1.01 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.53932280410067]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.51.188.0/24:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.05), country: US(-0.00), ip: 209.51.188.17(-0.54)]; DWL_DNSWL_BLOCKED(0.00)[209.51.188.17:from]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; RCPT_COUNT_TWO(0.00)[2]; MAILLIST(-0.20)[mailman]; FREEMAIL_TO(0.00)[interia.pl]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:22989, ipnet:209.51.188.0/24, country:US]; TAGGED_FROM(0.00)[larch=yhetil.org]; FROM_NEQ_ENVFROM(0.00)[othacehe@gnu.org,guix-patches-bounces@gnu.org]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[gnu.org]; HAS_LIST_UNSUB(-0.01)[]; DNSWL_BLOCKED(0.00)[209.51.188.17:from]; RCVD_COUNT_SEVEN(0.00)[9]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: ebmmqjity54I Hello Jan, > +;; This procedure composes the configure flags list for ffmpeg-jami. > +(define (ffmpeg-compose-configure-flags) > + (let* ((flags %ffmpeg-default-configure-flags) > + (append-flags (lambda (l) > + (set! flags (append flags l)))) It's better to avoid using "set!". > + (system=? (lambda (s) > + (string-prefix? %current-system s)))) This should be (%current-system), plus I think arguments should be transposed. > + (if (string-contains %current-system "linux") > + (begin (append-flags %ffmpeg-linux-configure-flags) > + (cond ((or (system=? "i686") > + (system=? "x86_64")) > + (append-flags %ffmpeg-linux-x86-configure-flags)) > + ((system=? "x86_64") > + (append-flags '("--arch=x86_64"))) If the first branch of the cond succeeds, we will never add this flag. Plus, it seems than ffmpeg is able to detect the running system. So I would suggest to do this: --8<---------------cut here---------------start------------->8--- ;; This procedure composes the configure flags list for ffmpeg-jami. (define (ffmpeg-compose-configure-flags) (define (system=? s) (string-prefix? s (%current-system))) `(,@%ffmpeg-default-configure-flags ;; Add Linux specific flags. ,@(if (string-contains %current-system "linux") %ffmpeg-linux-configure-flags '()) ,@(if (or (system=? "i686") (system=? "x86_64")) %ffmpeg-linux-x86-configure-flags '()))) --8<---------------cut here---------------end--------------->8--- What do you think? Thanks, Mathieu