bug#47226: fennel package not working with generic-html refresh updater

bug#47226: fennel package not working with generic-html refresh updater

[Léo Le Bouter via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 890 bytes --]

After applying:

diff --git a/gnu/packages/lua.scm b/gnu/packages/lua.scm
index edb3f85109..36fd1eb066 100644
--- a/gnu/packages/lua.scm
+++ b/gnu/packages/lua.scm
@@ -1175,6 +1175,8 @@ enabled.")
               (snippet
                '(begin
                   (delete-file "fennelview.lua") #t))))
+    (properties
+     '((release-monitoring-url . "https://fennel-lang.org/downloads/")
))
     (build-system gnu-build-system)
     (arguments
      '(#:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs
"out")))

$ ./pre-inst-env guix refresh fennel
gnu/packages/lua.scm:1162:2: warning: no updater for fennel

It should otherwise clearly work since 
https://fennel-lang.org/downloads/ is a classic directory listing like
the generic-html updater should support.

I think it may be because this package uses a git-reference rather than
url-fetch.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#47226: fennel package not working with generic-html refresh updater

[Ludovic Courtès]

Léo Le Bouter <lle-bout@zaclys.net> skribis:

> After applying:
>
> diff --git a/gnu/packages/lua.scm b/gnu/packages/lua.scm
> index edb3f85109..36fd1eb066 100644
> --- a/gnu/packages/lua.scm
> +++ b/gnu/packages/lua.scm
> @@ -1175,6 +1175,8 @@ enabled.")
>                (snippet
>                 '(begin
>                    (delete-file "fennelview.lua") #t))))
> +    (properties
> +     '((release-monitoring-url . "https://fennel-lang.org/downloads/")
> ))
>      (build-system gnu-build-system)
>      (arguments
>       '(#:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs
> "out")))
>
> $ ./pre-inst-env guix refresh fennel
> gnu/packages/lua.scm:1162:2: warning: no updater for fennel
>
> It should otherwise clearly work since 
> https://fennel-lang.org/downloads/ is a classic directory listing like
> the generic-html updater should support.

‘generic-html’ is for packages that use ‘url-fetch’ and a tarball
fetched over HTTP(S).  It does not apply to Fennel.

Here we should use the relevant sr.ht HTTP API, similar to what (guix
import github) does, or possibly a generic ‘git-tag’ updater as you
proposed.

Ludo’.