all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: david larsson <david.larsson@selfhosted.xyz>
Cc: guix-patches-bounces+david.larsson=selfhosted.xyz@gnu.org,
	51432@debbugs.gnu.org
Subject: [bug#51432] [PATCH 3/4] gnu: Add marshmallow-jsonapi
Date: Wed, 03 Nov 2021 14:34:19 +0100	[thread overview]
Message-ID: <87zgql5dz0.fsf@nckx> (raw)
In-Reply-To: <77232ac1914f40ac2d037ef20153d913@selfhosted.xyz>

[-- Attachment #1: Type: text/plain, Size: 1259 bytes --]

David,

> +        (base32
> +         "1d9pxcgmln4gls99vwj1h24qv0lz7fb2jqmqrsiv1pid1snc125x"))))
[…]
> +    (home-page
> +     "https://github.com/marshmallow-code/marshmallow-jsonapi")
> +    (synopsis
> +     "JSON API 1.0 (https://jsonapi.org) formatting with 
> marshmallow")

Nitpick: none of these need to be on separate lines (after 
removing the URL from the description).

Guix synopses and descriptions support (a comfortable subset of) 
Texinfo.  You can include hyperlinks in Texinfo with

  @uref{https://your.url/here, optional description}

For subjective reasons I decided to keep only the URL in the 
description.

> +    (description
> +     "JSON API 1.0 (https://jsonapi.org) formatting with 
> marshmallow")

Descriptions should consist of full sentences.  A single line is 
way too short.  Upstream has a fine description that fits our 
standards, so I adapted it:

+    (description
+     "The marshmallow-jsonapi package provides a simple way to 
produce
+@uref{https://jsonapi.org, JSON:API}-compliant data in any Python 
Web framework.
+It includes optional utilities to integrate with Flask.")

> +    (license license:expat))) ; MIT license

No need for this comment.

Thanks!

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

  reply	other threads:[~2021-11-03 17:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-27 10:52 [bug#51432] [PATCH 0/4] gnu: Add flask-combo-jsonapi david larsson
2021-10-27 10:56 ` [bug#51432] [PATCH 1/4] gnu: Add sqlalchemy-1.3 david larsson
2021-11-03 13:27   ` bug#51432: " Tobias Geerinckx-Rice via Guix-patches via
2021-10-27 10:59 ` [bug#51432] [PATCH 2/4] gnu: Add marshmallow 3.2 david larsson
2021-11-03 14:30   ` Tobias Geerinckx-Rice via Guix-patches via
2021-10-27 11:01 ` [bug#51432] [PATCH 3/4] gnu: Add marshmallow-jsonapi david larsson
2021-11-03 13:34   ` Tobias Geerinckx-Rice via Guix-patches via [this message]
2021-10-27 11:02 ` [bug#51432] [PATCH 4/4] gnu: Add flask-combo-jsonapi david larsson
2021-10-27 18:44   ` david larsson
2021-11-03 13:46     ` Tobias Geerinckx-Rice via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgql5dz0.fsf@nckx \
    --to=guix-patches@gnu.org \
    --cc=51432@debbugs.gnu.org \
    --cc=david.larsson@selfhosted.xyz \
    --cc=guix-patches-bounces+david.larsson=selfhosted.xyz@gnu.org \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.