all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: david larsson <david.larsson@selfhosted.xyz>
Cc: 51432-done@debbugs.gnu.org
Subject: bug#51432: [PATCH 1/4] gnu: Add sqlalchemy-1.3
Date: Wed, 03 Nov 2021 14:27:41 +0100	[thread overview]
Message-ID: <878ry56sk0.fsf@nckx> (raw)
In-Reply-To: <98ab18241bb0ad6493ee361c723890a3@selfhosted.xyz>

[-- Attachment #1: Type: text/plain, Size: 873 bytes --]

David,

Thanks!  I've pushed this series as 
52a7fba8fc78763967c15781ea9b9176d3b4cc26 et al.

> Subject: [PATCH 1/4] gnu: Add sqlalchemy-1.3.

Use the full package name here.  This applies to all patches in 
this series AFAICT.

> +    ;; (propagated-inputs
> +    ;;  `(("python-greenlet" ,python-greenlet)))

Why is this commented out?  Please add a comment in such cases (if 
you've verified that all dependents still work without it, or that 
it was added after 1.3.20).

Great news!  This whole package can instead be written as:

(define-public python-sqlalchemy-1.3
  (package
    (inherit python-sqlalchemy)
    (version "1.3.20")
    (source
     (origin
      (method url-fetch)
      (uri (pypi-uri "SQLAlchemy" version))
      (sha256
       (base32 "18b9am7bsqc4nj3d2h5r93i002apczxfvpfpcqbd6f0385zmrwnj"))))
    (propagated-inputs '())))

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

  reply	other threads:[~2021-11-03 17:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-27 10:52 [bug#51432] [PATCH 0/4] gnu: Add flask-combo-jsonapi david larsson
2021-10-27 10:56 ` [bug#51432] [PATCH 1/4] gnu: Add sqlalchemy-1.3 david larsson
2021-11-03 13:27   ` Tobias Geerinckx-Rice via Guix-patches via [this message]
2021-10-27 10:59 ` [bug#51432] [PATCH 2/4] gnu: Add marshmallow 3.2 david larsson
2021-11-03 14:30   ` Tobias Geerinckx-Rice via Guix-patches via
2021-10-27 11:01 ` [bug#51432] [PATCH 3/4] gnu: Add marshmallow-jsonapi david larsson
2021-11-03 13:34   ` Tobias Geerinckx-Rice via Guix-patches via
2021-10-27 11:02 ` [bug#51432] [PATCH 4/4] gnu: Add flask-combo-jsonapi david larsson
2021-10-27 18:44   ` david larsson
2021-11-03 13:46     ` Tobias Geerinckx-Rice via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878ry56sk0.fsf@nckx \
    --to=guix-patches@gnu.org \
    --cc=51432-done@debbugs.gnu.org \
    --cc=david.larsson@selfhosted.xyz \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.