From: Thiago Jung Bauermann via Guix-patches via <guix-patches@gnu.org>
To: Andrew Tropin <andrew@trop.in>
Cc: 55107@debbugs.gnu.org
Subject: [bug#55107] [PATCH] gnu: zsh: Build and install info pages.
Date: Wed, 27 Apr 2022 00:51:39 -0300 [thread overview]
Message-ID: <87zgk718lz.fsf@kolabnow.com> (raw)
In-Reply-To: <877d7dd2o5.fsf@trop.in>
Hello Andrew,
This looks great. Just a couple of comments:
Andrew Tropin <andrew@trop.in> writes:
> [[PGP Signed Part:Undecided]]
>
> * gnu/packages/shells.scm (zsh)[arguments]: Build and install info pages.
The changelog should also mention the addition of texinfo to inputs (or
native inputs).
> @@ -522,9 +524,13 @@ (define-public zsh
> (("command -pv") "command -v")
> (("command -p") "command ")
> (("'command' -p") "'command' "))
> - #t)))))
> + #t))
Phases don't need to return #t anymore, so this patch would be a nice
opportunity to remove it here.
> + (add-after 'build 'make-info
> + (lambda _ (invoke "make" "info")))
> + (add-after 'build 'install-info
> + (lambda _ (invoke "make" "install.info"))))))
> (native-inputs (list autoconf))
> - (inputs (list ncurses pcre perl))
> + (inputs (list ncurses pcre perl texinfo))
texinfo is a tool executed during the build process itself, so it should
be listed in native-inputs to allow cross-compilation.
--
Thanks
Thiago
next prev parent reply other threads:[~2022-04-27 3:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 6:40 [bug#55107] [PATCH] gnu: zsh: Build and install info pages Andrew Tropin
2022-04-27 3:51 ` Thiago Jung Bauermann via Guix-patches via [this message]
2022-04-29 12:54 ` bug#55107: " Ludovic Courtès
[not found] ` <handler.55107.D55107.16512368901526.notifdone@debbugs.gnu.org>
2022-05-02 12:14 ` [bug#55107] closed (Re: bug#55107: [PATCH] gnu: zsh: Build and install info pages.) Andrew Tropin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgk718lz.fsf@kolabnow.com \
--to=guix-patches@gnu.org \
--cc=55107@debbugs.gnu.org \
--cc=andrew@trop.in \
--cc=bauermann@kolabnow.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.