From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id iMhyI1e/aGJiUAEAbAwnHQ (envelope-from ) for ; Wed, 27 Apr 2022 05:58:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id sDeQI1e/aGKKJgEA9RJhRA (envelope-from ) for ; Wed, 27 Apr 2022 05:58:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1BBED2C86D for ; Wed, 27 Apr 2022 05:58:15 +0200 (CEST) Received: from localhost ([::1]:58892 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njYoe-0002GJ-Qz for larch@yhetil.org; Tue, 26 Apr 2022 23:58:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42184) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njYoU-0002Fv-R6 for guix-patches@gnu.org; Tue, 26 Apr 2022 23:58:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47008) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njYoU-0001D4-IK for guix-patches@gnu.org; Tue, 26 Apr 2022 23:58:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1njYoU-0002rB-E6 for guix-patches@gnu.org; Tue, 26 Apr 2022 23:58:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55107] [PATCH] gnu: zsh: Build and install info pages. Resent-From: Thiago Jung Bauermann Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 27 Apr 2022 03:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55107 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andrew Tropin Cc: 55107@debbugs.gnu.org Received: via spool by 55107-submit@debbugs.gnu.org id=B55107.165103186410958 (code B ref 55107); Wed, 27 Apr 2022 03:58:02 +0000 Received: (at 55107) by debbugs.gnu.org; 27 Apr 2022 03:57:44 +0000 Received: from localhost ([127.0.0.1]:40905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njYoC-0002qg-Ha for submit@debbugs.gnu.org; Tue, 26 Apr 2022 23:57:44 -0400 Received: from mx.kolabnow.com ([212.103.80.154]:59346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njYoA-0002qS-Ao for 55107@debbugs.gnu.org; Tue, 26 Apr 2022 23:57:43 -0400 Received: from localhost (unknown [127.0.0.1]) by mx.kolabnow.com (Postfix) with ESMTP id DE7C2A6F; Wed, 27 Apr 2022 05:57:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-type:content-type:mime-version:message-id:in-reply-to :date:date:subject:subject:from:from:references:received :received:received; s=dkim20160331; t=1651031855; x=1652846256; bh=7CUpVwEuy4L1327DBoccR3/xm9EM6yy9ffzScJ1wWWo=; b=UpcCPFpxTjPY uUKNI0ArDYrsm/tApnCNvc7oHzgoj0MJPSEopdyMUusM5qbi+f287nN8bs+t/PcJ 0EidYiyiuzzzCt3uGnCQZ9+0CIkINoUTF8hxyRRPTtf1zxH9b96wM/tvMg9Ay2L3 gvN2ps19ayou45bnAbis7LcskzIHzHDdAvpjzM7NaCkCZckZsCsXBCUqxXaAs0nk ghUALiTx+q26LGmp14jHgPNUMl4xdkRA9IR74ni9T7GmI/CNi4t0BJJwanwrvSpk 9SgPBj0lstWv/jd8Di2CS9okRKa1fDntmzUGin1QZDH54+5RE3nuL7fqvGTyWtk1 J7vLvhZlW5JJJSPB55FXG0gaLAuitUapt0XtpLfyPTZtjp3KIUNoR8NSx7lj1mng CjBx9Yl1tRSL/4UVVdc51k0k8b+biKovFURikN8s64BjRLT+W5RsahViyCi6akko ZMoNWd36dGwqQRdQgnE/NYkhcJPBeFxkkyD3rHpckQEahVls+J6xLszQIk/905uP O5YLmsms1cJxVcB2bY53tsHl5oE37aiZmFaf8pB2VtbdIPfd82+9ME1UI4GxRs77 62I+QEDC6ksHnm2A//XBd2+nnofW3OYO836TsVEpFls7p3eMNZajihtK0FA5HKP6 rBnTeC6UJsq1pDaha3mTSFY9B5pQLNs= X-Virus-Scanned: amavisd-new at mykolab.com Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out001.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gTlCKnTfVABQ; Wed, 27 Apr 2022 05:57:35 +0200 (CEST) Received: from int-mx003.mykolab.com (unknown [10.9.13.3]) by mx.kolabnow.com (Postfix) with ESMTPS id DB3ED652; Wed, 27 Apr 2022 05:57:34 +0200 (CEST) Received: from ext-subm003.mykolab.com (unknown [10.9.6.3]) by int-mx003.mykolab.com (Postfix) with ESMTPS id 6B5DA3602; Wed, 27 Apr 2022 05:57:34 +0200 (CEST) References: <877d7dd2o5.fsf@trop.in> Date: Wed, 27 Apr 2022 00:51:39 -0300 In-reply-to: <877d7dd2o5.fsf@trop.in> Message-ID: <87zgk718lz.fsf@kolabnow.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Thiago Jung Bauermann X-ACL-Warn: , Thiago Jung Bauermann via Guix-patches From: Thiago Jung Bauermann via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1651031895; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=7CUpVwEuy4L1327DBoccR3/xm9EM6yy9ffzScJ1wWWo=; b=oZ49btBynDWOvZcVBGQ5B5ZIp3JZthBWDEu2fNQ4/qiAPS+fEe3FyMRgbmKXsdzHXb9d/D OnWNMImuYWYlPRQ3obUCbLZtuVJ7Q3+ZVxjRDyTq1u9Uk/4apqbBxTVauRu1Q+fx1veYOm rAHqmYysIu1etp3GCGVxAlIsSIYUNyEqYYRlLALe1Bk6WIncb5b+K9FlWMW3Cy85Lo0muZ PQLB2FVw7o/dBjUWIxUdDan4Pj1vNlVQhbtOv3KSDTEvHeBv1DGB65dcfckJIHZlVq5vx6 YjSVCXLrN3eylAok8HwUwY1CZl19XqvdOqElvyLeW/W8aCnv9uBpECXpX2h5FA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1651031895; a=rsa-sha256; cv=none; b=hGwMb8cRjsXI9aCzHvA5vOqzie3cRA2k49DFvYuF6wI5rnDeVPL4qLK3hZtuCCSKLPUqhR je9eKnetUJ3+v8fFKs29t1lDsgkEzk4CsU2wtFBCHSyZ1JlMyocNjAxZZrPyiXYcNu2Ccw XeKwdftJlMi5Dm3V/lpQZrIWjKsolaxJQ8FvAgx/9X9Z1rLo4zdvpdWxqK16yRoivyPLT3 ImWCxLr5/NiA39wM4a2Qs7Il1jh8xOhL2EsNYg7waPXRGh7rR1WN3nIuIzBrwmVpJXrz+2 yzrFHzFj20A9djRQsipByHQ+dh/jFHmos4I9HvNCt9Htnvmnp07VvyNKuzbCqw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kolabnow.com header.s=dkim20160331 header.b=UpcCPFpx; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.80 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kolabnow.com header.s=dkim20160331 header.b=UpcCPFpx; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 1BBED2C86D X-Spam-Score: -4.80 X-Migadu-Scanner: scn0.migadu.com X-TUID: HQu5Cx2WYtXt Hello Andrew, This looks great. Just a couple of comments: Andrew Tropin writes: > [[PGP Signed Part:Undecided]] > > * gnu/packages/shells.scm (zsh)[arguments]: Build and install info pages. The changelog should also mention the addition of texinfo to inputs (or native inputs). > @@ -522,9 +524,13 @@ (define-public zsh > (("command -pv") "command -v") > (("command -p") "command ") > (("'command' -p") "'command' ")) > - #t))))) > + #t)) Phases don't need to return #t anymore, so this patch would be a nice opportunity to remove it here. > + (add-after 'build 'make-info > + (lambda _ (invoke "make" "info"))) > + (add-after 'build 'install-info > + (lambda _ (invoke "make" "install.info")))))) > (native-inputs (list autoconf)) > - (inputs (list ncurses pcre perl)) > + (inputs (list ncurses pcre perl texinfo)) texinfo is a tool executed during the build process itself, so it should be listed in native-inputs to allow cross-compilation. -- Thanks Thiago