all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#69390] [PATCH 1/3] gnu: go-github-com-vividcortex-ewma: Fix import-path.
  2024-02-25 17:16 [bug#69390] [PATCH 0/3] gnu: go-github-com-cheggaaa-pb-v3: Enable tests Troy Figiel
@ 2024-02-25 17:07 ` Troy Figiel
  2024-02-25 17:11 ` [bug#69390] [PATCH 2/3] gnu: go-github-com-cheggaaa-pb-v3: Enable tests Troy Figiel
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Troy Figiel @ 2024-02-25 17:07 UTC (permalink / raw)
  To: 69390

* gnu/packages/golang.scm (go-github-com-vividcortex-ewma): Fix import-path.
[arguments]<#:import-path>: Use proper capitalization.
---
 gnu/packages/golang.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index e8abaffb56..2c0f3b932a 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -9625,7 +9625,7 @@ (define-public go-github-com-vividcortex-ewma
        (sha256
         (base32 "0whx516l9nm4n41spagb605ry7kfnz1qha96mcshnfjlahhnnylq"))))
     (build-system go-build-system)
-    (arguments '(#:import-path "github.com/vividcortex/ewma"))
+    (arguments '(#:import-path "github.com/VividCortex/ewma"))
     (home-page "https://github.com/VividCortex/ewma")
     (synopsis "Exponentially Weighted Moving Average algorithms for Go")
     (description
-- 
2.42.0





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#69390] [PATCH 2/3] gnu: go-github-com-cheggaaa-pb-v3: Enable tests.
  2024-02-25 17:16 [bug#69390] [PATCH 0/3] gnu: go-github-com-cheggaaa-pb-v3: Enable tests Troy Figiel
  2024-02-25 17:07 ` [bug#69390] [PATCH 1/3] gnu: go-github-com-vividcortex-ewma: Fix import-path Troy Figiel
@ 2024-02-25 17:11 ` Troy Figiel
  2024-02-25 17:13 ` [bug#69390] [PATCH 3/3] gnu: go-github-com-cheggaaa-pb-v3: Remove unnecessary inputs Troy Figiel
  2024-03-06 23:56 ` bug#69390: [PATCH 0/3] gnu: go-github-com-cheggaaa-pb-v3: Enable tests Sharlatan Hellseher
  3 siblings, 0 replies; 5+ messages in thread
From: Troy Figiel @ 2024-02-25 17:11 UTC (permalink / raw)
  To: 69390

* gnu/packages/golang.scm (go-github-com-cheggaaa-pb-v3): Enable tests.
[arguments]<#:tests?>: Set to true.
<#:unpack-path>: Set unpack-path to the repository root.
---
 gnu/packages/golang.scm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 2c0f3b932a..2cff7a0d62 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -8789,9 +8789,7 @@ (define-public go-github-com-cheggaaa-pb-v3
     (build-system go-build-system)
     (arguments
      '(#:import-path "github.com/cheggaaa/pb/v3"
-       ;; XXX: it does have tests but I'm not sure how to run them.
-       ;; go-build-system is looking in the wrong directory.
-       #:tests? #f))
+       #:unpack-path "github.com/cheggaaa/pb"))
     (propagated-inputs
      (list go-golang-org-x-sys
            go-github-com-rivo-uniseg
-- 
2.42.0





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#69390] [PATCH 3/3] gnu: go-github-com-cheggaaa-pb-v3: Remove unnecessary inputs.
  2024-02-25 17:16 [bug#69390] [PATCH 0/3] gnu: go-github-com-cheggaaa-pb-v3: Enable tests Troy Figiel
  2024-02-25 17:07 ` [bug#69390] [PATCH 1/3] gnu: go-github-com-vividcortex-ewma: Fix import-path Troy Figiel
  2024-02-25 17:11 ` [bug#69390] [PATCH 2/3] gnu: go-github-com-cheggaaa-pb-v3: Enable tests Troy Figiel
@ 2024-02-25 17:13 ` Troy Figiel
  2024-03-06 23:56 ` bug#69390: [PATCH 0/3] gnu: go-github-com-cheggaaa-pb-v3: Enable tests Sharlatan Hellseher
  3 siblings, 0 replies; 5+ messages in thread
From: Troy Figiel @ 2024-02-25 17:13 UTC (permalink / raw)
  To: 69390

* gnu/packages/golang.scm (go-github-com-cheggaaa-pb-v3): Remove unnecessary
inputs.
[propagated-inputs]: Remove go-golang-org-x-sys and go-github-com-rivo-uniseg.
---
 gnu/packages/golang.scm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 2cff7a0d62..714322932d 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -8791,9 +8791,7 @@ (define-public go-github-com-cheggaaa-pb-v3
      '(#:import-path "github.com/cheggaaa/pb/v3"
        #:unpack-path "github.com/cheggaaa/pb"))
     (propagated-inputs
-     (list go-golang-org-x-sys
-           go-github-com-rivo-uniseg
-           go-github-com-mattn-go-runewidth
+     (list go-github-com-mattn-go-runewidth
            go-github-com-mattn-go-isatty
            go-github-com-mattn-go-colorable
            go-github-com-fatih-color
-- 
2.42.0





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#69390] [PATCH 0/3] gnu: go-github-com-cheggaaa-pb-v3: Enable tests.
@ 2024-02-25 17:16 Troy Figiel
  2024-02-25 17:07 ` [bug#69390] [PATCH 1/3] gnu: go-github-com-vividcortex-ewma: Fix import-path Troy Figiel
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Troy Figiel @ 2024-02-25 17:16 UTC (permalink / raw)
  To: 69390

This patch series fixes some inaccuracies, enables the tests for
go-github-com-cheggaaa-pb-v3 and cleans up its package definition.

Troy Figiel (3):
  gnu: go-github-com-vividcortex-ewma: Fix import-path.
  gnu: go-github-com-cheggaaa-pb-v3: Enable tests.
  gnu: go-github-com-cheggaaa-pb-v3: Remove unnecessary inputs.

 gnu/packages/golang.scm | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)


base-commit: b25b94335a3ee8d68d2145da8e5ea0325ecea451
-- 
2.42.0





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#69390: [PATCH 0/3] gnu: go-github-com-cheggaaa-pb-v3: Enable tests.
  2024-02-25 17:16 [bug#69390] [PATCH 0/3] gnu: go-github-com-cheggaaa-pb-v3: Enable tests Troy Figiel
                   ` (2 preceding siblings ...)
  2024-02-25 17:13 ` [bug#69390] [PATCH 3/3] gnu: go-github-com-cheggaaa-pb-v3: Remove unnecessary inputs Troy Figiel
@ 2024-03-06 23:56 ` Sharlatan Hellseher
  3 siblings, 0 replies; 5+ messages in thread
From: Sharlatan Hellseher @ 2024-03-06 23:56 UTC (permalink / raw)
  To: 69390-done

[-- Attachment #1: Type: text/plain, Size: 54 bytes --]


Pushed as 2477aea26d..436cd5a625 to master.

--
Oleg

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-03-06 23:58 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-25 17:16 [bug#69390] [PATCH 0/3] gnu: go-github-com-cheggaaa-pb-v3: Enable tests Troy Figiel
2024-02-25 17:07 ` [bug#69390] [PATCH 1/3] gnu: go-github-com-vividcortex-ewma: Fix import-path Troy Figiel
2024-02-25 17:11 ` [bug#69390] [PATCH 2/3] gnu: go-github-com-cheggaaa-pb-v3: Enable tests Troy Figiel
2024-02-25 17:13 ` [bug#69390] [PATCH 3/3] gnu: go-github-com-cheggaaa-pb-v3: Remove unnecessary inputs Troy Figiel
2024-03-06 23:56 ` bug#69390: [PATCH 0/3] gnu: go-github-com-cheggaaa-pb-v3: Enable tests Sharlatan Hellseher

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.