* [bug#69576] [PATCH] scripts: import: elpa: Unquote-splice package sexp contents.
@ 2024-03-06 5:38 Carlo Zancanaro
2024-03-06 11:49 ` bug#69576: " Ricardo Wurmus
0 siblings, 1 reply; 2+ messages in thread
From: Carlo Zancanaro @ 2024-03-06 5:38 UTC (permalink / raw)
To: 69576
Cc: Andrew Tropin, Christopher Baines, Josselin Poiret,
Katherine Cox-Buday, Liliana Marie Prikler, Ludovic Courtès,
Mathieu Othacehe, Ricardo Wurmus, Simon Tournier,
Tobias Geerinckx-Rice
* guix/scripts/import/elpa.scm (guix-import-elpa): Unquote-splice the contents
of the package sexp so the matched package definition is returned unchanged.
Change-Id: Iaaa7e72390c73c6d6671811fe9ac284d599b44c6
---
Without this change the elpa importer doesn't work for me. Importing
anything fails. As an example, try "guix import elpa dash".
With this change, it works for me.
guix/scripts/import/elpa.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/guix/scripts/import/elpa.scm b/guix/scripts/import/elpa.scm
index f587eeb243..7f77beaac0 100644
--- a/guix/scripts/import/elpa.scm
+++ b/guix/scripts/import/elpa.scm
@@ -104,7 +104,7 @@ (define (guix-import-elpa . args)
#:repo (assoc-ref opts 'repo)))
((or #f '())
(leave (G_ "failed to download meta-data for package '~a'~%") package-name))
- (('package etc ...) `(package ,etc))
+ (('package etc ...) `(package ,@etc))
((? list? sexps) (map
(match-lambda
((and ('package ('name name) . rest) pkg)
base-commit: f18d13b5f89c161c6ee88d15ecdaa8d973ee4503
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#69576: [PATCH] scripts: import: elpa: Unquote-splice package sexp contents.
2024-03-06 5:38 [bug#69576] [PATCH] scripts: import: elpa: Unquote-splice package sexp contents Carlo Zancanaro
@ 2024-03-06 11:49 ` Ricardo Wurmus
0 siblings, 0 replies; 2+ messages in thread
From: Ricardo Wurmus @ 2024-03-06 11:49 UTC (permalink / raw)
To: Carlo Zancanaro; +Cc: 69576-done
Carlo Zancanaro <carlo@zancanaro.id.au> writes:
> * guix/scripts/import/elpa.scm (guix-import-elpa): Unquote-splice the contents
> of the package sexp so the matched package definition is returned unchanged.
>
> Change-Id: Iaaa7e72390c73c6d6671811fe9ac284d599b44c6
Applied. Thank you!
> Without this change the elpa importer doesn't work for me. Importing
> anything fails. As an example, try "guix import elpa dash".
>
> With this change, it works for me.
I had run into the same problem a few days ago, so I'm happy that you
came up with a fix so soon. Thanks again!
--
Ricardo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-06 11:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-06 5:38 [bug#69576] [PATCH] scripts: import: elpa: Unquote-splice package sexp contents Carlo Zancanaro
2024-03-06 11:49 ` bug#69576: " Ricardo Wurmus
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.