From: Pierre Langlois <pierre.langlois@gmx.com>
To: 47037@debbugs.gnu.org
Subject: [bug#47037] [PATCH] gnu: emacs-password-store: 2.1.4-1.918992c [security fix].
Date: Wed, 10 Mar 2021 09:25:36 +0000 [thread overview]
Message-ID: <87y2ev5pin.fsf@gmx.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 642 bytes --]
Hi guix!
I noticed the update to the password-store yesterday and so got curious
what changes we had and took a look at the git repository. I was really
happy to find the emacs package includes a fix [0] for a bug I've been
experiencing for a long time, where using pass inside EXWM would
deadlock emacs.
Taking a closer look as well, the commit also fixes a potentially quite
critical security issue with the package, I think we better apply it :-/.
Is this OK to commit? I've tested this locally on EXWM via ivy-pass.
Thanks,
Pierre
[0]: https://git.zx2c4.com/password-store/commit/contrib?id=7aa17d099577730d2d65332896b74d5865b22abf
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 519 bytes --]
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-emacs-password-store-2.1.4-1.918992c-security-fi.patch --]
[-- Type: text/x-patch, Size: 4033 bytes --]
From c49967bd6946887e2314a0817c717391f71794ed Mon Sep 17 00:00:00 2001
From: Pierre Langlois <pierre.langlois@gmx.com>
Date: Wed, 10 Mar 2021 09:12:02 +0000
Subject: [PATCH] gnu: emacs-password-store: 2.1.4-1.918992c [security fix].
Includes a fix to no longer store clear passwords in a temporary file, see
commit 7aa17d099577730d2d65332896b74d5865b22abf for details.
* gnu/packages/emacs-xyz.scm (emacs-password-store): Update to
2.1.4-1.918992c.
[propagated-inputs]: Remove emacs-f, add emacs-auth-source-pass.
---
gnu/packages/emacs-xyz.scm | 67 ++++++++++++++++++++------------------
1 file changed, 35 insertions(+), 32 deletions(-)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b5785505a5..59e968c508 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -15041,39 +15041,42 @@ close, copy, cut, paste, undo, redo.")
(license license:gpl3+))))
(define-public emacs-password-store
- (package
- (name "emacs-password-store")
- (version "1.7.3")
- (source (origin
- (method url-fetch)
- (uri
- (string-append "https://git.zx2c4.com/password-store/snapshot/"
- "password-store-" version ".tar.xz"))
- (sha256
- (base32
- "1x53k5dn3cdmvy8m4fqdld4hji5n676ksl0ql4armkmsds26av1b"))))
- (build-system emacs-build-system)
- (arguments
- `(#:phases
- (modify-phases %standard-phases
- (add-after 'unpack 'extract-el-file
- (lambda _
- (copy-file "contrib/emacs/password-store.el" "password-store.el")
- (delete-file-recursively "contrib")
- (delete-file-recursively "man")
- (delete-file-recursively "src")
- (delete-file-recursively "tests"))))))
- (propagated-inputs
- `(("emacs-f" ,emacs-f)
- ("emacs-s" ,emacs-s)
- ("emacs-with-editor" ,emacs-with-editor)
- ("password-store" ,password-store)))
- (home-page "https://git.zx2c4.com/password-store/tree/contrib/emacs")
- (synopsis "Password store (pass) support for Emacs")
- (description
- "This package provides functions for working with pass (\"the
+ (let ((commit "918992c19231b33b3d4a3288a7288a620e608cb4")
+ (revision "1"))
+ (package
+ (name "emacs-password-store")
+ (version (git-version "2.1.4" revision commit))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "git://git.zx2c4.com/password-store")
+ (commit commit)))
+ (sha256
+ (base32
+ "0ni62f4pq96g0i0q66bch1dl9k4zqwhg7xaf746k3gbbqxcdh3vi"))
+ (file-name (git-file-name name version))))
+ (build-system emacs-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'extract-el-file
+ (lambda _
+ (copy-file "contrib/emacs/password-store.el" "password-store.el")
+ (delete-file-recursively "contrib")
+ (delete-file-recursively "man")
+ (delete-file-recursively "src")
+ (delete-file-recursively "tests"))))))
+ (propagated-inputs
+ `(("emacs-auth-source-pass" ,emacs-auth-source-pass)
+ ("emacs-s" ,emacs-s)
+ ("emacs-with-editor" ,emacs-with-editor)
+ ("password-store" ,password-store)))
+ (home-page "https://git.zx2c4.com/password-store/tree/contrib/emacs")
+ (synopsis "Password store (pass) support for Emacs")
+ (description
+ "This package provides functions for working with pass (\"the
standard Unix password manager\").")
- (license license:gpl2+)))
+ (license license:gpl2+))))
(define-public emacs-auth-source-pass
(let ((commit "847a1f54ed48856b4dfaaa184583ef2c84173edf")
--
2.30.1
next reply other threads:[~2021-03-10 9:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 9:25 Pierre Langlois [this message]
2021-03-11 10:04 ` bug#47037: [PATCH] gnu: emacs-password-store: 2.1.4-1.918992c [security fix] Pierre Langlois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2ev5pin.fsf@gmx.com \
--to=pierre.langlois@gmx.com \
--cc=47037@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.