From: "Ludovic Courtès" <ludo@gnu.org>
To: Timothy Sample <samplet@ngyro.com>
Cc: 47336@debbugs.gnu.org
Subject: [bug#47336] Disarchive as a fallback for downloads
Date: Sat, 27 Mar 2021 11:57:12 +0100 [thread overview]
Message-ID: <87y2e8zwxj.fsf_-_@gnu.org> (raw)
In-Reply-To: <20210323045213.9419-2-samplet@ngyro.com> (Timothy Sample's message of "Tue, 23 Mar 2021 00:52:13 -0400")
Hi!
Timothy Sample <samplet@ngyro.com> skribis:
> * guix/download.scm (%disarchive-mirrors): New variable.
> (%disarchive-mirror-file): New variable.
> (built-in-download): Add 'disarchive-mirrors' keyword argument and
> pass its value along to the 'builtin:download' derivation.
> (url-fetch): Pass '%disarchive-mirror-file' to 'built-in-download'.
> * guix/scripts/perform-download.scm (perform-download): Read
> Disarchive mirrors from the environment and pass them to
> 'url-fetch'.
> * guix/build/download.scm (disarchive-fetch/any): New procedure.
> (url-fetch): Add 'disarchive-mirrors' keyword argument, use it to
> make a list of URIs, and use the new procedure to fetch the file if
> all other methods fail.
[...]
> + #:use-module (guix base16)
> #:use-module (guix base64)
> #:use-module (guix ftp-client)
> #:use-module (guix build utils)
> #:use-module (guix progress)
> + #:use-module (guix swh)
Maybe #:autoload them.
> +(define* (disarchive-fetch/any uris file
> + #:key (timeout 10))
> + "Fetch a Disarchive specification from any of URIS, assemble it,
> +and write the output to FILE."
> + (define (fetch-specification uris)
> + (any (lambda (uri)
> + (false-if-exception*
> + (let-values (((port size) (http-fetch uri
> + #:verify-certificate? #t
> + #:timeout timeout)))
Perhaps add #:key (verify-certificate? #t) and have the caller pass it?
Currently (guix scripts perform-download) sets it to #f, which is a good
idea IMO.
> + (match (and=> (resolve-module '(disarchive) #:ensure #f)
> + (lambda (disarchive)
> + (cons (module-ref disarchive '%disarchive-log-port)
> + (module-ref disarchive 'disarchive-assemble))))
> + (#f #f)
> + ((%disarchive-log-port . disarchive-assemble)
> + (format #t "Trying to use Disarchive to assemble ~a~%" file)
> + (match (fetch-specification uris)
> + (#f #f)
> + (spec (parameterize ((%disarchive-log-port (current-output-port)))
> + (disarchive-assemble spec file #:resolver resolve)))))))
So we would normally arrange so that the ‘guix’ package depends on
Disarchive, such that the above ‘resolve-module’ call works when done
via ‘guix perform-download’, right?
In the #f case, perhaps we should print something like “Disarchive not
found, bailing out”?
That’s all I have to say; it looks great to me!
That’s quite a milestone, it’d be great to have that in the upcoming
release. Next we can discuss how to populate the Disarchive database
and where to do that (or your hosting fees could easily skyrocket :-)).
I suppose we could run that in Berlin and/or we could make an argument
about using SWH or Inria resources for that.
Thanks,
Ludo’.
next prev parent reply other threads:[~2021-03-27 10:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 4:42 bug#47336: Disarchive as a fallback for downloads Timothy Sample
2021-03-23 4:52 ` bug#47336: [PATCH 1/2] swh: Add a directory download procedure Timothy Sample
2021-03-23 4:52 ` bug#47336: [PATCH 2/2] download: Use Disarchive as a last resort Timothy Sample
2021-03-27 10:57 ` Ludovic Courtès [this message]
2021-03-27 10:40 ` [bug#47336] Disarchive as a fallback for downloads Ludovic Courtès
2021-04-10 20:52 ` Ludovic Courtès
2021-04-26 9:49 ` Ludovic Courtès
2021-04-28 2:30 ` bug#47336: " Timothy Sample
2021-04-28 7:01 ` [bug#47336] " Timothy Sample
2021-04-29 7:48 ` Ludovic Courtès
2021-04-29 17:24 ` bug#47336: " Timothy Sample
2021-03-23 5:11 ` Timothy Sample
2021-03-23 9:35 ` [bug#47336] " zimoun
2021-03-23 14:31 ` Timothy Sample
2021-03-27 10:39 ` Ludovic Courtès
2021-05-14 21:36 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2e8zwxj.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=47336@debbugs.gnu.org \
--cc=samplet@ngyro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.