all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Timothy Sample <samplet@ngyro.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: control@debbugs.gnu.org, 47336@debbugs.gnu.org
Subject: [bug#47336] Disarchive as a fallback for downloads
Date: Wed, 28 Apr 2021 03:01:55 -0400	[thread overview]
Message-ID: <87h7jqlwnw.fsf@ngyro.com> (raw)
In-Reply-To: <87o8dzkunk.fsf_-_@ngyro.com> (Timothy Sample's message of "Tue,  27 Apr 2021 22:30:39 -0400")

reopen 47336
thanks

Hi again,

Timothy Sample <samplet@ngyro.com> writes:

> I just pushed this series [...]

And broke “guix pull”!!  (I somehow fooled myself into thinking that I
had already tested with “guix pull --url=...” locally.)  I reverted the
offending commit.

It turns out that adding a reference from “(guix build download)” to
“(guix swh)” breaks “compute-guix-derivation” in
“build-aux/build-self.scm”.  This is because “(guix swh)” references
“(json)”, which is not available in the “compute-guix-derivation”
environment.  I tried mimicking the “fake-git” trick, but it didn’t work
(I guess it needs the “define-json-mapping” macro at compile time).

Everything works if I remove the #:autoload for “(guix swh)” and put

  ;; If we import (guix swh) directly, we introduce a compile-time
  ;; dependency on Guile-JSON.  This breaks the "build-self" code, which
  ;; needs to build this module without Guile-JSON.  Hence, we track
  ;; down the following procedure at runtime.
  (define swh-download-directory
    (module-ref (resolve-module '(guix swh)) 'swh-download-directory))

inside of “disarchive-fetch/any” (just before it’s needed).  Does this
approach look okay?


-- Tim




  reply	other threads:[~2021-04-28  7:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23  4:42 bug#47336: Disarchive as a fallback for downloads Timothy Sample
2021-03-23  4:52 ` bug#47336: [PATCH 1/2] swh: Add a directory download procedure Timothy Sample
2021-03-23  4:52   ` bug#47336: [PATCH 2/2] download: Use Disarchive as a last resort Timothy Sample
2021-03-27 10:57     ` [bug#47336] Disarchive as a fallback for downloads Ludovic Courtès
2021-03-27 10:40   ` Ludovic Courtès
2021-04-10 20:52     ` Ludovic Courtès
2021-04-26  9:49     ` Ludovic Courtès
2021-04-28  2:30       ` bug#47336: " Timothy Sample
2021-04-28  7:01         ` Timothy Sample [this message]
2021-04-29  7:48           ` [bug#47336] " Ludovic Courtès
2021-04-29 17:24             ` bug#47336: " Timothy Sample
2021-03-23  5:11 ` Timothy Sample
2021-03-23  9:35 ` [bug#47336] " zimoun
2021-03-23 14:31   ` Timothy Sample
2021-03-27 10:39     ` Ludovic Courtès
2021-05-14 21:36 ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7jqlwnw.fsf@ngyro.com \
    --to=samplet@ngyro.com \
    --cc=47336@debbugs.gnu.org \
    --cc=control@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.