From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 53213-done@debbugs.gnu.org
Subject: bug#53213: [PATCH] daemon: Always default to gzip for log compression.
Date: Tue, 18 Jan 2022 18:53:05 +0100 [thread overview]
Message-ID: <87y23dc4n2.fsf_-_@gnu.org> (raw)
In-Reply-To: <87ilunxcsc.fsf@gmail.com> (Maxim Cournoyer's message of "Thu, 13 Jan 2022 21:37:55 -0500")
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> * nix/libstore/globals.cc (Settings::Settings): Have 'logCompression'
>> default to COMPRESSION_GZIP unconditionally.
>> * gnu/services/base.scm (<guix-configuration>)[log-compression]: Default
>> to 'gzip.
>> * doc/guix.texi (Invoking guix-daemon, Base Services): Adjust accordingly.
>> ---
>> doc/guix.texi | 4 ++--
>> gnu/services/base.scm | 2 +-
>> nix/libstore/globals.cc | 4 ----
>> 3 files changed, 3 insertions(+), 7 deletions(-)
>>
>> Hello!
>>
>> I think bzip2 compression of the build logs doesn’t buy us much, it
>> doesn’t play well with ‘guix publish’, and bzip2 is generally rather
>> uncommon these days—hence this patch.
>>
>> Thoughts?
>>
>> Ludo’.
>
> I haven't tried it, but the idea and code LGTM.
Pushed in 575e52ac2b090fd194086e9c1c53bbf8055acbc2, thanks!
Ludo’.
prev parent reply other threads:[~2022-01-18 17:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 17:21 [bug#53213] [PATCH] daemon: Always default to gzip for log compression Ludovic Courtès
2022-01-14 2:37 ` Maxim Cournoyer
2022-01-18 17:53 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y23dc4n2.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=53213-done@debbugs.gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.